[GitHub] [nifi] patricker commented on a change in pull request #4407: NIFI-7623 Take unnecessary behavior out when using registry to update…

[GitBox <gi...@apache.org>]

patricker commented on a change in pull request #4407:
URL: https://github.com/apache/nifi/pull/4407#discussion_r492747448



##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/util/FlowDifferenceFilters.java
##########
@@ -121,6 +121,20 @@ public static boolean isIgnorableVersionedFlowCoordinateChange(final FlowDiffere
         return false;
     }
 
+    /**
+     * Predicate that returns true if the difference can NOT be modified in running state, and false if it can.
+     */
+    public static Predicate<FlowDifference> FILTER_MODIFIABLE_IN_RUNNING_STATE = (fd) -> !isModifiableInRunningState(fd);

Review comment:
       @s9514171 The name of this variable is confusing. Your comment says, "true if the difference can NOT be modified".  Can you include NOT in the variable name?  Right now it sounds like the opposite.
   
   `FILTER_NOT_MODIFIABLE_IN_RUNNING_STATE = (fd) -> isModifiableInRunningState(fd);`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org