[jira] [Comment Edited] (ZOOKEEPER-2080) ReconfigRecoveryTest fails intermittently

["Michael Han (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403146#comment-15403146 ] 

Michael Han edited comment on ZOOKEEPER-2080 at 8/2/16 1:02 AM:
----------------------------------------------------------------

[~rgs] Thanks for your feedback :). New patch uploaded based on your feedback.

bq. Do we really need to synchronize around self for the first part
Good point, self.configFromString does not involve state changes and for self.getQuorumVerifier, I can't find another place in code where a race could be possibly introduced that require self.getQuorumVerifier and the subsequent to be an atomic code block - so I moved them out of sync block and updated patch. CC [~shralex] just to double check.

bq. could you maybe add a comment before the synchronize(self) block 
Comments added in latest patch.


was (Author: hanm):
[~rgs] Thanks for your feedback :)

bq. Do we really need to synchronize around self for the first part
Good point, self.configFromString does not involve state changes and for self.getQuorumVerifier, I can't find another place in code where a race could be possibly introduced that require self.getQuorumVerifier and the subsequent to be an atomic code block - so I moved them out of sync block and updated patch. CC [~shralex] just to double check.

bq. could you maybe add a comment before the synchronize(self) block 
Comments added in latest patch.

> ReconfigRecoveryTest fails intermittently
> -----------------------------------------
>
>                 Key: ZOOKEEPER-2080
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2080
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Michael Han
>             Fix For: 3.5.3, 3.6.0
>
>         Attachments: ZOOKEEPER-2080.patch, ZOOKEEPER-2080.patch, ZOOKEEPER-2080.patch, jacoco-ZOOKEEPER-2080.unzip-grows-to-70MB.7z, repro-20150816.log, threaddump.log
>
>
> I got the following test failure on MacBook with trunk code:
> {code}
> Testcase: testCurrentObserverIsParticipantInNewConfig took 93.628 sec
>   FAILED
> waiting for server 2 being up
> junit.framework.AssertionFailedError: waiting for server 2 being up
>   at org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:529)
>   at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)