You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@nemo.apache.org by GitBox <gi...@apache.org> on 2019/12/04 07:55:54 UTC

[GitHub] [incubator-nemo] johnyangk commented on a change in pull request #270: [NEMO-429] SWPP TEAM4 Code Smell Fix

johnyangk commented on a change in pull request #270: [NEMO-429] SWPP TEAM4 Code Smell Fix
URL: https://github.com/apache/incubator-nemo/pull/270#discussion_r353589838
 
 

 ##########
 File path: common/src/main/java/org/apache/nemo/common/StateMachine.java
 ##########
 @@ -255,7 +258,7 @@ private Builder() {
      */
     public Builder addState(final Enum stateEnum, final String description) {
       if (stateEnumSet.contains(stateEnum)) {
-        throw new RuntimeException("A state " + stateEnum + " was already added");
+        throw new RuntimeException(RE_prefix + stateEnum + " was already added");
 
 Review comment:
   stateEnum + " was already added"
   
   (drop RE_prefix)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services