[GitHub] [kafka] cmccabe commented on pull request #9736: Add configurable workloads and E2E latency tracking to Trogdor.

[GitBox <gi...@apache.org>]

cmccabe commented on pull request #9736:
URL: https://github.com/apache/kafka/pull/9736#issuecomment-743467898


   Thanks for this, @scott-hendricks ... it looks really cool.
   
   Can you say a bit more about the decision to put the timestamp into the message, rather than using the timestamp which Kafka itself puts on every message?  I guess one reason to do this would be that you don't have to rely on how the broker is configured to set the timestamp.  It would be good to understand the tradeoffs.
   
   Is there a reason to have a timestamp size other than 8 bytes?  If not, then we don't need to make this configurable.
   
   ConfigurableProducerWorker looks a lot like ProduceBenchWorker.  Maybe it's OK to have two classes here, but I'd like to understand why we should.  ProduceBenchWorker is also intended to be configurable, so I'm not sure why as a user I'd use one or the other.  Can we merge these?
   
   It's nice to see gaussian distributions here where you can set the variance!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org