[GitHub] incubator-rocketmq pull request #105: [ROCKETMQ-200]-Cluster name is always ...

[Jaskey <gi...@git.apache.org>]

Github user Jaskey commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/105#discussion_r119535996
  
    --- Diff: namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java ---
    @@ -125,11 +125,7 @@ public RegisterBrokerResult registerBroker(
                     BrokerData brokerData = this.brokerAddrTable.get(brokerName);
                     if (null == brokerData) {
                         registerFirst = true;
    -                    brokerData = new BrokerData();
    -                    brokerData.setBrokerName(brokerName);
    -                    HashMap<Long, String> brokerAddrs = new HashMap<Long, String>();
    -                    brokerData.setBrokerAddrs(brokerAddrs);
    -
    +                    brokerData = new BrokerData(clusterName, brokerName, new HashMap<Long, String>());
    --- End diff --
    
    this cluster name is passed from the caller, it should be maintained by the caller.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---