You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tamaya.apache.org by an...@apache.org on 2019/05/14 15:30:10 UTC

[incubator-tamaya-sandbox] branch master updated: Fixed quality issues.

This is an automated email from the ASF dual-hosted git repository.

anatole pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tamaya-sandbox.git


The following commit(s) were added to refs/heads/master by this push:
     new c7792ff  Fixed quality issues.
c7792ff is described below

commit c7792ffa123269f99276b3c69a892cd8fb9d5f02
Author: Anatole Tresch <at...@gmail.com>
AuthorDate: Tue May 14 17:29:55 2019 +0200

    Fixed quality issues.
---
 .../main/java/org/apache/tamaya/jsr382/TamayaConfigAccessor.java    | 1 -
 .../src/main/java/org/apache/tamaya/metamodel/MetaContext.java      | 6 ++++++
 .../java/org/apache/tamaya/metamodel/spi/ContextInitializer.java    | 2 +-
 .../java/org/apache/tamaya/vertx/ConfiguredVerticleFactory.java     | 1 -
 .../java/org/apache/tamaya/vertx/TamayaConfigurationProducer.java   | 1 -
 5 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/configjsr/src/main/java/org/apache/tamaya/jsr382/TamayaConfigAccessor.java b/configjsr/src/main/java/org/apache/tamaya/jsr382/TamayaConfigAccessor.java
index a0625ce..a89a868 100644
--- a/configjsr/src/main/java/org/apache/tamaya/jsr382/TamayaConfigAccessor.java
+++ b/configjsr/src/main/java/org/apache/tamaya/jsr382/TamayaConfigAccessor.java
@@ -25,7 +25,6 @@ import javax.config.ConfigSnapshot;
 import javax.config.spi.Converter;
 import java.time.Duration;
 import java.util.*;
-import java.util.concurrent.TimeUnit;
 
 /**
  * Tamaya implementation type for the {@link ConfigAccessor} type.
diff --git a/metamodel/src/main/java/org/apache/tamaya/metamodel/MetaContext.java b/metamodel/src/main/java/org/apache/tamaya/metamodel/MetaContext.java
index 3ada4d6..d4bf5b5 100644
--- a/metamodel/src/main/java/org/apache/tamaya/metamodel/MetaContext.java
+++ b/metamodel/src/main/java/org/apache/tamaya/metamodel/MetaContext.java
@@ -130,6 +130,7 @@ public final class MetaContext {
     /**
      * Access the given context property.
      * @param key the key, not null
+     * @param type the property type, not null.
      * @return the createValue, or null.
      */
     public <T> Optional<T> getProperty(String key, Class<T> type){
@@ -171,6 +172,8 @@ public final class MetaContext {
      * Sets the given context property.
      * @param key the key, not null.
      * @param value the createValue, not null.
+     * @param type the property type, not null.
+     * @param <T> the type
      * @return the previous createValue, or null.
      */
     public <T> T setProperty(String key, Class<T> type, T value){
@@ -185,6 +188,9 @@ public final class MetaContext {
      * Sets the given property unless there is already a createValue defined.
      * @param key the key, not null.
      * @param value the createValue, not null.
+     * @param type the property type, not null.
+     * @param <T> the type
+     * @return the value
      */
     public <T> T setPropertyIfAbsent(String key, Class<T> type, T value){
         T prev = (T)this.properties.get(key);
diff --git a/metamodel/src/main/java/org/apache/tamaya/metamodel/spi/ContextInitializer.java b/metamodel/src/main/java/org/apache/tamaya/metamodel/spi/ContextInitializer.java
index aedf7df..e86f8bf 100644
--- a/metamodel/src/main/java/org/apache/tamaya/metamodel/spi/ContextInitializer.java
+++ b/metamodel/src/main/java/org/apache/tamaya/metamodel/spi/ContextInitializer.java
@@ -29,7 +29,7 @@ public interface ContextInitializer {
     /**
      * Get the expression id, which is the first part of a placeholder expression
      * ({@code ${expressionId:expression}}).
-     * @return the expression id, never null.
+     * @param metaContext the neta context, not null..
      */
     void initializeContext(MetaContext metaContext);
 
diff --git a/vertx/src/main/java/org/apache/tamaya/vertx/ConfiguredVerticleFactory.java b/vertx/src/main/java/org/apache/tamaya/vertx/ConfiguredVerticleFactory.java
index b5051da..0e7e95a 100644
--- a/vertx/src/main/java/org/apache/tamaya/vertx/ConfiguredVerticleFactory.java
+++ b/vertx/src/main/java/org/apache/tamaya/vertx/ConfiguredVerticleFactory.java
@@ -21,7 +21,6 @@ package org.apache.tamaya.vertx;
 import io.vertx.core.Verticle;
 import io.vertx.core.impl.verticle.CompilingClassLoader;
 import io.vertx.core.spi.VerticleFactory;
-import org.apache.tamaya.inject.ConfigurationInjection;
 import org.apache.tamaya.inject.ConfigurationInjector;
 
 /**
diff --git a/vertx/src/main/java/org/apache/tamaya/vertx/TamayaConfigurationProducer.java b/vertx/src/main/java/org/apache/tamaya/vertx/TamayaConfigurationProducer.java
index 0ee0aeb..aaaafc3 100644
--- a/vertx/src/main/java/org/apache/tamaya/vertx/TamayaConfigurationProducer.java
+++ b/vertx/src/main/java/org/apache/tamaya/vertx/TamayaConfigurationProducer.java
@@ -27,7 +27,6 @@ import io.vertx.core.json.JsonArray;
 import io.vertx.core.json.JsonObject;
 import org.apache.tamaya.Configuration;
 import org.apache.tamaya.functions.ConfigurationFunctions;
-import org.apache.tamaya.inject.ConfigurationInjection;
 import org.apache.tamaya.inject.ConfigurationInjector;
 import org.apache.tamaya.inject.api.Config;