You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "whhe (via GitHub)" <gi...@apache.org> on 2023/09/06 10:58:18 UTC
[GitHub] [seatunnel] whhe opened a new pull request, #5439: [Feature][Connector-V2][Jdbc] Add OceanBase catalog
whhe opened a new pull request, #5439:
URL: https://github.com/apache/seatunnel/pull/5439
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
Add OceanBase catalog in jdbc connector, close #5076.
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] whhe commented on pull request #5439: [Feature][Connector-V2][Jdbc] Add OceanBase catalog
Posted by "whhe (via GitHub)" <gi...@apache.org>.
whhe commented on PR #5439:
URL: https://github.com/apache/seatunnel/pull/5439#issuecomment-1713726155
@EricJoy2048 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] whhe closed pull request #5439: [Feature][Connector-V2][Jdbc] Add OceanBase catalog
Posted by "whhe (via GitHub)" <gi...@apache.org>.
whhe closed pull request #5439: [Feature][Connector-V2][Jdbc] Add OceanBase catalog
URL: https://github.com/apache/seatunnel/pull/5439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Connector-V2][Jdbc] Add OceanBase catalog [seatunnel]
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y merged PR #5439:
URL: https://github.com/apache/seatunnel/pull/5439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Connector-V2][Jdbc] Add OceanBase catalog [seatunnel]
Posted by "whhe (via GitHub)" <gi...@apache.org>.
whhe commented on PR #5439:
URL: https://github.com/apache/seatunnel/pull/5439#issuecomment-1755421444
The ci failure is not related to this pr. I tried the case `JdbcVerticaIT` on my dev machine and it executed successfully, it's a little weird.
https://github.com/whhe/incubator-seatunnel/actions/runs/6465553249/job/17560811546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] whhe commented on pull request #5439: [Feature][Connector-V2][Jdbc] Add OceanBase catalog
Posted by "whhe (via GitHub)" <gi...@apache.org>.
whhe commented on PR #5439:
URL: https://github.com/apache/seatunnel/pull/5439#issuecomment-1713364310
Tested on my dev environment and all tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] whhe commented on pull request #5439: [Feature][Connector-V2][Jdbc] Add OceanBase catalog
Posted by "whhe (via GitHub)" <gi...@apache.org>.
whhe commented on PR #5439:
URL: https://github.com/apache/seatunnel/pull/5439#issuecomment-1738357403
I tried to enable the oceanbase it case with the new docker image, and there are still some issues about the container startup, which I will fix in another pr. The label is removed by the bot, PTAL again @EricJoy2048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Connector-V2][Jdbc] Add OceanBase catalog [seatunnel]
Posted by "whhe (via GitHub)" <gi...@apache.org>.
whhe commented on PR #5439:
URL: https://github.com/apache/seatunnel/pull/5439#issuecomment-1759270967
https://github.com/whhe/incubator-seatunnel/actions/runs/6492005114/job/17630374248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org