[GitHub] [tez] abstractdog commented on a change in pull request #117: TEZ-4302: NullPointerException in CodecUtils when bufferSizeProp is null

[GitBox <gi...@apache.org>]

abstractdog commented on a change in pull request #117:
URL: https://github.com/apache/tez/pull/117#discussion_r609483156



##########
File path: tez-runtime-library/src/main/java/org/apache/tez/runtime/library/utils/CodecUtils.java
##########
@@ -78,7 +78,8 @@ public static InputStream getDecompressedInputStreamWithBufferSize(CompressionCo
       throws IOException {
     String bufferSizeProp = TezRuntimeUtils.getBufferSizeProperty(codec);
     Configurable configurableCodec = (Configurable) codec;
-    int originalSize = configurableCodec.getConf().getInt(bufferSizeProp, DEFAULT_BUFFER_SIZE);
+    int originalSize = bufferSizeProp == null ? DEFAULT_BUFFER_SIZE :

Review comment:
       thanks @jshmchenxi, this looks like an important bugfix
   before merging this, could you please clarify what kind of coded have you used?
   if bufferSizeProp is null, it means that the codec is not supported by [TezRuntimeUtils.getBufferSizeProperty](https://github.com/apache/tez/blob/master/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/TezRuntimeUtils.java#L269)
   if it's a codec supported by hadoop, we should add it, otherwise the DEFAULT_BUFFER_SIZE fallback makes sense




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org