You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "dannymartinm (via GitHub)" <gi...@apache.org> on 2023/02/10 12:55:30 UTC
[GitHub] [beam] dannymartinm opened a new pull request, #23162: [GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners
dannymartinm opened a new pull request, #23162:
URL: https://github.com/apache/beam/pull/23162
`DO NOT MERGE until the infrastructure is in place. Please talk to @dannymartinm @elink21 before merging`
As part of the issue [21106](https://github.com/apache/beam/issues/21106), @elink21 and I have implemented the self-hosted runners for the Ubuntu and Windows operating systems.
Please see the Approved Pull Request ([PR#22703](https://github.com/apache/beam/pull/22703)) for reference.
In this PR you will find the following changes:
* Updates in workflow Playground Deploy Examples to `runs-on` self-hosted runners
* Ubuntu
[PR#16511 ](https://github.com/apache/beam/pull/16511): Previous PR for reference.
[BEAM-12812](https://issues.apache.org/jira/browse/BEAM-12812): Original Jira may contain additional context.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] elink21 commented on pull request #23162: [GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners
Posted by GitBox <gi...@apache.org>.
elink21 commented on PR #23162:
URL: https://github.com/apache/beam/pull/23162#issuecomment-1308958487
Status update: reviewed by @damccorm, waiting for the migration window to deploy the infrastructure and request the merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm closed pull request #23162: [GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed pull request #23162: [GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners
URL: https://github.com/apache/beam/pull/23162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dannymartinm commented on a diff in pull request #23162: [GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners
Posted by GitBox <gi...@apache.org>.
dannymartinm commented on code in PR #23162:
URL: https://github.com/apache/beam/pull/23162#discussion_r970167996
##########
.github/workflows/playground_deploy_examples.yml:
##########
@@ -26,23 +25,33 @@ env:
BEAM_VERSION: 2.40.0
K8S_NAMESPACE: playground-backend
HELM_APP_NAME: playground-backend
+permissions: read-all
jobs:
check_examples:
name: Check examples
- runs-on: ubuntu-latest
+ runs-on: [self-hosted, ubuntu-20.04]
outputs:
example_has_changed: ${{ steps.check_has_example.outputs.example_has_changed }}
steps:
- name: Check out the repo
uses: actions/checkout@v3
with:
fetch-depth: 0
+ ref: ${{ github.event.pull_request.head.sha }}
- uses: actions/setup-python@v4
with:
python-version: '3.8'
- name: install deps
run: pip install -r requirements.txt
working-directory: playground/infrastructure
+ - name: Install PowerShell
Review Comment:
In general, we are adding the required installations to make the workflows work. In this case, we are afraid that by changing this block of code into bash shell the job may get broken.
As we don't really know the reason behind this PowerShell decision, we suggest to create a new task/issue for this change.
Please let us know your comments. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23162: [GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23162:
URL: https://github.com/apache/beam/pull/23162#issuecomment-1425762708
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23162: [GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23162:
URL: https://github.com/apache/beam/pull/23162#discussion_r969741537
##########
.github/workflows/playground_deploy_examples.yml:
##########
@@ -26,23 +25,33 @@ env:
BEAM_VERSION: 2.40.0
K8S_NAMESPACE: playground-backend
HELM_APP_NAME: playground-backend
+permissions: read-all
jobs:
check_examples:
name: Check examples
- runs-on: ubuntu-latest
+ runs-on: [self-hosted, ubuntu-20.04]
outputs:
example_has_changed: ${{ steps.check_has_example.outputs.example_has_changed }}
steps:
- name: Check out the repo
uses: actions/checkout@v3
with:
fetch-depth: 0
+ ref: ${{ github.event.pull_request.head.sha }}
- uses: actions/setup-python@v4
with:
python-version: '3.8'
- name: install deps
run: pip install -r requirements.txt
working-directory: playground/infrastructure
+ - name: Install PowerShell
Review Comment:
Rather than installing powershell, can we just convert the `pwsh` block below to a more generic script block? It isn't doing anything that a bash shell shouldn't be able to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] closed pull request #23162: [GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #23162: [GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners
URL: https://github.com/apache/beam/pull/23162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23162: [GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23162:
URL: https://github.com/apache/beam/pull/23162#issuecomment-1335150579
Reminder, please take a look at this pr: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23162: [GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23162:
URL: https://github.com/apache/beam/pull/23162#issuecomment-1413690986
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23162: [GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23162:
URL: https://github.com/apache/beam/pull/23162#discussion_r970797975
##########
.github/workflows/playground_deploy_examples.yml:
##########
@@ -26,23 +25,33 @@ env:
BEAM_VERSION: 2.40.0
K8S_NAMESPACE: playground-backend
HELM_APP_NAME: playground-backend
+permissions: read-all
jobs:
check_examples:
name: Check examples
- runs-on: ubuntu-latest
+ runs-on: [self-hosted, ubuntu-20.04]
outputs:
example_has_changed: ${{ steps.check_has_example.outputs.example_has_changed }}
steps:
- name: Check out the repo
uses: actions/checkout@v3
with:
fetch-depth: 0
+ ref: ${{ github.event.pull_request.head.sha }}
- uses: actions/setup-python@v4
with:
python-version: '3.8'
- name: install deps
run: pip install -r requirements.txt
working-directory: playground/infrastructure
+ - name: Install PowerShell
Review Comment:
> we suggest to create a new task/issue for this change.
That's fine by me, this doesn't need to be blocking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dannymartinm commented on pull request #23162: [GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners
Posted by GitBox <gi...@apache.org>.
dannymartinm commented on PR #23162:
URL: https://github.com/apache/beam/pull/23162#issuecomment-1244717584
Hi @Abacn @damccorm, could you help us with a PR review please?
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23162: [GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23162:
URL: https://github.com/apache/beam/pull/23162#issuecomment-1242501505
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org