Re: svn commit: r1359898 - /jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCacheManager.java

[sebb <se...@gmail.com>]

On 10 July 2012 22:00,  <pm...@apache.org> wrote:
> Author: pmouawad
> Date: Tue Jul 10 21:00:33 2012
> New Revision: 1359898
>
> URL: http://svn.apache.org/viewvc?rev=1359898&view=rev
> Log:
> Bug 53522 - Cache Manager should not store at all response with header "no-cache" and store other types of Cache-Control having max-age value (edit)
>
> Fix broken test

Oops!
Sorry, should have checked the tests.

> Bugzilla Id: 53522
>
> Modified:
>     jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCacheManager.java
>
> Modified: jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCacheManager.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCacheManager.java?rev=1359898&r1=1359897&r2=1359898&view=diff
> ==============================================================================
> --- jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCacheManager.java (original)
> +++ jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCacheManager.java Tue Jul 10 21:00:33 2012
> @@ -258,7 +258,7 @@ public class TestCacheManager extends JM
>          assertFalse("Should not find valid entry",this.cacheManager.inCache(url));
>          ((HttpMethodStub)httpMethod).cacheControl="no-cache";
>          this.cacheManager.saveDetails(httpMethod, sampleResultOK);
> -        assertNull("Should find entry",getThreadCacheEntry(LOCAL_HOST));
> +        assertNotNull("Should find entry",getThreadCacheEntry(LOCAL_HOST));
>          assertFalse("Should not find valid entry",this.cacheManager.inCache(url));
>      }
>
>
>