You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "yusufyildiz34 (via GitHub)" <gi...@apache.org> on 2026/10/19 01:02:58 UTC
[PR] Parquet: Fix UnsupportedOperationException for boolean filters [iceberg]
yusufyildiz34 opened a new pull request, #18580:
URL: https://github.com/apache/iceberg/pull/18580
`ParquetFilters` converts Iceberg filters for the parquet-mr read path (`Parquet.read()` without a reader function). For boolean columns it only handled `EQ`/`NOT_EQ`, and those failed because `getParquetPrimitive` did not accept `Boolean` literals; `IS_NULL`/`NOT_NULL` were not handled at all. Any of these predicates made the read fail with `UnsupportedOperationException` before returning rows. This passes `Boolean` literals through like numbers and maps `IS_NULL`/`NOT_NULL` to Parquet null comparisons, as the other column types do. It continues #17093, which the stale bot closed without review; the null predicates are new here.
Closes #17092
Test plan: four `TestParquet` cases read a file with a boolean column using `equal`, `notEqual`, `isNull` and `notNull` filters; all fail on main and pass with this change.
---
**AI Disclosure**
- Model: Claude Opus 5.5
- Platform/Tool: Claude Code
- Human Oversight: fully reviewed
- Prompt Summary: Investigate #17092, reproduce it with failing TestParquet cases, and fix boolean predicate conversion in ParquetFilters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Fix UnsupportedOperationException for boolean filters [iceberg]
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao merged PR #18580:
URL: https://github.com/apache/iceberg/pull/18580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Fix UnsupportedOperationException for boolean filters [iceberg]
Posted by "yusufyildiz34 (via GitHub)" <gi...@apache.org>.
yusufyildiz34 commented on code in PR #18580:
URL: https://github.com/apache/iceberg/pull/18580#discussion_r4337645129
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java:
##########
@@ -101,6 +105,9 @@
import org.junit.jupiter.api.io.TempDir;
public class TestParquet {
+ private static final Schema BOOLEAN_SCHEMA =
Review Comment:
Done in 7d2ac2678, the boolean filter tests now define their schema locally like the other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Fix UnsupportedOperationException for boolean filters [iceberg]
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on PR #18580:
URL: https://github.com/apache/iceberg/pull/18580#issuecomment-6327331049
Thanks @yusufyildiz34 for the PR! Thanks @pvary @nssalian for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Fix UnsupportedOperationException for boolean filters [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on code in PR #18580:
URL: https://github.com/apache/iceberg/pull/18580#discussion_r4337096009
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java:
##########
@@ -101,6 +105,9 @@
import org.junit.jupiter.api.io.TempDir;
public class TestParquet {
+ private static final Schema BOOLEAN_SCHEMA =
Review Comment:
nit: other tests use local schema. Shall we stick to that pattern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org