You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Brock Noland <br...@cloudera.com> on 2014/02/18 18:27:17 UTC
Review Request 18224: HIVE-5976 - Decouple input formats from STORED as
keywords
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18224/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-5976
https://issues.apache.org/jira/browse/HIVE-5976
Repository: hive-git
Description
-------
Decouples the STORED AS keywords from the language using the service loader construct.
Diffs
-----
hcatalog/core/src/main/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateTableHook.java 36a6e0c
hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/CreateTableHook.java ec24531
itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextSerDe.java PRE-CREATION
itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextStorageFormatDescriptor.java PRE-CREATION
itests/custom-serde/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/AbstractStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/IOConstants.java 4131066
ql/src/java/org/apache/hadoop/hive/ql/io/ORCFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/ParquetFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/RCFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/SequenceFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatFactory.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/TextFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java db9fa74
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1f539ef
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g aea9c1c
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 4d58f96
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g fd4d1a5
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 77388dd
ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java PRE-CREATION
ql/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/io/TestStorageFormatDescriptor.java PRE-CREATION
ql/src/test/queries/clientpositive/storage_format_descriptor.q PRE-CREATION
ql/src/test/results/clientpositive/storage_format_descriptor.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/18224/diff/
Testing
-------
Ran a bunch of random tests and it seems to work. Precommit testing will run the full suite.
Thanks,
Brock Noland
Re: Review Request 18224: HIVE-5976 - Decouple input formats from STORED as
keywords
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18224/
-----------------------------------------------------------
(Updated Feb. 18, 2014, 9:21 p.m.)
Review request for hive.
Changes
-------
Trims trailing whitespace.
Bugs: HIVE-5976
https://issues.apache.org/jira/browse/HIVE-5976
Repository: hive-git
Description
-------
Decouples the STORED AS keywords from the language using the service loader construct.
Diffs (updated)
-----
hcatalog/core/src/main/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateTableHook.java 36a6e0c
hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/CreateTableHook.java ec24531
itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextSerDe.java PRE-CREATION
itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextStorageFormatDescriptor.java PRE-CREATION
itests/custom-serde/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/AbstractStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/IOConstants.java 4131066
ql/src/java/org/apache/hadoop/hive/ql/io/ORCFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/ParquetFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/RCFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/SequenceFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatFactory.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/TextFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java db9fa74
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 2e27f34
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 86876fe
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 708581f
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g fd4d1a5
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 0af2536
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 77388dd
ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java PRE-CREATION
ql/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/io/TestStorageFormatDescriptor.java PRE-CREATION
ql/src/test/queries/clientpositive/storage_format_descriptor.q PRE-CREATION
ql/src/test/results/clientpositive/storage_format_descriptor.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/18224/diff/
Testing
-------
Ran a bunch of random tests and it seems to work. Precommit testing will run the full suite.
Thanks,
Brock Noland
Re: Review Request 18224: HIVE-5976 - Decouple input formats from STORED as
keywords
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18224/
-----------------------------------------------------------
(Updated Feb. 18, 2014, 9:18 p.m.)
Review request for hive.
Changes
-------
Addresses review items.
Bugs: HIVE-5976
https://issues.apache.org/jira/browse/HIVE-5976
Repository: hive-git
Description
-------
Decouples the STORED AS keywords from the language using the service loader construct.
Diffs (updated)
-----
hcatalog/core/src/main/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateTableHook.java 36a6e0c
hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/CreateTableHook.java ec24531
itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextSerDe.java PRE-CREATION
itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextStorageFormatDescriptor.java PRE-CREATION
itests/custom-serde/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/AbstractStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/IOConstants.java 4131066
ql/src/java/org/apache/hadoop/hive/ql/io/ORCFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/ParquetFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/RCFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/SequenceFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatFactory.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/TextFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java db9fa74
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 2e27f34
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 86876fe
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 708581f
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g fd4d1a5
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 0af2536
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 77388dd
ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java PRE-CREATION
ql/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/io/TestStorageFormatDescriptor.java PRE-CREATION
ql/src/test/queries/clientpositive/storage_format_descriptor.q PRE-CREATION
ql/src/test/results/clientpositive/storage_format_descriptor.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/18224/diff/
Testing
-------
Ran a bunch of random tests and it seems to work. Precommit testing will run the full suite.
Thanks,
Brock Noland
Re: Review Request 18224: HIVE-5976 - Decouple input formats from STORED as
keywords
Posted by Brock Noland <br...@cloudera.com>.
> On Feb. 18, 2014, 8:14 p.m., Mohammad Islam wrote:
> > I just reviewed the nitty stuffs. Overall, looks good!
> >
> > I hope someone else can review from a broader perspective.
Thank you! These are all good comments and will be fixed in the next version of the patch.
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18224/#review34762
-----------------------------------------------------------
On Feb. 18, 2014, 7:13 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18224/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2014, 7:13 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5976
> https://issues.apache.org/jira/browse/HIVE-5976
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Decouples the STORED AS keywords from the language using the service loader construct.
>
>
> Diffs
> -----
>
> hcatalog/core/src/main/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateTableHook.java 36a6e0c
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/CreateTableHook.java ec24531
> itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextSerDe.java PRE-CREATION
> itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextStorageFormatDescriptor.java PRE-CREATION
> itests/custom-serde/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/AbstractStorageFormatDescriptor.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/IOConstants.java 4131066
> ql/src/java/org/apache/hadoop/hive/ql/io/ORCFileStorageFormatDescriptor.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/ParquetFileStorageFormatDescriptor.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/RCFileStorageFormatDescriptor.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/SequenceFileStorageFormatDescriptor.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatDescriptor.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatFactory.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/TextFileStorageFormatDescriptor.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java db9fa74
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 2e27f34
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 86876fe
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 708581f
> ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g fd4d1a5
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 77388dd
> ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java PRE-CREATION
> ql/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/io/TestStorageFormatDescriptor.java PRE-CREATION
> ql/src/test/queries/clientpositive/storage_format_descriptor.q PRE-CREATION
> ql/src/test/results/clientpositive/storage_format_descriptor.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18224/diff/
>
>
> Testing
> -------
>
> Ran a bunch of random tests and it seems to work. Precommit testing will run the full suite.
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request 18224: HIVE-5976 - Decouple input formats from STORED as
keywords
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18224/#review34762
-----------------------------------------------------------
I just reviewed the nitty stuffs. Overall, looks good!
I hope someone else can review from a broader perspective.
itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextStorageFormatDescriptor.java
<https://reviews.apache.org/r/18224/#comment65012>
Although this StorageFormatDesc is for testing, make a constant in IOConstants class will be consistent with others.
ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatFactory.java
<https://reviews.apache.org/r/18224/#comment65011>
The same variable 'storageFormats' in class level and method level could create confusion. A different name in method level will make it safer for future.
ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java
<https://reviews.apache.org/r/18224/#comment65022>
wandering if we move this special processing logic into processStorageFormat(), it will be better organized.
ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java
<https://reviews.apache.org/r/18224/#comment65026>
Looks like this would be a very generic method useful for other places in future. Therefore, moving the method to some util class in common module would be beneficial for others.
- Mohammad Islam
On Feb. 18, 2014, 7:13 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18224/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2014, 7:13 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5976
> https://issues.apache.org/jira/browse/HIVE-5976
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Decouples the STORED AS keywords from the language using the service loader construct.
>
>
> Diffs
> -----
>
> hcatalog/core/src/main/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateTableHook.java 36a6e0c
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/CreateTableHook.java ec24531
> itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextSerDe.java PRE-CREATION
> itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextStorageFormatDescriptor.java PRE-CREATION
> itests/custom-serde/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/AbstractStorageFormatDescriptor.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/IOConstants.java 4131066
> ql/src/java/org/apache/hadoop/hive/ql/io/ORCFileStorageFormatDescriptor.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/ParquetFileStorageFormatDescriptor.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/RCFileStorageFormatDescriptor.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/SequenceFileStorageFormatDescriptor.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatDescriptor.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatFactory.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/TextFileStorageFormatDescriptor.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java db9fa74
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 2e27f34
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 86876fe
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 708581f
> ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g fd4d1a5
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 77388dd
> ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java PRE-CREATION
> ql/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/io/TestStorageFormatDescriptor.java PRE-CREATION
> ql/src/test/queries/clientpositive/storage_format_descriptor.q PRE-CREATION
> ql/src/test/results/clientpositive/storage_format_descriptor.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18224/diff/
>
>
> Testing
> -------
>
> Ran a bunch of random tests and it seems to work. Precommit testing will run the full suite.
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request 18224: HIVE-5976 - Decouple input formats from STORED as
keywords
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18224/
-----------------------------------------------------------
(Updated Feb. 18, 2014, 7:13 p.m.)
Review request for hive.
Changes
-------
Makes new member for BaseSemanticAnalyzer private.
Bugs: HIVE-5976
https://issues.apache.org/jira/browse/HIVE-5976
Repository: hive-git
Description
-------
Decouples the STORED AS keywords from the language using the service loader construct.
Diffs (updated)
-----
hcatalog/core/src/main/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateTableHook.java 36a6e0c
hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/CreateTableHook.java ec24531
itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextSerDe.java PRE-CREATION
itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextStorageFormatDescriptor.java PRE-CREATION
itests/custom-serde/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/AbstractStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/IOConstants.java 4131066
ql/src/java/org/apache/hadoop/hive/ql/io/ORCFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/ParquetFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/RCFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/SequenceFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatFactory.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/TextFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java db9fa74
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 2e27f34
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 86876fe
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 708581f
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g fd4d1a5
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 77388dd
ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java PRE-CREATION
ql/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/io/TestStorageFormatDescriptor.java PRE-CREATION
ql/src/test/queries/clientpositive/storage_format_descriptor.q PRE-CREATION
ql/src/test/results/clientpositive/storage_format_descriptor.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/18224/diff/
Testing
-------
Ran a bunch of random tests and it seems to work. Precommit testing will run the full suite.
Thanks,
Brock Noland