[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #371: omega-edit updates

[GitBox <gi...@apache.org>]

scholarsmate commented on code in PR #371:
URL: https://github.com/apache/daffodil-vscode/pull/371#discussion_r1048986690


##########
src/omega_edit/client.ts:
##########
@@ -72,8 +83,14 @@ export function activate(ctx: vscode.ExtensionContext) {
         subscribeToViewports: boolean = true
       ) => {
         if (!serverRunning && startServer) {
-          await getServer(ctx, omegaEditPackageVersion)
+          vscode.window.showInformationMessage('Starting omega-edit server!')
+          const [scriptName, scriptPath] = await omegaEditServer.setupServer(
+            rootPath,
+            omegaEditPackageVersion
+          )
+          serverTerminal = await runScript(scriptPath, scriptName)
           serverRunning = true
+          vscode.window.showInformationMessage('omega-edit server started!')

Review Comment:
   This code is duplicated in lines 62 - 69.  Consider a refactor?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org