You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by tr...@apache.org on 2014/11/21 11:53:34 UTC
incubator-flink git commit: Removed object reusage in
GenericArraySerializer's deserialize method.
Repository: incubator-flink
Updated Branches:
refs/heads/master 98ff76b0e -> a69d60ae3
Removed object reusage in GenericArraySerializer's deserialize method.
Project: http://git-wip-us.apache.org/repos/asf/incubator-flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-flink/commit/a69d60ae
Tree: http://git-wip-us.apache.org/repos/asf/incubator-flink/tree/a69d60ae
Diff: http://git-wip-us.apache.org/repos/asf/incubator-flink/diff/a69d60ae
Branch: refs/heads/master
Commit: a69d60ae3576476f39be6eabf3e6bbfaa2c712c2
Parents: 98ff76b
Author: Till Rohrmann <tr...@apache.org>
Authored: Fri Nov 21 11:52:09 2014 +0100
Committer: Till Rohrmann <tr...@apache.org>
Committed: Fri Nov 21 11:52:09 2014 +0100
----------------------------------------------------------------------
.../typeutils/base/GenericArraySerializer.java | 23 +-------------------
1 file changed, 1 insertion(+), 22 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/a69d60ae/flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/GenericArraySerializer.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/GenericArraySerializer.java b/flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/GenericArraySerializer.java
index 504b41b..9d616e2 100644
--- a/flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/GenericArraySerializer.java
+++ b/flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/GenericArraySerializer.java
@@ -123,28 +123,7 @@ public final class GenericArraySerializer<C> extends TypeSerializer<C[]> {
@Override
public C[] deserialize(C[] reuse, DataInputView source) throws IOException {
- int len = source.readInt();
-
- if (reuse.length != len) {
- reuse = create(len);
- }
-
- for (int i = 0; i < len; i++) {
- boolean isNonNull = source.readBoolean();
- if (isNonNull) {
- C ri = reuse[i];
- if (ri == null) {
- ri = componentSerializer.deserialize(source);
- } else {
- ri = componentSerializer.deserialize(ri, source);
- }
- reuse[i] = ri;
- } else {
- reuse[i] = null;
- }
- }
-
- return reuse;
+ return deserialize(source);
}
@Override