You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2018/03/22 16:28:30 UTC

Review Request 66218: Ensured that agent does not delete volume upon grow or shrink.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66218/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-4965
    https://issues.apache.org/jira/browse/MESOS-4965


Repository: mesos


Description
-------

Previously, `slave::syncCheckpointedResources` implementation will
delete a persistent volume using `Resources::contains` check, which
could cause a resized volume being deleted. The function was rewritten
to compare `set_difference` between old and new paths for all persistent
volumes and perform creation/deletion accordingly.


Diffs
-----

  src/slave/slave.cpp 915d4f1bbd642ca5d2587cfdd846262cb7e08788 


Diff: https://reviews.apache.org/r/66218/diff/1/


Testing
-------


Thanks,

Zhitao Li