You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/09 16:38:35 UTC

[GitHub] [incubator-superset] ktmud commented on pull request #10268: feat: show formatted date instead of epoch on results

ktmud commented on pull request #10268:
URL: https://github.com/apache/incubator-superset/pull/10268#issuecomment-656231422


   Does this table use the new chart data API? What about other datetime columns? If I'm understanding the code right, all datetime columns will return epochs? I think it would be best if the new API response payload will [include data type info](https://github.com/apache/incubator-superset/pull/10270/files#diff-feac5e6e760eb756a4942c95c192b8dcR164), what do you think?
   
   And how about replacing this table with the [TableChart](https://github.com/apache-superset/superset-ui/blob/a96f40e522c3be291d24dbfb33a189c4f39a6b9d/plugins/plugin-chart-table/src/TableChart.tsx#L1)? There seems to be some overlapping work here.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org