You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/12 06:39:37 UTC
[GitHub] [flink] xintongsong commented on a change in pull request #13063: [FLINK-15448] Add Node information to the ResourceId of TaskExecutor …
xintongsong commented on a change in pull request #13063:
URL: https://github.com/apache/flink/pull/13063#discussion_r469036537
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -91,9 +91,12 @@
private static final Priority RM_REQUEST_PRIORITY = Priority.newInstance(1);
- /** YARN container map. Package private for unit test purposes. */
+ /** YARN container map. */
private final ConcurrentMap<ResourceID, YarnWorkerNode> workerNodeMap;
+ /** Mapping the Container id to ResourceID. */
+ private final ConcurrentMap<ContainerId, ResourceID> containerIdToResourceIdMap;
Review comment:
Why do we need to maintain this map? It seems to me that `ResourceId` can be deterministically generated from `ContainerId`.
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -91,9 +91,12 @@
private static final Priority RM_REQUEST_PRIORITY = Priority.newInstance(1);
- /** YARN container map. Package private for unit test purposes. */
+ /** YARN container map. */
Review comment:
Unrelated change. Let's keep it in a separate hotfix commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org