You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/10/13 11:34:37 UTC

[GitHub] [rocketmq] AVP42 commented on a change in pull request #2343: [ISSUE# 2330] Store the properties of MessageBatch

AVP42 commented on a change in pull request #2343:
URL: https://github.com/apache/rocketmq/pull/2343#discussion_r503877637



##########
File path: broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
##########
@@ -577,6 +577,7 @@ private RemotingCommand handlePutMessageResult(PutMessageResult putMessageResult
         messageExtBatch.setFlag(requestHeader.getFlag());
         MessageAccessor.setProperties(messageExtBatch, MessageDecoder.string2messageProperties(requestHeader.getProperties()));
         messageExtBatch.setBody(request.getBody());
+        messageExtBatch.setPropertiesString(requestHeader.getProperties());

Review comment:
       Yes, I agree with you. My Intention was to avoid another transformation since there was already a transformed string.  I thought that MessageExtBrokerInner is out of the same consideration. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org