[GitHub] [incubator-kvrocks] git-hulk commented on issue #1007: Support config 'backup-dir' can be changed

[GitBox <gi...@apache.org>]

git-hulk commented on issue #1007:
URL: https://github.com/apache/incubator-kvrocks/issues/1007#issuecomment-1283475172

   > I'd like to submit a patch for this issue, but I have some problems @git-hulk What's the expective behavior for `config set backup-dir ...` when:
   > 
   > 1. Previous database is backing up?
   > 2. Have previous backup?
   > 
   > Changing the `backup_dir` is easy, but it may tears using it. And previous `backup_dir` may having backup data. Should we purge old backup or rename dir when the dir is changed?
   
   @mapleFU Thank you! 
   
   1. Previous database is backing up?
   
   **The change can only affect the new coming backup request, the on going backup can be still i the old backup dir. **
   
   3. Have previous backup?
   
   **Yes, we can keep at most one backup**
   
   
   4. And previous `backup_dir` may having backup data. Should we purge old backup or rename dir when the dir is changed?
   
   **I think we can left the old backup data as it be and users can delete it manually if they want.**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org