[GitHub] [incubator-seatunnel] yx91490 commented on a change in pull request #742: [REFACTOR]: change spark batch api code to java

[GitBox <gi...@apache.org>]

yx91490 commented on a change in pull request #742:
URL: https://github.com/apache/incubator-seatunnel/pull/742#discussion_r783134768



##########
File path: seatunnel-spark-api/src/main/scala/io/github/interestinglab/waterdrop/spark/batch/BaseSparkBatchSource.java
##########
@@ -14,11 +14,12 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package io.github.interestinglab.waterdrop.spark.batch
 
-import io.github.interestinglab.waterdrop.spark.BaseSparkSource
-import org.apache.spark.sql.{Dataset, Row}
+package io.github.interestinglab.waterdrop.spark.batch;
 
-trait SparkBatchSource extends BaseSparkSource[Dataset[Row]]{
+import io.github.interestinglab.waterdrop.spark.BaseSparkSource;
+import org.apache.spark.sql.Dataset;
+import org.apache.spark.sql.Row;
 
+public abstract class BaseSparkBatchSource extends BaseSparkSource<Dataset<Row>> {

Review comment:
       have you noticed this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org