You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vincbeck (via GitHub)" <gi...@apache.org> on 2024/02/22 16:26:55 UTC
[PR] Implement `get_permitted_menu_items` in AWS auth manager [airflow]
vincbeck opened a new pull request, #37627:
URL: https://github.com/apache/airflow/pull/37627
Implement `get_permitted_menu_items` in AWS auth manager
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement `get_permitted_menu_items` in AWS auth manager [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #37627:
URL: https://github.com/apache/airflow/pull/37627#discussion_r1500073659
##########
airflow/providers/amazon/aws/auth_manager/avp/facade.py:
##########
@@ -125,62 +130,97 @@ def is_authorized(
return resp["decision"] == "ALLOW"
- def batch_is_authorized(
+ def get_batch_is_authorized_results(
self,
*,
requests: Sequence[IsAuthorizedRequest],
- user: AwsAuthManagerUser | None,
- ) -> bool:
+ user: AwsAuthManagerUser,
+ ):
Review Comment:
missing return type annotation
##########
airflow/providers/amazon/aws/auth_manager/avp/facade.py:
##########
@@ -205,3 +245,25 @@ def _build_context(context: dict | None) -> dict | None:
return {
"contextMap": context,
}
+
+ def _build_is_authorized_request_payload(self, request: IsAuthorizedRequest, user: AwsAuthManagerUser):
+ """
+ Build payload of individual authorization request send through ``batch_is_authorized`` API.
Review Comment:
This is what I think this is trying to say, is that right?
```suggestion
Build a payload of an individual authorization request that could be sent through the ``batch_is_authorized`` API.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement `get_permitted_menu_items` in AWS auth manager [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #37627:
URL: https://github.com/apache/airflow/pull/37627#discussion_r1500832207
##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -367,7 +367,7 @@ def _is_permitted_dag_id(method: ResourceMethod, methods: Container[ResourceMeth
if _is_permitted_dag_id("GET", methods, dag_id) or _is_permitted_dag_id("PUT", methods, dag_id)
}
- def get_permitted_menu_items(self, menu_items: list[MenuItem]) -> list[MenuItem]:
+ def filter_permitted_menu_items(self, menu_items: list[MenuItem]) -> list[MenuItem]:
Review Comment:
You're right. I dont think anybody use that interface yet so I thought it was the good time to do it. I guess your statement "Or we do not care too much at this stage?" is correct :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement `get_permitted_menu_items` in AWS auth manager [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #37627:
URL: https://github.com/apache/airflow/pull/37627#discussion_r1500830169
##########
airflow/providers/amazon/aws/auth_manager/avp/facade.py:
##########
@@ -205,3 +245,25 @@ def _build_context(context: dict | None) -> dict | None:
return {
"contextMap": context,
}
+
+ def _build_is_authorized_request_payload(self, request: IsAuthorizedRequest, user: AwsAuthManagerUser):
+ """
+ Build payload of individual authorization request send through ``batch_is_authorized`` API.
Review Comment:
Correct, thanks :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement `filter_permitted_menu_items` in AWS auth manager [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #37627:
URL: https://github.com/apache/airflow/pull/37627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement `get_permitted_menu_items` in AWS auth manager [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #37627:
URL: https://github.com/apache/airflow/pull/37627#discussion_r1500548445
##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -367,7 +367,7 @@ def _is_permitted_dag_id(method: ResourceMethod, methods: Container[ResourceMeth
if _is_permitted_dag_id("GET", methods, dag_id) or _is_permitted_dag_id("PUT", methods, dag_id)
}
- def get_permitted_menu_items(self, menu_items: list[MenuItem]) -> list[MenuItem]:
+ def filter_permitted_menu_items(self, menu_items: list[MenuItem]) -> list[MenuItem]:
Review Comment:
Isn't that backwards-incompatible? Or we do not care too much at this stage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement `filter_permitted_menu_items` in AWS auth manager [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #37627:
URL: https://github.com/apache/airflow/pull/37627#discussion_r1501031546
##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -367,7 +367,7 @@ def _is_permitted_dag_id(method: ResourceMethod, methods: Container[ResourceMeth
if _is_permitted_dag_id("GET", methods, dag_id) or _is_permitted_dag_id("PUT", methods, dag_id)
}
- def get_permitted_menu_items(self, menu_items: list[MenuItem]) -> list[MenuItem]:
+ def filter_permitted_menu_items(self, menu_items: list[MenuItem]) -> list[MenuItem]:
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement `filter_permitted_menu_items` in AWS auth manager [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #37627:
URL: https://github.com/apache/airflow/pull/37627#discussion_r1500904424
##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -367,7 +367,7 @@ def _is_permitted_dag_id(method: ResourceMethod, methods: Container[ResourceMeth
if _is_permitted_dag_id("GET", methods, dag_id) or _is_permitted_dag_id("PUT", methods, dag_id)
}
- def get_permitted_menu_items(self, menu_items: list[MenuItem]) -> list[MenuItem]:
+ def filter_permitted_menu_items(self, menu_items: list[MenuItem]) -> list[MenuItem]:
Review Comment:
Fine for me. I **think** we marked the AuthManager interface as experimental as well? In which case it's perfectly fine. Though I think that maybe a newsfragment (not significant - one liner) would be appropriate to add in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement `filter_permitted_menu_items` in AWS auth manager [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #37627:
URL: https://github.com/apache/airflow/pull/37627#discussion_r1500914351
##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -367,7 +367,7 @@ def _is_permitted_dag_id(method: ResourceMethod, methods: Container[ResourceMeth
if _is_permitted_dag_id("GET", methods, dag_id) or _is_permitted_dag_id("PUT", methods, dag_id)
}
- def get_permitted_menu_items(self, menu_items: list[MenuItem]) -> list[MenuItem]:
+ def filter_permitted_menu_items(self, menu_items: list[MenuItem]) -> list[MenuItem]:
Review Comment:
I can do that :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org