You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by semancik <gi...@git.apache.org> on 2017/07/26 15:34:44 UTC
[GitHub] cxf pull request #297: [CXF-7455] Tolerate missing message part
GitHub user semancik opened a pull request:
https://github.com/apache/cxf/pull/297
[CXF-7455] Tolerate missing message part
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Evolveum/cxf CXF-7455
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/297.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #297
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #297: [CXF-7455] Tolerate missing message part
Posted by deki <gi...@git.apache.org>.
Github user deki commented on the issue:
https://github.com/apache/cxf/pull/297
Thanks for your pull request. Can you provide a unit/ integration test for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #297: [CXF-7455] Tolerate missing message part
Posted by deki <gi...@git.apache.org>.
Github user deki commented on the issue:
https://github.com/apache/cxf/pull/297
No need to cancel the PR, if we could make the code more robust, we should do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #297: [CXF-7455] Tolerate missing message part
Posted by deki <gi...@git.apache.org>.
Github user deki commented on the issue:
https://github.com/apache/cxf/pull/297
Ok could you please attach the SOAP message to the JIRA issue?
Regarding test you can take a look at the existing org.apache.cxf.jaxws.holder.HolderTest.
Btw. PRs should usually point to master, we will take care of merging them to the other branches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #297: [CXF-7455] Tolerate missing message part
Posted by semancik <gi...@git.apache.org>.
Github user semancik commented on the issue:
https://github.com/apache/cxf/pull/297
I was looking around how to construct a test for this. But I'm really puzzled. There seems to be very little documentation about writing tests. And I could not find any test that would be similar to what I'm trying to do.
I have SOAP message that is causing the exception. It is a SOAP response from the server. How do I create a simple test that just attempts to process the message, runs the interceptors and checks the processed message?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #297: [CXF-7455] Tolerate missing message part
Posted by semancik <gi...@git.apache.org>.
Github user semancik commented on the issue:
https://github.com/apache/cxf/pull/297
Looks like this has been already worked around in the winrm4j project. I was not aware of that. So I might actually cancel the pull request later on. Please, bear with me, I need some time to explore. However, I would say that it is rather sad that it is easier to work around the problem than to deal with all this checkstyle pain, unit tests and so on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---