You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2020/02/17 09:40:42 UTC
[GitHub] [unomi] sergehuber opened a new pull request #129: UNOMI-270 &
UNOMI-175 Data model and plugin documentation
sergehuber opened a new pull request #129: UNOMI-270 & UNOMI-175 Data model and plugin documentation
URL: https://github.com/apache/unomi/pull/129
This PR contains the following documentation updates:
- New data model documentation that replaces the concepts part.
- Moved it to the reference section so that we keep the practical and tutorial material first.
- Renamed actions to action types to separate the notions
- Merged the "extensions" and "plugins" documents into a single "writing plugins" one.
- Fixed all internal references to work with PDF format.
- Other minor changes & typo fixes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [unomi] sergehuber merged pull request #129: UNOMI-270 & UNOMI-175
Data model and plugin documentation
Posted by GitBox <gi...@apache.org>.
sergehuber merged pull request #129: UNOMI-270 & UNOMI-175 Data model and plugin documentation
URL: https://github.com/apache/unomi/pull/129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [unomi] Taybou commented on a change in pull request #129:
UNOMI-270 & UNOMI-175 Data model and plugin documentation
Posted by GitBox <gi...@apache.org>.
Taybou commented on a change in pull request #129: UNOMI-270 & UNOMI-175 Data model and plugin documentation
URL: https://github.com/apache/unomi/pull/129#discussion_r380076861
##########
File path: manual/src/main/asciidoc/builtin-condition-types.adoc
##########
@@ -85,19 +85,19 @@ From https://github.com/apache/unomi/blob/master/plugins/baseplugin/src/main/res
...
----
-As you can see two Java classes are used to build a single condition. You don't need to understand all these details in
-order to use conditions, but this might be interesting to know if you're interested in building your own condition
-implementations. For more details on building your own custom plugins/extensions, please refer to the corresponding
+As you can see two Java classes are used to build a single condition type. You don't need to understand all these details in
+order to use condition types, but this might be interesting to know if you're interested in building your own condition
+type implementations. For more details on building your own custom plugins/extensions, please refer to the corresponding
sections.
-==== Existing condition descriptors
+==== Existing condition type descriptors
-Here is a non-exhaustive list of conditions built into Apache Unomi. Feel free to browse the source code if you want to
+Here is a non-exhaustive list of condition types built into Apache Unomi. Feel free to browse the source code if you want to
discover more. But the list below should get you started with the most useful conditions:
- https://github.com/apache/unomi/tree/master/plugins/baseplugin/src/main/resources/META-INF/cxs/conditions
-Of course it is also possible to build your own custom conditions by developing custom Unomi plugins/extensions.
+Of course it is also possible to build your own custom condition types by developing custom Unomi plugins/extensions.
-You will also note that some conditions can re-use a `parentCondition`. This is a way to inherit from another condition
+You will also note that some condition typess can re-use a `parentCondition`. This is a way to inherit from another condition
Review comment:
```suggestion
You will also note that some condition types can re-use a `parentCondition`. This is a way to inherit from another condition
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [unomi] Taybou commented on a change in pull request #129:
UNOMI-270 & UNOMI-175 Data model and plugin documentation
Posted by GitBox <gi...@apache.org>.
Taybou commented on a change in pull request #129: UNOMI-270 & UNOMI-175 Data model and plugin documentation
URL: https://github.com/apache/unomi/pull/129#discussion_r380079715
##########
File path: manual/src/main/asciidoc/context-request-flow.adoc
##########
@@ -0,0 +1,18 @@
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+=== Context Request flow
Review comment:
```suggestion
=== Context Request Flow
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services