You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/10/01 05:48:24 UTC
[GitHub] [skywalking] xbkaishui opened a new pull request #5615: Support group concept in the alarm core
xbkaishui opened a new pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
Support group concept in the alarm core. #5475
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `5.78%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 45.72% -5.79%
+ Complexity 3305 3025 -280
============================================
Files 883 903 +20
Lines 21854 22151 +297
Branches 2081 2110 +29
============================================
- Hits 11257 10129 -1128
- Misses 9687 11157 +1470
+ Partials 910 865 -45
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.04% <42.85%> (-2.86%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [130 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 169 -731
Lines 22172 4036 -18136
Branches 2123 459 -1664
============================================
- Hits 9354 0 -9354
+ Misses 12148 4036 -8112
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [726 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...dca9216](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `3.47%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 48.03% -3.48%
+ Complexity 3305 3135 -170
============================================
Files 883 902 +19
Lines 21854 22161 +307
Branches 2081 2106 +25
============================================
- Hits 11257 10645 -612
- Misses 9687 10640 +953
+ Partials 910 876 -34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-1.07%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [101 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `6.55%`.
> The diff coverage is `35.10%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 35.63% -6.56%
+ Complexity 2648 2318 -330
============================================
Files 900 904 +4
Lines 22172 22209 +37
Branches 2123 2126 +3
============================================
- Hits 9354 7914 -1440
- Misses 12148 13707 +1559
+ Partials 670 588 -82
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-0.61%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [110 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...dca9216](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 176 -724
Lines 22172 4124 -18048
Branches 2123 475 -1648
============================================
- Hits 9354 0 -9354
+ Misses 12148 4124 -8024
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [718 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4f3264c](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 177 -706
Lines 21854 4113 -17741
Branches 2081 471 -1610
============================================
- Hits 11257 0 -11257
+ Misses 9687 4113 -5574
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [859 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `2.30%`.
> The diff coverage is `36.06%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 44.49% +2.30%
- Complexity 2648 2989 +341
============================================
Files 900 904 +4
Lines 22172 22225 +53
Branches 2123 2125 +2
============================================
+ Hits 9354 9889 +535
+ Misses 12148 11495 -653
- Partials 670 841 +171
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `31.25% <31.25%> (ø)` | `2.00 <2.00> (?)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-0.61%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [255 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ec375e2](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 178 -722
Lines 22172 4213 -17959
Branches 2123 486 -1637
============================================
- Hits 9354 0 -9354
+ Misses 12148 4213 -7935
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [716 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ec375e2](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `12.34%`.
> The diff coverage is `35.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 42.18% 29.84% -12.35%
+ Complexity 2648 1969 -679
=============================================
Files 900 887 -13
Lines 22172 21734 -438
Branches 2123 2078 -45
=============================================
- Hits 9354 6486 -2868
- Misses 12148 14757 +2609
+ Partials 670 491 -179
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `71.87% <28.57%> (-13.84%)` | `9.00 <2.00> (-1.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `40.80% <42.85%> (-4.20%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [170 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...caa13c6](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `13.00%`.
> The diff coverage is `35.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 42.18% 29.18% -13.01%
+ Complexity 2648 1905 -743
=============================================
Files 900 887 -13
Lines 22172 21679 -493
Branches 2123 2075 -48
=============================================
- Hits 9354 6327 -3027
- Misses 12148 14872 +2724
+ Partials 670 480 -190
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/CompositeRuleEvaluate.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `71.87% <28.57%> (-13.84%)` | `9.00 <2.00> (-1.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.49% <42.85%> (-1.51%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [181 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 181 -702
Lines 21854 4195 -17659
Branches 2081 470 -1611
============================================
- Hits 11257 0 -11257
+ Misses 9687 4195 -5492
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [865 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...ba927b1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `0.16%`.
> The diff coverage is `36.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 42.02% -0.17%
- Complexity 2648 2862 +214
============================================
Files 900 902 +2
Lines 22172 22126 -46
Branches 2123 2118 -5
============================================
- Hits 9354 9299 -55
+ Misses 12148 12037 -111
- Partials 670 790 +120
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-0.16%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [287 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4f3264c](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `10.13%`.
> The diff coverage is `35.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 42.18% 32.05% -10.14%
+ Complexity 2648 2100 -548
=============================================
Files 900 887 -13
Lines 22172 21757 -415
Branches 2123 2083 -40
=============================================
- Hits 9354 6974 -2380
- Misses 12148 14286 +2138
+ Partials 670 497 -173
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.94% <42.85%> (-1.06%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [121 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ebeb288](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 177 -723
Lines 22172 4209 -17963
Branches 2123 486 -1637
============================================
- Hits 9354 0 -9354
+ Misses 12148 4209 -7939
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [718 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ebeb288](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/bc64c6a12770031478d29e2f19004796584374c9?el=desc) will **decrease** coverage by `0.73%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 52.13% 51.39% -0.74%
+ Complexity 3361 3310 -51
============================================
Files 901 893 -8
Lines 22195 22063 -132
Branches 2124 2096 -28
============================================
- Hits 11572 11340 -232
- Misses 9695 9804 +109
+ Partials 928 919 -9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `47.53% <42.85%> (+0.26%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [59 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [bc64c6a...b5adde1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 172 -711
Lines 21854 4066 -17788
Branches 2081 465 -1616
============================================
- Hits 11257 0 -11257
+ Misses 9687 4066 -5621
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [854 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r498319488
##########
File path: oap-server/server-alarm-plugin/src/test/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluatorTest.java
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.ExpressionContext;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+
+public class CompositeRuleEvaluatorTest {
Review comment:
- Changed onlyAsGroupCondition to onlyAsCondition.
- Update document
Plese help to check again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `3.41%`.
> The diff coverage is `36.06%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 45.60% +3.41%
- Complexity 2648 3037 +389
============================================
Files 900 904 +4
Lines 22172 22239 +67
Branches 2123 2126 +3
============================================
+ Hits 9354 10141 +787
+ Misses 12148 11240 -908
- Partials 670 858 +188
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `31.25% <31.25%> (ø)` | `2.00 <2.00> (?)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-0.61%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [245 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ec375e2](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/772f1d2e82aa97e47d0e04f81dc822f35e3e0d02?el=desc) will **decrease** coverage by `0.62%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.80% 51.18% -0.63%
+ Complexity 3363 3307 -56
============================================
Files 1606 886 -720
Lines 34102 21955 -12147
Branches 3710 2104 -1606
============================================
- Hits 17666 11237 -6429
+ Misses 15581 9800 -5781
- Partials 855 918 +63
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-66.67%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.73% <42.85%> (-11.66%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-19.39%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (-28.44%)` | `7.00 <1.00> (+1.00)` | :arrow_down: |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1111 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [772f1d2...4553cb1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `7.28%`.
> The diff coverage is `35.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 49.47% +7.28%
- Complexity 2648 3267 +619
============================================
Files 900 903 +3
Lines 22172 22276 +104
Branches 2123 2117 -6
============================================
+ Hits 9354 11021 +1667
+ Misses 12148 10365 -1783
- Partials 670 890 +220
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/CompositeRuleEvaluate.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-0.16%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [169 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 164 -736
Lines 22172 3957 -18215
Branches 2123 461 -1662
============================================
- Hits 9354 0 -9354
+ Misses 12148 3957 -8191
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [730 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...caa13c6](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 167 -716
Lines 21854 4016 -17838
Branches 2081 463 -1618
============================================
- Hits 11257 0 -11257
+ Misses 9687 4016 -5671
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [849 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 164 -719
Lines 21854 3941 -17913
Branches 2081 459 -1622
============================================
- Hits 11257 0 -11257
+ Misses 9687 3941 -5746
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [847 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 175 -725
Lines 22172 4129 -18043
Branches 2123 469 -1654
============================================
- Hits 9354 0 -9354
+ Misses 12148 4129 -8019
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [719 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ec375e2](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/772f1d2e82aa97e47d0e04f81dc822f35e3e0d02?el=desc) will **decrease** coverage by `51.80%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.80% 0.00% -51.81%
============================================
Files 1606 164 -1442
Lines 34102 3941 -30161
Branches 3710 459 -3251
============================================
- Hits 17666 0 -17666
+ Misses 15581 3941 -11640
+ Partials 855 0 -855
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1573 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [772f1d2...4553cb1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `2.78%`.
> The diff coverage is `36.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 44.97% +2.78%
- Complexity 2648 3006 +358
============================================
Files 900 902 +2
Lines 22172 22140 -32
Branches 2123 2119 -4
============================================
+ Hits 9354 9957 +603
+ Misses 12148 11348 -800
- Partials 670 835 +165
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-0.16%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [250 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...f70a4ed](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `9.10%`.
> The diff coverage is `36.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 33.08% -9.11%
+ Complexity 2648 2182 -466
============================================
Files 900 899 -1
Lines 22172 22043 -129
Branches 2123 2113 -10
============================================
- Hits 9354 7292 -2062
- Misses 12148 14201 +2053
+ Partials 670 550 -120
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-0.16%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [146 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4f3264c](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `2.68%`.
> The diff coverage is `36.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 44.87% +2.68%
- Complexity 2648 2998 +350
============================================
Files 900 902 +2
Lines 22172 22140 -32
Branches 2123 2119 -4
============================================
+ Hits 9354 9936 +582
+ Misses 12148 11370 -778
- Partials 670 834 +164
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-0.16%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [254 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4f3264c](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r498087934
##########
File path: oap-server/server-alarm-plugin/src/test/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluatorTest.java
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.ExpressionContext;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+
+public class CompositeRuleEvaluatorTest {
Review comment:
The test cases should cover the exception cases. Such as, what happens for `a_rule + b_rule`, `not_exist_rule && b_rule`.
##########
File path: oap-server/pom.xml
##########
@@ -531,6 +532,11 @@
<artifactId>groovy</artifactId>
<version>${groovy.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.mvel</groupId>
+ <artifactId>mvel2</artifactId>
+ <version>${mvel.version}</version>
Review comment:
As you add a new dependency, you need to update the LICENSE. You need to add the repo with license name(Apache 2.0) here.
https://github.com/apache/skywalking/blob/master/dist-material/release-docs/LICENSE#L339
Also, you need to check whether it causes more dependencies added. If so, others' licenses should be added.
___
Also, you need to fix the check from the script in this folder, https://github.com/apache/skywalking/tree/master/tools/dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/bc64c6a12770031478d29e2f19004796584374c9?el=desc) will **decrease** coverage by `18.44%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 52.13% 33.68% -18.45%
+ Complexity 3361 2158 -1203
=============================================
Files 901 876 -25
Lines 22195 21515 -680
Branches 2124 2046 -78
=============================================
- Hits 11572 7248 -4324
- Misses 9695 13709 +4014
+ Partials 928 558 -370
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.94% <42.85%> (-3.33%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [291 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [bc64c6a...b5adde1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 170 -730
Lines 22172 4108 -18064
Branches 2123 476 -1647
============================================
- Hits 9354 0 -9354
+ Misses 12148 4108 -8040
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [725 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...dca9216](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499146088
##########
File path: oap-server/server-alarm-plugin/src/test/java/org/apache/skywalking/oap/server/core/alarm/provider/expression/ExpressionTest.java
##########
@@ -70,7 +70,7 @@ public void testEvalWithEmptyContext() {
@Test
public void testCompile() {
- String expr = " a && b ";
+ String expr = " a && * b ";
Review comment:
Sorry, fixed the test case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `8.88%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 42.62% -8.89%
+ Complexity 3305 2659 -646
============================================
Files 883 896 +13
Lines 21854 22128 +274
Branches 2081 2106 +25
============================================
- Hits 11257 9432 -1825
- Misses 9687 12007 +2320
+ Partials 910 689 -221
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (-0.62%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [180 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499152618
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/expression/Expression.java
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.expression;
+
+import lombok.extern.slf4j.Slf4j;
+import org.mvel2.MVEL;
+import org.mvel2.ParserContext;
+
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Expression support eval java basic expressions, just like groovy script
+ * The internal detail is it first compile the expression to a pareTree then execute the parseTree with data
+ * It caches the compiled expression for sake of performance
+ */
+@Slf4j
+public class Expression {
+ private Map<String, Object> expressionCache;
+ private ExpressionContext context;
+
+ public Expression(ExpressionContext context) {
+ this.context = context;
+ this.expressionCache = new ConcurrentHashMap<>();
+ }
+
+ /**
+ * Eval the given expression using empty data context
+ */
+ public Object eval(String expression) {
+ return eval(expression, null);
+ }
+
+ /**
+ * Eval the given expression with data context
+ */
+ public Object eval(String expression, Map<String, Object> vars) {
+ try {
+ Object obj = compile(expression, context);
+ return MVEL.executeExpression(obj, vars);
+ } catch (Throwable e) {
+ log.error("eval expression {} error", expression, e);
+ return null;
+ }
+ }
+
+ /**
+ * Compile the given expression to a parseTree
+ */
+ public Object compile(String expression, ExpressionContext pctx) {
+ Object o = expressionCache.get(expression);
+ if (o == null) {
+ o = MVEL.compileExpression(expression, pctx.getContext());
+ expressionCache.put(expression, o);
+ }
+ return o;
Review comment:
OK, let's keep the `ConcurrentHashMap`, as it doesn't cost much. From my understanding, there is no concurrency or race condition.
Anyway, no big issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 166 -717
Lines 21854 3997 -17857
Branches 2081 463 -1618
============================================
- Hits 11257 0 -11257
+ Misses 9687 3997 -5690
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [849 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-703003941
Thanks for you guys to help reviewing. all changed with comments. please check again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499082901
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java
##########
@@ -49,93 +50,136 @@ public Rules readRules() {
Rules rules = new Rules();
if (Objects.nonNull(yamlData)) {
- Map rulesData = (Map) yamlData.get("rules");
- if (rulesData != null) {
- rules.setRules(new ArrayList<>());
- rulesData.forEach((k, v) -> {
- if (((String) k).endsWith("_rule")) {
- AlarmRule alarmRule = new AlarmRule();
- alarmRule.setAlarmRuleName((String) k);
- Map settings = (Map) v;
- Object metricsName = settings.get("metrics-name");
- if (metricsName == null) {
- throw new IllegalArgumentException("metrics-name can't be null");
- }
-
- alarmRule.setMetricsName((String) metricsName);
- alarmRule.setIncludeNames((ArrayList) settings.getOrDefault("include-names", new ArrayList(0)));
- alarmRule.setExcludeNames((ArrayList) settings.getOrDefault("exclude-names", new ArrayList(0)));
- alarmRule.setIncludeNamesRegex((String) settings.getOrDefault("include-names-regex", ""));
- alarmRule.setExcludeNamesRegex((String) settings.getOrDefault("exclude-names-regex", ""));
- alarmRule.setIncludeLabels(
- (ArrayList) settings.getOrDefault("include-labels", new ArrayList(0)));
- alarmRule.setExcludeLabels(
- (ArrayList) settings.getOrDefault("exclude-labels", new ArrayList(0)));
- alarmRule.setIncludeLabelsRegex((String) settings.getOrDefault("include-labels-regex", ""));
- alarmRule.setExcludeLabelsRegex((String) settings.getOrDefault("exclude-labels-regex", ""));
- alarmRule.setThreshold(settings.get("threshold").toString());
- alarmRule.setOp((String) settings.get("op"));
- alarmRule.setPeriod((Integer) settings.getOrDefault("period", 1));
- alarmRule.setCount((Integer) settings.getOrDefault("count", 1));
- // How many times of checks, the alarm keeps silence after alarm triggered, default as same as period.
- alarmRule.setSilencePeriod((Integer) settings.getOrDefault("silence-period", alarmRule.getPeriod()));
- alarmRule.setMessage(
- (String) settings.getOrDefault("message", "Alarm caused by Rule " + alarmRule
- .getAlarmRuleName()));
+ readRulesConfig(rules);
+ readCompositeRuleConfig(rules);
+ readWebHookConfig(rules);
+ readGrpcConfig(rules);
+ readSlackConfig(rules);
+ readWechatConfig(rules);
+ }
+ return rules;
+ }
- rules.getRules().add(alarmRule);
- }
- });
- }
- List webhooks = (List) yamlData.get("webhooks");
- if (webhooks != null) {
- rules.setWebhooks(new ArrayList<>());
- webhooks.forEach(url -> {
- rules.getWebhooks().add((String) url);
- });
+ private void readCompositeRuleConfig(Rules rules) {
+ Map compositeRulesData = (Map) yamlData.get("composite-rules");
+ if (compositeRulesData == null) {
+ return;
+ }
+ compositeRulesData.forEach((k, v) -> {
+ String ruleName = (String) k;
+ if (ruleName.endsWith("_rule")) {
+ Map settings = (Map) v;
+ CompositeAlarmRule compositeAlarmRule = new CompositeAlarmRule();
+ compositeAlarmRule.setAlarmRuleName(ruleName);
+ String expression = (String) settings.get("expression");
+ if (expression == null) {
+ throw new IllegalArgumentException("expression can't be null");
Review comment:
This will throws a exception, and current new rules will not effect, the system will use old rules config,
do you mean I should not throws Exception ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `16.31%`.
> The diff coverage is `35.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 42.18% 25.87% -16.32%
+ Complexity 2648 1746 -902
=============================================
Files 900 887 -13
Lines 22172 21573 -599
Branches 2123 2034 -89
=============================================
- Hits 9354 5582 -3772
- Misses 12148 15602 +3454
+ Partials 670 389 -281
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `71.87% <28.57%> (-13.84%)` | `9.00 <2.00> (-1.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `38.56% <42.85%> (-6.44%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [215 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ebeb288](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/772f1d2e82aa97e47d0e04f81dc822f35e3e0d02?el=desc) will **decrease** coverage by `22.08%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.80% 29.72% -22.09%
+ Complexity 3363 1911 -1452
=============================================
Files 1606 868 -738
Lines 34102 21349 -12753
Branches 3710 2049 -1661
=============================================
- Hits 17666 6345 -11321
+ Misses 15581 14528 -1053
+ Partials 855 476 -379
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-66.67%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `39.91% <42.85%> (-17.49%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-19.39%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (-28.44%)` | `7.00 <1.00> (+1.00)` | :arrow_down: |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1236 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [772f1d2...4553cb1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `8.81%`.
> The diff coverage is `35.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 50.99% +8.81%
- Complexity 2648 3328 +680
============================================
Files 900 904 +4
Lines 22172 22310 +138
Branches 2123 2133 +10
============================================
+ Hits 9354 11378 +2024
+ Misses 12148 10009 -2139
- Partials 670 923 +253
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (+0.29%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [167 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...caa13c6](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `12.78%`.
> The diff coverage is `35.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 42.18% 29.40% -12.79%
+ Complexity 2648 1915 -733
=============================================
Files 900 880 -20
Lines 22172 21608 -564
Branches 2123 2058 -65
=============================================
- Hits 9354 6353 -3001
- Misses 12148 14776 +2628
+ Partials 670 479 -191
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/CompositeRuleEvaluate.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `38.56% <42.85%> (-6.44%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [186 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499090557
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -41,10 +43,16 @@ Such as in **percentile**, `value1` is threshold of P50, and `-, -, value3, valu
backend deployment env time.
- **Count**. In the period window, if the number of **value**s over threshold(by OP), reaches count, alarm
should send.
+- **Only as condition**. Specify if the rule can send notfiy or just as an conditon of composite rule
- **Silence period**. After alarm is triggered in Time-N, then keep silence in the **TN -> TN + period**.
By default, it is as same as **Period**, which means in a period, same alarm(same ID in same
metrics name) will be trigger once.
+### Composite rules
+Composite rule is constituted by following keys
+- **Rule name**. Unique name, show in alarm message. Must end with `_rule`.
+- **Expression**. Specify how to compose rules, support and/or expression
Review comment:
added test case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `1.92%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 49.58% -1.93%
+ Complexity 3305 3192 -113
============================================
Files 883 902 +19
Lines 21854 22171 +317
Branches 2081 2107 +26
============================================
- Hits 11257 10993 -264
- Misses 9687 10278 +591
+ Partials 910 900 -10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (-0.62%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [87 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...ba927b1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499081566
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluator.java
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableListMultimap;
+import com.google.common.collect.Multimaps;
+import lombok.AllArgsConstructor;
+import org.apache.skywalking.oap.server.core.Const;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * Evaluator composite rule using expression eval
+ *
+ * @since 8.2.0
+ */
+@AllArgsConstructor
+public class CompositeRuleEvaluator {
+
+ private Expression expression;
+
+ /**
+ * Evaluator composite rule
+ *
+ * @param compositeAlarmRules compositeRules
+ * @param alarmMessages triggered alarm messages
+ * @return
+ */
+ public List<AlarmMessage> evaluator(List<CompositeAlarmRule> compositeAlarmRules, List<AlarmMessage> alarmMessages) {
Review comment:
Done, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 180 -703
Lines 21854 4191 -17663
Branches 2081 470 -1611
============================================
- Hits 11257 0 -11257
+ Misses 9687 4191 -5496
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [864 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...ba927b1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `11.84%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.51% 39.66% -11.85%
+ Complexity 3305 2531 -774
=============================================
Files 883 896 +13
Lines 21854 22092 +238
Branches 2081 2105 +24
=============================================
- Hits 11257 8763 -2494
- Misses 9687 12690 +3003
+ Partials 910 639 -271
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-1.52%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [208 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/772f1d2e82aa97e47d0e04f81dc822f35e3e0d02?el=desc) will **decrease** coverage by `18.34%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.80% 33.45% -18.35%
+ Complexity 3363 2094 -1269
=============================================
Files 1606 868 -738
Lines 34102 21368 -12734
Branches 3710 2050 -1660
=============================================
- Hits 17666 7149 -10517
+ Misses 15581 13668 -1913
+ Partials 855 551 -304
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-66.67%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-13.01%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-19.39%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (-28.44%)` | `7.00 <1.00> (+1.00)` | :arrow_down: |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1221 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [772f1d2...4553cb1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/bc64c6a12770031478d29e2f19004796584374c9?el=desc) will **decrease** coverage by `52.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 52.13% 0.00% -52.14%
============================================
Files 901 171 -730
Lines 22195 4040 -18155
Branches 2124 465 -1659
============================================
- Hits 11572 0 -11572
+ Misses 9695 4040 -5655
+ Partials 928 0 -928
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [859 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [bc64c6a...b5adde1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499090949
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRulesWatcher.java
##########
@@ -46,16 +48,24 @@
private volatile Map<AlarmRule, RunningRule> alarmRuleRunningRuleMap;
private volatile Rules rules;
private volatile String settingsString;
+ @Getter
+ private volatile CompositeRuleEvaluator compositeRuleEvaluator;
Review comment:
done
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluator.java
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableListMultimap;
+import com.google.common.collect.Multimaps;
+import lombok.AllArgsConstructor;
+import org.apache.skywalking.oap.server.core.Const;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * Evaluator composite rule using expression eval
+ *
+ * @since 8.2.0
+ */
+@AllArgsConstructor
+public class CompositeRuleEvaluator {
+
+ private Expression expression;
+
+ /**
+ * Evaluator composite rule
+ *
+ * @param compositeAlarmRules compositeRules
+ * @param alarmMessages triggered alarm messages
+ * @return
+ */
+ public List<AlarmMessage> evaluator(List<CompositeAlarmRule> compositeAlarmRules, List<AlarmMessage> alarmMessages) {
+ final List<AlarmMessage> compositeRuleMessages = new ArrayList<>();
+ ImmutableListMultimap<String, AlarmMessage> messageMap = Multimaps.index(alarmMessages, alarmMessage -> Joiner.on(Const.ID_CONNECTOR).useForNull(Const.EMPTY_STRING).join(alarmMessage.getId0(), alarmMessage.getId1()));
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `5.11%`.
> The diff coverage is `35.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 37.07% -5.12%
+ Complexity 2648 2404 -244
============================================
Files 900 904 +4
Lines 22172 22232 +60
Branches 2123 2126 +3
============================================
- Hits 9354 8243 -1111
- Misses 12148 13375 +1227
+ Partials 670 614 -56
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-0.16%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [85 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ec375e2](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `10.14%`.
> The diff coverage is `35.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 42.18% 32.04% -10.15%
+ Complexity 2648 2093 -555
=============================================
Files 900 887 -13
Lines 22172 21744 -428
Branches 2123 2079 -44
=============================================
- Hits 9354 6968 -2386
- Misses 12148 14245 +2097
+ Partials 670 531 -139
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.04% <42.85%> (-1.96%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [160 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...caa13c6](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 169 -731
Lines 22172 4058 -18114
Branches 2123 461 -1662
============================================
- Hits 9354 0 -9354
+ Misses 12148 4058 -8090
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [725 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ec375e2](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `6.52%`.
> The diff coverage is `35.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 48.71% +6.52%
- Complexity 2648 3219 +571
============================================
Files 900 903 +3
Lines 22172 22276 +104
Branches 2123 2117 -6
============================================
+ Hits 9354 10851 +1497
+ Misses 12148 10544 -1604
- Partials 670 881 +211
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/CompositeRuleEvaluate.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-0.16%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [179 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r498807716
##########
File path: oap-server/server-alarm-plugin/src/test/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluatorTest.java
##########
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.ExpressionContext;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+
+public class CompositeRuleEvaluatorTest {
+
+ private CompositeRuleEvaluator ruleEvaluator;
+
+ @Before
+ public void init() {
+ Expression expression = new Expression(new ExpressionContext());
+ ruleEvaluator = new CompositeRuleEvaluator(expression);
+ }
+
+ @Test
+ public void testEvaluatorMessageWithAndOp() {
+ List<CompositeAlarmRule> compositeAlarmRules = new ArrayList<>();
+ CompositeAlarmRule compositeAlarmRule = new CompositeAlarmRule("dummy", "a_rule && b_rule", "composite rule triggered!");
+ compositeAlarmRules.add(compositeAlarmRule);
+ List<AlarmMessage> alarmMessages = getAlarmMessages();
+ List<AlarmMessage> compositeMsgs = ruleEvaluator.evaluator(compositeAlarmRules, alarmMessages);
+ assertThat(compositeMsgs.size(), is(1));
+ assertThat(compositeMsgs.get(0).getAlarmMessage(), is("composite rule triggered!"));
+ assertThat(compositeMsgs.get(0).getRuleName(), is("dummy"));
+ }
+
+ @Test
+ public void testEvaluatorMessageWithNotExistsRule() {
+ List<CompositeAlarmRule> compositeAlarmRules = new ArrayList<>();
+ CompositeAlarmRule compositeAlarmRule = new CompositeAlarmRule("dummy", "a_rule && not_exist_rule", "composite rule triggered!");
+ compositeAlarmRules.add(compositeAlarmRule);
+ List<AlarmMessage> alarmMessages = getAlarmMessages();
+ List<AlarmMessage> compositeMsgs = ruleEvaluator.evaluator(compositeAlarmRules, alarmMessages);
+ assertThat(compositeMsgs.size(), is(0));
+ }
+
+ @Test
+ public void testEvaluatorMessageWithException() {
+ List<CompositeAlarmRule> compositeAlarmRules = new ArrayList<>();
+ CompositeAlarmRule compositeAlarmRule = new CompositeAlarmRule("dummy", "a_rule + b_rule", "composite rule triggered!");
+ compositeAlarmRules.add(compositeAlarmRule);
+ List<AlarmMessage> alarmMessages = getAlarmMessages();
+ List<AlarmMessage> compositeMsgs = ruleEvaluator.evaluator(compositeAlarmRules, alarmMessages);
+ assertThat(compositeMsgs.size(), is(0));
Review comment:
Yes, will log the exception
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `3.01%`.
> The diff coverage is `35.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 45.20% +3.01%
- Complexity 2648 3056 +408
============================================
Files 900 904 +4
Lines 22172 22238 +66
Branches 2123 2131 +8
============================================
+ Hits 9354 10052 +698
+ Misses 12148 11356 -792
- Partials 670 830 +160
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/CompositeRuleEvaluate.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.94% <42.85%> (-1.06%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [233 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `3.01%`.
> The diff coverage is `35.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 39.16% -3.02%
+ Complexity 2648 2488 -160
============================================
Files 900 903 +3
Lines 22172 22242 +70
Branches 2123 2116 -7
============================================
- Hits 9354 8712 -642
- Misses 12148 12901 +753
+ Partials 670 629 -41
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/CompositeRuleEvaluate.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-0.16%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [46 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 165 -718
Lines 21854 3936 -17918
Branches 2081 447 -1634
============================================
- Hits 11257 0 -11257
+ Misses 9687 3936 -5751
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [853 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...ba927b1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `1.79%`.
> The diff coverage is `36.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 43.97% +1.79%
- Complexity 2648 2947 +299
============================================
Files 900 902 +2
Lines 22172 22140 -32
Branches 2123 2119 -4
============================================
+ Hits 9354 9737 +383
+ Misses 12148 11588 -560
- Partials 670 815 +145
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-0.16%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [265 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4f3264c](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `21.92%`.
> The diff coverage is `34.63%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.51% 29.58% -21.93%
+ Complexity 3305 1917 -1388
=============================================
Files 883 884 +1
Lines 21854 21618 -236
Branches 2081 2059 -22
=============================================
- Hits 11257 6395 -4862
- Misses 9687 14745 +5058
+ Partials 910 478 -432
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `31.39% <14.28%> (-14.52%)` | `10.00 <0.00> (-1.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [343 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499142073
##########
File path: oap-server/server-alarm-plugin/src/test/java/org/apache/skywalking/oap/server/core/alarm/provider/expression/ExpressionTest.java
##########
@@ -70,7 +70,7 @@ public void testEvalWithEmptyContext() {
@Test
public void testCompile() {
- String expr = " a && b ";
+ String expr = " a && * b ";
Review comment:
As logs said
> Error: Errors:
Error: ExpressionTest.testCompile:75 � Compile [Error: [Error: was expecting type: ja...
[INFO]
Error: Tests run: 50, Failures: 0, Errors: 1, Skipped: 0
Seems this would cause throwing exception. Please recheck.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 168 -715
Lines 21854 4027 -17827
Branches 2081 463 -1618
============================================
- Hits 11257 0 -11257
+ Misses 9687 4027 -5660
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [850 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **increase** coverage by `0.88%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 51.51% 52.39% +0.88%
- Complexity 3305 3366 +61
============================================
Files 883 896 +13
Lines 21854 22128 +274
Branches 2081 2106 +25
============================================
+ Hits 11257 11593 +336
+ Misses 9687 9606 -81
- Partials 910 929 +19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (-0.62%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [32 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/772f1d2e82aa97e47d0e04f81dc822f35e3e0d02?el=desc) will **increase** coverage by `0.73%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 51.80% 52.53% +0.73%
- Complexity 3363 3365 +2
============================================
Files 1606 893 -713
Lines 34102 22063 -12039
Branches 3710 2096 -1614
============================================
- Hits 17666 11591 -6075
+ Misses 15581 9542 -6039
- Partials 855 930 +75
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-66.67%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `47.53% <42.85%> (-9.87%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-19.39%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (-28.44%)` | `7.00 <1.00> (+1.00)` | :arrow_down: |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1108 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [772f1d2...4553cb1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499139843
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluator.java
##########
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableListMultimap;
+import com.google.common.collect.Multimaps;
+import org.apache.skywalking.oap.server.core.Const;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.MetaInAlarm;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Evaluate composite rule using expression eval
+ *
+ * @since 8.2.0
+ */
+public class CompositeRuleEvaluator {
+
+ private Expression expression;
+ private Map<String, AlarmMessageFormatter> messageFormatterCache;
+
+ public CompositeRuleEvaluator(Expression expression) {
+ this.expression = expression;
+ this.messageFormatterCache = new ConcurrentHashMap<>();
+ }
+
+ /**
+ * Evaluate composite rule
+ *
+ * @param compositeAlarmRules compositeRules
+ * @param alarmMessages triggered alarm messages
+ * @return
+ */
+ public List<AlarmMessage> evaluate(List<CompositeAlarmRule> compositeAlarmRules, List<AlarmMessage> alarmMessages) {
+ final List<AlarmMessage> compositeRuleMessages = new ArrayList<>();
+ ImmutableListMultimap<String, AlarmMessage> messageMap = Multimaps.index(alarmMessages, alarmMessage ->
+ Joiner.on(Const.ID_CONNECTOR).useForNull(Const.EMPTY_STRING).join(alarmMessage.getId0(), alarmMessage.getId1()));
+ for (CompositeAlarmRule compositeAlarmRule : compositeAlarmRules) {
+ String expr = compositeAlarmRule.getExpression();
+ Set<String> dependencyRules = expression.analysisInputs(expr);
+ Map<String, Object> dataContext = new HashMap<>();
+ messageMap.asMap().forEach((key, alarmMessageList) -> {
+ dependencyRules.forEach(ruleName -> dataContext.put(ruleName, false));
+ alarmMessageList.forEach(alarmMessage -> {
+ if (dependencyRules.contains(alarmMessage.getRuleName())) {
+ dataContext.put(alarmMessage.getRuleName(), true);
+ }
+ });
+ Object matched = expression.eval(expr, dataContext);
+ if (matched instanceof Boolean && (Boolean) matched) {
+ AlarmMessage headMsg = alarmMessageList.iterator().next();
+ AlarmMessage message = new AlarmMessage();
+ message.setOnlyAsCondition(false);
+ message.setScopeId(headMsg.getScopeId());
+ message.setScope(headMsg.getScope());
+ message.setName(headMsg.getName());
+ message.setId0(headMsg.getId0());
+ message.setId1(headMsg.getId1());
+ message.setStartTime(System.currentTimeMillis());
+ message.setRuleName(compositeAlarmRule.getAlarmRuleName());
+ String alarmMessage = formatMessage(message, compositeAlarmRule.getMessage());
+ message.setAlarmMessage(alarmMessage);
+ compositeRuleMessages.add(message);
+ }
+ });
+ }
+ return compositeRuleMessages;
+ }
+
+ private String formatMessage(AlarmMessage alarmMessage, String message) {
Review comment:
done
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/expression/Expression.java
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.expression;
+
+import lombok.extern.slf4j.Slf4j;
+import org.mvel2.MVEL;
+import org.mvel2.ParserContext;
+
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+@Slf4j
+public class Expression {
Review comment:
done
##########
File path: oap-server/server-alarm-plugin/src/test/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluatorTest.java
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.ExpressionContext;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+
+public class CompositeRuleEvaluatorTest {
Review comment:
done
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/expression/ExpressionContext.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.expression;
+
+import lombok.Getter;
+import org.mvel2.ParserContext;
+import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
+
+public class ExpressionContext {
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r498823047
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluator.java
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableListMultimap;
+import com.google.common.collect.Multimaps;
+import lombok.AllArgsConstructor;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * Evaluator composite rule using expression eval
+ *
+ * @since 8.2.0
+ */
+@AllArgsConstructor
+public class CompositeRuleEvaluator {
+
+ private Expression expression;
+
+ /**
+ * Evaluator composite rule
+ *
+ * @param compositeAlarmRules compositeRules
+ * @param alarmMessages triggered alarm messages
+ * @return
+ */
+ public List<AlarmMessage> evaluator(List<CompositeAlarmRule> compositeAlarmRules, List<AlarmMessage> alarmMessages) {
+ final List<AlarmMessage> compositeRuleMessages = new ArrayList<>();
+ ImmutableListMultimap<String, AlarmMessage> messageMap = Multimaps.index(alarmMessages, alarmMessage -> Joiner.on("_").useForNull("").join(alarmMessage.getId0(), alarmMessage.getId1()));
+ for (CompositeAlarmRule compositeAlarmRule : compositeAlarmRules) {
+ String expr = compositeAlarmRule.getExpression();
+ Set<String> dependencyRules = expression.analysisInputs(expr);
+ Map<String, Object> dataContext = new HashMap<>();
+ messageMap.asMap().forEach((key, alarmMessageList) -> {
+ Set<String> allRuleNames = new HashSet<>(dependencyRules);
+ alarmMessageList.forEach(alarmMessage -> {
+ if (allRuleNames.remove(alarmMessage.getRuleName())) {
+ dataContext.put(alarmMessage.getRuleName(), true);
+ }
+ });
+ allRuleNames.forEach(ruleName -> {
+ dataContext.put(ruleName, false);
+ });
+ Object matched = expression.eval(expr, dataContext);
+ if (matched instanceof Boolean && (Boolean) matched) {
+ AlarmMessage headMsg = alarmMessageList.iterator().next();
+ AlarmMessage message = new AlarmMessage();
+ message.setOnlyAsCondition(false);
+ message.setScopeId(headMsg.getScopeId());
+ message.setScope(headMsg.getScope());
+ message.setName(headMsg.getName());
+ message.setId0(headMsg.getId0());
+ message.setId1(headMsg.getId1());
Review comment:
sorry. should I update which part of the doc?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `8.06%`.
> The diff coverage is `35.10%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 50.25% +8.06%
- Complexity 2648 3251 +603
============================================
Files 900 904 +4
Lines 22172 22248 +76
Branches 2123 2127 +4
============================================
+ Hits 9354 11181 +1827
+ Misses 12148 10168 -1980
- Partials 670 899 +229
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `47.08% <42.85%> (+2.08%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [185 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ebeb288](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 176 -724
Lines 22172 4207 -17965
Branches 2123 486 -1637
============================================
- Hits 9354 0 -9354
+ Misses 12148 4207 -7941
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [718 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...3b4d467](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499151029
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/expression/Expression.java
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.expression;
+
+import lombok.extern.slf4j.Slf4j;
+import org.mvel2.MVEL;
+import org.mvel2.ParserContext;
+
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Expression support eval java basic expressions, just like groovy script
+ * The internal detail is it first compile the expression to a pareTree then execute the parseTree with data
Review comment:
done
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/expression/Expression.java
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.expression;
+
+import lombok.extern.slf4j.Slf4j;
+import org.mvel2.MVEL;
+import org.mvel2.ParserContext;
+
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Expression support eval java basic expressions, just like groovy script
+ * The internal detail is it first compile the expression to a pareTree then execute the parseTree with data
+ * It caches the compiled expression for sake of performance
+ */
+@Slf4j
+public class Expression {
+ private Map<String, Object> expressionCache;
+ private ExpressionContext context;
+
+ public Expression(ExpressionContext context) {
+ this.context = context;
+ this.expressionCache = new ConcurrentHashMap<>();
+ }
+
+ /**
+ * Eval the given expression using empty data context
+ */
+ public Object eval(String expression) {
+ return eval(expression, null);
+ }
+
+ /**
+ * Eval the given expression with data context
+ */
+ public Object eval(String expression, Map<String, Object> vars) {
+ try {
+ Object obj = compile(expression, context);
+ return MVEL.executeExpression(obj, vars);
+ } catch (Throwable e) {
+ log.error("eval expression {} error", expression, e);
+ return null;
+ }
+ }
+
+ /**
+ * Compile the given expression to a parseTree
+ */
+ public Object compile(String expression, ExpressionContext pctx) {
+ Object o = expressionCache.get(expression);
+ if (o == null) {
+ o = MVEL.compileExpression(expression, pctx.getContext());
+ expressionCache.put(expression, o);
+ }
+ return o;
Review comment:
done
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/expression/Expression.java
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.expression;
+
+import lombok.extern.slf4j.Slf4j;
+import org.mvel2.MVEL;
+import org.mvel2.ParserContext;
+
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Expression support eval java basic expressions, just like groovy script
+ * The internal detail is it first compile the expression to a pareTree then execute the parseTree with data
+ * It caches the compiled expression for sake of performance
+ */
+@Slf4j
+public class Expression {
+ private Map<String, Object> expressionCache;
+ private ExpressionContext context;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] muse-dev[bot] commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
muse-dev[bot] commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r498030507
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java
##########
@@ -323,7 +328,7 @@
}
}
- public AlarmMessage checkAlarm() {
+ public Optional<AlarmMessage> checkAlarm() {
if (isMatch()) {
Review comment:
*THREAD_SAFETY_VIOLATION:* Read/Write race. Non-private method `RunningRule$Window.checkAlarm()` indirectly reads without synchronization from `this.values`. Potentially races with write in method `RunningRule$Window.add(...)`.
Reporting because another access to the same memory occurs on a background thread, although this access may not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 183 -717
Lines 22172 4277 -17895
Branches 2123 487 -1636
============================================
- Hits 9354 0 -9354
+ Misses 12148 4277 -7871
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [713 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r498895735
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -41,10 +43,16 @@ Such as in **percentile**, `value1` is threshold of P50, and `-, -, value3, valu
backend deployment env time.
- **Count**. In the period window, if the number of **value**s over threshold(by OP), reaches count, alarm
should send.
+- **Only as condition**. Specify if the rule can send notfiy or just as an conditon of composite rule
- **Silence period**. After alarm is triggered in Time-N, then keep silence in the **TN -> TN + period**.
By default, it is as same as **Period**, which means in a period, same alarm(same ID in same
metrics name) will be trigger once.
+### Composite rules
Review comment:
```suggestion
### Composite rules
**NOTE**. Composite rules only work for alarm rules targeting the same entity level, such as alarm rules of the service level. For example, `service_percent_rule && service_resp_time_percentile_rule`. You shouldn't composite alarm rules of different entities, such as one alarm rule of the service metrics with another rule of the endpoint metrics.
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -41,10 +43,16 @@ Such as in **percentile**, `value1` is threshold of P50, and `-, -, value3, valu
backend deployment env time.
- **Count**. In the period window, if the number of **value**s over threshold(by OP), reaches count, alarm
should send.
+- **Only as condition**. Specify if the rule can send notfiy or just as an conditon of composite rule
- **Silence period**. After alarm is triggered in Time-N, then keep silence in the **TN -> TN + period**.
By default, it is as same as **Period**, which means in a period, same alarm(same ID in same
metrics name) will be trigger once.
+### Composite rules
+Composite rule is constituted by following keys
+- **Rule name**. Unique name, show in alarm message. Must end with `_rule`.
+- **Expression**. Specify how to compose rules, support and/or expression
Review comment:
Please test the `parenthesis` case, this is important with `and` and `or`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 164 -719
Lines 21854 3930 -17924
Branches 2081 447 -1634
============================================
- Hits 11257 0 -11257
+ Misses 9687 3930 -5757
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [854 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...ba927b1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 180 -720
Lines 22172 4262 -17910
Branches 2123 487 -1636
============================================
- Hits 9354 0 -9354
+ Misses 12148 4262 -7886
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [714 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...dca9216](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 169 -731
Lines 22172 4028 -18144
Branches 2123 457 -1666
============================================
- Hits 9354 0 -9354
+ Misses 12148 4028 -8120
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [725 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 182 -718
Lines 22172 4273 -17899
Branches 2123 487 -1636
============================================
- Hits 9354 0 -9354
+ Misses 12148 4273 -7875
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [712 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...caa13c6](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **increase** coverage by `0.36%`.
> The diff coverage is `72.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 51.51% 51.87% +0.36%
- Complexity 3305 3368 +63
============================================
Files 883 1609 +726
Lines 21854 34197 +12343
Branches 2081 3719 +1638
============================================
+ Hits 11257 17738 +6481
- Misses 9687 15599 +5912
+ Partials 910 860 -50
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `56.63% <57.14%> (+10.72%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `72.22% <70.10%> (+22.87%)` | `9.00 <7.00> (+6.00)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `92.68% <83.33%> (+29.82%)` | `7.00 <1.00> (+1.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `93.75% <93.75%> (ø)` | `0.00 <0.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `94.44% <94.44%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1110 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...b625300](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 175 -708
Lines 21854 4114 -17740
Branches 2081 475 -1606
============================================
- Hits 11257 0 -11257
+ Misses 9687 4114 -5573
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [857 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `0.49%`.
> The diff coverage is `36.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 51.01% -0.50%
+ Complexity 3305 3301 -4
============================================
Files 883 904 +21
Lines 21854 22300 +446
Branches 2081 2133 +52
============================================
+ Hits 11257 11376 +119
- Misses 9687 10007 +320
- Partials 910 917 +7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (-0.62%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [80 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...ba927b1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 183 -717
Lines 22172 4277 -17895
Branches 2123 487 -1636
============================================
- Hits 9354 0 -9354
+ Misses 12148 4277 -7871
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [713 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...3b4d467](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/772f1d2e82aa97e47d0e04f81dc822f35e3e0d02?el=desc) will **decrease** coverage by `22.19%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.80% 29.61% -22.20%
+ Complexity 3363 1904 -1459
=============================================
Files 1606 868 -738
Lines 34102 21343 -12759
Branches 3710 2034 -1676
=============================================
- Hits 17666 6320 -11346
+ Misses 15581 14542 -1039
+ Partials 855 481 -374
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-66.67%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `71.87% <28.57%> (-13.84%)` | `9.00 <2.00> (-1.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `39.46% <42.85%> (-17.94%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-19.39%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (-28.44%)` | `7.00 <1.00> (+1.00)` | :arrow_down: |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1239 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [772f1d2...4553cb1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/bc64c6a12770031478d29e2f19004796584374c9?el=desc) will **decrease** coverage by `52.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 52.13% 0.00% -52.14%
============================================
Files 901 164 -737
Lines 22195 3930 -18265
Branches 2124 447 -1677
============================================
- Hits 11572 0 -11572
+ Misses 9695 3930 -5765
+ Partials 928 0 -928
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [864 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [bc64c6a...b5adde1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `13.67%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.51% 37.83% -13.68%
+ Complexity 3305 2447 -858
=============================================
Files 883 896 +13
Lines 21854 22075 +221
Branches 2081 2104 +23
=============================================
- Hits 11257 8351 -2906
- Misses 9687 13103 +3416
+ Partials 910 621 -289
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-1.52%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [228 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/772f1d2e82aa97e47d0e04f81dc822f35e3e0d02?el=desc) will **decrease** coverage by `19.77%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.80% 32.02% -19.78%
+ Complexity 3363 2047 -1316
=============================================
Files 1606 868 -738
Lines 34102 21368 -12734
Branches 3710 2050 -1660
=============================================
- Hits 17666 6843 -10823
+ Misses 15581 14007 -1574
+ Partials 855 518 -337
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-66.67%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `41.70% <42.85%> (-15.70%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-19.39%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (-28.44%)` | `7.00 <1.00> (+1.00)` | :arrow_down: |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1224 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [772f1d2...4553cb1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 165 -735
Lines 22172 3957 -18215
Branches 2123 450 -1673
============================================
- Hits 9354 0 -9354
+ Misses 12148 3957 -8191
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [730 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ec375e2](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/772f1d2e82aa97e47d0e04f81dc822f35e3e0d02?el=desc) will **decrease** coverage by `51.80%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.80% 0.00% -51.81%
============================================
Files 1606 161 -1445
Lines 34102 3899 -30203
Branches 3710 459 -3251
============================================
- Hits 17666 0 -17666
+ Misses 15581 3899 -11682
+ Partials 855 0 -855
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1573 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [772f1d2...4553cb1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `3.65%`.
> The diff coverage is `35.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 45.84% +3.65%
- Complexity 2648 3019 +371
============================================
Files 900 887 -13
Lines 22172 21778 -394
Branches 2123 2085 -38
============================================
+ Hits 9354 9984 +630
+ Misses 12148 10941 -1207
- Partials 670 853 +183
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-0.61%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [247 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...3b4d467](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `21.64%`.
> The diff coverage is `34.63%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.51% 29.86% -21.65%
+ Complexity 3305 1937 -1368
=============================================
Files 883 878 -5
Lines 21854 21513 -341
Branches 2081 2050 -31
=============================================
- Hits 11257 6425 -4832
- Misses 9687 14622 +4935
+ Partials 910 466 -444
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `31.39% <14.28%> (-14.52%)` | `10.00 <0.00> (-1.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [333 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **increase** coverage by `0.36%`.
> The diff coverage is `72.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 51.51% 51.87% +0.36%
- Complexity 3305 3368 +63
============================================
Files 883 1609 +726
Lines 21854 34197 +12343
Branches 2081 3719 +1638
============================================
+ Hits 11257 17738 +6481
- Misses 9687 15599 +5912
+ Partials 910 860 -50
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `56.63% <57.14%> (+10.72%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `72.22% <70.10%> (+22.87%)` | `9.00 <7.00> (+6.00)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `92.68% <83.33%> (+29.82%)` | `7.00 <1.00> (+1.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `93.75% <93.75%> (ø)` | `0.00 <0.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `94.44% <94.44%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1110 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r498895735
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -41,10 +43,16 @@ Such as in **percentile**, `value1` is threshold of P50, and `-, -, value3, valu
backend deployment env time.
- **Count**. In the period window, if the number of **value**s over threshold(by OP), reaches count, alarm
should send.
+- **Only as condition**. Specify if the rule can send notfiy or just as an conditon of composite rule
- **Silence period**. After alarm is triggered in Time-N, then keep silence in the **TN -> TN + period**.
By default, it is as same as **Period**, which means in a period, same alarm(same ID in same
metrics name) will be trigger once.
+### Composite rules
Review comment:
```suggestion
### Composite rules
**NOTE**. Composite rules only work for alarm rules targeting the same entity level, such as alarm rules of the service level. For example, `service_percent_rule && service_resp_time_percentile_rule`. You shouldn't compose alarm rules of different entities, such as one alarm rule of the service metrics with another rule of the endpoint metrics.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/bc64c6a12770031478d29e2f19004796584374c9?el=desc) will **decrease** coverage by `21.50%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 52.13% 30.63% -21.51%
+ Complexity 3361 2000 -1361
=============================================
Files 901 876 -25
Lines 22195 21515 -680
Branches 2124 2046 -78
=============================================
- Hits 11572 6591 -4981
- Misses 9695 14429 +4734
+ Partials 928 495 -433
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `38.56% <42.85%> (-8.71%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [320 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [bc64c6a...b5adde1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499116159
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -93,8 +108,15 @@ rules:
count: 3
silence-period: 5
message: The request number of entity {name} non-200 status is more than expected.
+ only-as-condition: false
+composite-rules:
+ comp_rule:
+ # Must satisfied percent rule and resp time rule
+ expression: service_percent_rule && service_resp_time_percentile_rule
+ message: Service percent less than 80% and response time p50 > 1000
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `0.95%`.
> The diff coverage is `36.06%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 43.14% +0.95%
- Complexity 2648 2942 +294
============================================
Files 900 904 +4
Lines 22172 22225 +53
Branches 2123 2125 +2
============================================
+ Hits 9354 9589 +235
+ Misses 12148 11829 -319
- Partials 670 807 +137
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `31.25% <31.25%> (ø)` | `2.00 <2.00> (?)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-0.61%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [265 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ec375e2](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **increase** coverage by `0.78%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 51.51% 52.29% +0.78%
- Complexity 3305 3361 +56
============================================
Files 883 896 +13
Lines 21854 22128 +274
Branches 2081 2106 +25
============================================
+ Hits 11257 11572 +315
+ Misses 9687 9627 -60
- Partials 910 929 +19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (-0.62%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 168 -732
Lines 22172 4027 -18145
Branches 2123 458 -1665
============================================
- Hits 9354 0 -9354
+ Misses 12148 4027 -8121
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [727 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...dca9216](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `6.53%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 44.97% -6.54%
+ Complexity 3305 2991 -314
============================================
Files 883 902 +19
Lines 21854 22116 +262
Branches 2081 2105 +24
============================================
- Hits 11257 9946 -1311
- Misses 9687 11322 +1635
+ Partials 910 848 -62
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `42.60% <42.85%> (-3.31%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [139 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `9.60%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 41.90% -9.61%
+ Complexity 3305 2634 -671
============================================
Files 883 896 +13
Lines 21854 22128 +274
Branches 2081 2106 +25
============================================
- Hits 11257 9272 -1985
- Misses 9687 12175 +2488
+ Partials 910 681 -229
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (-0.62%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [185 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701980557
@xbkaishui Don't worry about this. In these days, the connection between github and maven central has issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/772f1d2e82aa97e47d0e04f81dc822f35e3e0d02?el=desc) will **increase** coverage by `0.93%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 51.80% 52.73% +0.93%
- Complexity 3363 3365 +2
============================================
Files 1606 886 -720
Lines 34102 21972 -12130
Branches 3710 2105 -1605
============================================
- Hits 17666 11588 -6078
+ Misses 15581 9455 -6126
- Partials 855 929 +74
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-66.67%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.73% <42.85%> (-11.66%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-19.39%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (-28.44%)` | `7.00 <1.00> (+1.00)` | :arrow_down: |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1108 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [772f1d2...4553cb1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `18.88%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.51% 32.62% -18.89%
+ Complexity 3305 2131 -1174
=============================================
Files 883 897 +14
Lines 21854 22018 +164
Branches 2081 2098 +17
=============================================
- Hits 11257 7183 -4074
- Misses 9687 14307 +4620
+ Partials 910 528 -382
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `42.60% <42.85%> (-3.31%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [298 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `17.61%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.51% 33.89% -17.62%
+ Complexity 3305 2219 -1086
=============================================
Files 883 896 +13
Lines 21854 22013 +159
Branches 2081 2098 +17
=============================================
- Hits 11257 7461 -3796
- Misses 9687 13989 +4302
+ Partials 910 563 -347
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.04% <42.85%> (-2.86%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [268 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `12.34%`.
> The diff coverage is `35.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 42.18% 29.84% -12.35%
+ Complexity 2648 1970 -678
=============================================
Files 900 887 -13
Lines 22172 21734 -438
Branches 2123 2078 -45
=============================================
- Hits 9354 6486 -2868
- Misses 12148 14759 +2611
+ Partials 670 489 -181
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `71.87% <28.57%> (-13.84%)` | `9.00 <2.00> (-1.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `42.60% <42.85%> (-2.40%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [167 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...3b4d467](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 174 -709
Lines 21854 4118 -17736
Branches 2081 475 -1606
============================================
- Hits 11257 0 -11257
+ Misses 9687 4118 -5569
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 171 -712
Lines 21854 4040 -17814
Branches 2081 465 -1616
============================================
- Hits 11257 0 -11257
+ Misses 9687 4040 -5647
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [853 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 172 -711
Lines 21854 4076 -17778
Branches 2081 471 -1610
============================================
- Hits 11257 0 -11257
+ Misses 9687 4076 -5611
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [854 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `2.83%`.
> The diff coverage is `35.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 39.35% -2.84%
+ Complexity 2648 2475 -173
============================================
Files 900 887 -13
Lines 22172 21787 -385
Branches 2123 2086 -37
============================================
- Hits 9354 8574 -780
- Misses 12148 12575 +427
+ Partials 670 638 -32
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-0.61%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [68 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...3b4d467](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `3.01%`.
> The diff coverage is `35.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 45.20% +3.01%
- Complexity 2648 3064 +416
============================================
Files 900 904 +4
Lines 22172 22238 +66
Branches 2123 2131 +8
============================================
+ Hits 9354 10052 +698
+ Misses 12148 11356 -792
- Partials 670 830 +160
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/CompositeRuleEvaluate.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.94% <42.85%> (-1.06%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [233 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r498331504
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -93,17 +105,24 @@ rules:
count: 3
silence-period: 5
message: The request number of entity {name} non-200 status is more than expected.
+ only-as-condition: false
+composite-rules:
+ comp_rule:
+ # Must satisfied percent rule and resp time rule
+ expression: service_percent_rule && service_resp_time_percentile_rule
+ message: Service percent less than 80% and response time p50 > 1000
```
+
### Default alarm rules
We provided a default `alarm-setting.yml` in our distribution only for convenience, which including following rules
1. Service average response time over 1s in last 3 minutes.
-1. Service success rate lower than 80% in last 2 minutes.
-1. Percentile of service response time is over 1s in last 3 minutes
-1. Service Instance average response time over 1s in last 2 minutes, and the instance name matches the regex.
-1. Endpoint average response time over 1s in last 2 minutes.
-1. Database access average response time over 1s in last 2 minutes.
-1. Endpoint relation average response time over 1s in last 2 minutes.
+2. Service success rate lower than 80% in last 2 minutes.
+3. Percentile of service response time is over 1s in last 3 minutes
+4. Service Instance average response time over 1s in last 2 minutes, and the instance name matches the regex.
+5. Endpoint average response time over 1s in last 2 minutes.
+6. Database access average response time over 1s in last 2 minutes.
+7. Endpoint relation average response time over 1s in last 2 minutes.
Review comment:
```suggestion
1. Service success rate lower than 80% in last 2 minutes.
1. Percentile of service response time is over 1s in last 3 minutes
1. Service Instance average response time over 1s in last 2 minutes, and the instance name matches the regex.
1. Endpoint average response time over 1s in last 2 minutes.
1. Database access average response time over 1s in last 2 minutes.
1. Endpoint relation average response time over 1s in last 2 minutes.
```
This is markdown, you don't need to increase by yourself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 159 -741
Lines 22172 3842 -18330
Branches 2123 441 -1682
============================================
- Hits 9354 0 -9354
+ Misses 12148 3842 -8306
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [735 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4f3264c](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `36.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 42.10% -0.09%
- Complexity 2648 2862 +214
============================================
Files 900 901 +1
Lines 22172 22087 -85
Branches 2123 2117 -6
============================================
- Hits 9354 9299 -55
+ Misses 12148 11998 -150
- Partials 670 790 +120
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-0.16%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [288 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4f3264c](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `14.69%`.
> The diff coverage is `36.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.51% 36.81% -14.70%
+ Complexity 3305 2343 -962
=============================================
Files 883 887 +4
Lines 21854 21771 -83
Branches 2081 2085 +4
=============================================
- Hits 11257 8014 -3243
- Misses 9687 13151 +3464
+ Partials 910 606 -304
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-1.52%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [260 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...ba927b1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/bc64c6a12770031478d29e2f19004796584374c9?el=desc) will **decrease** coverage by `0.71%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 52.13% 51.42% -0.72%
+ Complexity 3361 3311 -50
============================================
Files 901 893 -8
Lines 22195 22063 -132
Branches 2124 2096 -28
============================================
- Hits 11572 11346 -226
- Misses 9695 9798 +103
+ Partials 928 919 -9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `47.53% <42.85%> (+0.26%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [58 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [bc64c6a...b5adde1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `12.36%`.
> The diff coverage is `36.06%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 42.18% 29.82% -12.37%
+ Complexity 2648 1969 -679
=============================================
Files 900 887 -13
Lines 22172 21730 -442
Branches 2123 2077 -46
=============================================
- Hits 9354 6481 -2873
- Misses 12148 14760 +2612
+ Partials 670 489 -181
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `71.87% <28.57%> (-13.84%)` | `9.00 <2.00> (-1.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `31.25% <31.25%> (ø)` | `2.00 <2.00> (?)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `38.56% <42.85%> (-6.44%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [170 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ec375e2](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 172 -728
Lines 22172 4076 -18096
Branches 2123 471 -1652
============================================
- Hits 9354 0 -9354
+ Misses 12148 4076 -8072
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [722 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 158 -742
Lines 22172 3812 -18360
Branches 2123 441 -1682
============================================
- Hits 9354 0 -9354
+ Misses 12148 3812 -8336
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [736 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `1.99%`.
> The diff coverage is `36.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 44.18% +1.99%
- Complexity 2648 2956 +308
============================================
Files 900 902 +2
Lines 22172 22140 -32
Branches 2123 2119 -4
============================================
+ Hits 9354 9783 +429
+ Misses 12148 11533 -615
- Partials 670 824 +154
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-0.16%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [262 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4f3264c](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `2.73%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 48.77% -2.74%
+ Complexity 3305 3163 -142
============================================
Files 883 902 +19
Lines 21854 22161 +307
Branches 2081 2106 +25
============================================
- Hits 11257 10809 -448
- Misses 9687 10469 +782
+ Partials 910 883 -27
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-1.07%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [95 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 176 -724
Lines 22172 4124 -18048
Branches 2123 475 -1648
============================================
- Hits 9354 0 -9354
+ Misses 12148 4124 -8024
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [718 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 164 -719
Lines 21854 3941 -17913
Branches 2081 459 -1622
============================================
- Hits 11257 0 -11257
+ Misses 9687 3941 -5746
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [847 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499107565
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -93,8 +108,15 @@ rules:
count: 3
silence-period: 5
message: The request number of entity {name} non-200 status is more than expected.
+ only-as-condition: false
+composite-rules:
+ comp_rule:
+ # Must satisfied percent rule and resp time rule
+ expression: service_percent_rule && service_resp_time_percentile_rule
+ message: Service percent less than 80% and response time p50 > 1000
Review comment:
If so, please add a test case for this too, besides change the documents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **increase** coverage by `0.36%`.
> The diff coverage is `72.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 51.51% 51.87% +0.36%
- Complexity 3305 3368 +63
============================================
Files 883 1609 +726
Lines 21854 34197 +12343
Branches 2081 3719 +1638
============================================
+ Hits 11257 17738 +6481
- Misses 9687 15599 +5912
+ Partials 910 860 -50
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `56.63% <57.14%> (+10.72%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `72.22% <70.10%> (+22.87%)` | `9.00 <7.00> (+6.00)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `92.68% <83.33%> (+29.82%)` | `7.00 <1.00> (+1.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `93.75% <93.75%> (ø)` | `0.00 <0.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `94.44% <94.44%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1110 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `15.42%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.51% 36.08% -15.43%
+ Complexity 3305 2312 -993
=============================================
Files 883 897 +14
Lines 21854 22018 +164
Branches 2081 2098 +17
=============================================
- Hits 11257 7946 -3311
- Misses 9687 13465 +3778
+ Partials 910 607 -303
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `42.60% <42.85%> (-3.31%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [272 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 178 -705
Lines 21854 4153 -17701
Branches 2081 475 -1606
============================================
- Hits 11257 0 -11257
+ Misses 9687 4153 -5534
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [860 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 172 -711
Lines 21854 4076 -17778
Branches 2081 471 -1610
============================================
- Hits 11257 0 -11257
+ Misses 9687 4076 -5611
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [854 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499090585
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -41,10 +43,16 @@ Such as in **percentile**, `value1` is threshold of P50, and `-, -, value3, valu
backend deployment env time.
- **Count**. In the period window, if the number of **value**s over threshold(by OP), reaches count, alarm
should send.
+- **Only as condition**. Specify if the rule can send notfiy or just as an conditon of composite rule
- **Silence period**. After alarm is triggered in Time-N, then keep silence in the **TN -> TN + period**.
By default, it is as same as **Period**, which means in a period, same alarm(same ID in same
metrics name) will be trigger once.
+### Composite rules
Review comment:
done
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -41,10 +43,16 @@ Such as in **percentile**, `value1` is threshold of P50, and `-, -, value3, valu
backend deployment env time.
- **Count**. In the period window, if the number of **value**s over threshold(by OP), reaches count, alarm
should send.
+- **Only as condition**. Specify if the rule can send notfiy or just as an conditon of composite rule
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `8.06%`.
> The diff coverage is `35.10%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 50.25% +8.06%
- Complexity 2648 3251 +603
============================================
Files 900 904 +4
Lines 22172 22248 +76
Branches 2123 2127 +4
============================================
+ Hits 9354 11181 +1827
+ Misses 12148 10168 -1980
- Partials 670 899 +229
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `47.08% <42.85%> (+2.08%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [185 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...dca9216](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 162 -738
Lines 22172 3929 -18243
Branches 2123 459 -1664
============================================
- Hits 9354 0 -9354
+ Misses 12148 3929 -8219
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [732 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4f3264c](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499081433
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluator.java
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableListMultimap;
+import com.google.common.collect.Multimaps;
+import lombok.AllArgsConstructor;
+import org.apache.skywalking.oap.server.core.Const;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * Evaluator composite rule using expression eval
+ *
+ * @since 8.2.0
+ */
+@AllArgsConstructor
+public class CompositeRuleEvaluator {
+
+ private Expression expression;
+
+ /**
+ * Evaluator composite rule
+ *
+ * @param compositeAlarmRules compositeRules
+ * @param alarmMessages triggered alarm messages
+ * @return
+ */
+ public List<AlarmMessage> evaluator(List<CompositeAlarmRule> compositeAlarmRules, List<AlarmMessage> alarmMessages) {
+ final List<AlarmMessage> compositeRuleMessages = new ArrayList<>();
+ ImmutableListMultimap<String, AlarmMessage> messageMap = Multimaps.index(alarmMessages, alarmMessage -> Joiner.on(Const.ID_CONNECTOR).useForNull(Const.EMPTY_STRING).join(alarmMessage.getId0(), alarmMessage.getId1()));
+ for (CompositeAlarmRule compositeAlarmRule : compositeAlarmRules) {
+ String expr = compositeAlarmRule.getExpression();
+ Set<String> dependencyRules = expression.analysisInputs(expr);
+ Map<String, Object> dataContext = new HashMap<>();
+ messageMap.asMap().forEach((key, alarmMessageList) -> {
+ dependencyRules.forEach(ruleName -> dataContext.put(ruleName, false));
+ alarmMessageList.forEach(alarmMessage -> {
+ if (dependencyRules.contains(alarmMessage.getRuleName())) {
+ dataContext.put(alarmMessage.getRuleName(), true);
Review comment:
Yes, when the composite rule contains this rulename, then put in the data context for eval the expression
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `15.24%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.51% 36.26% -15.25%
+ Complexity 3305 2349 -956
=============================================
Files 883 896 +13
Lines 21854 22075 +221
Branches 2081 2104 +23
=============================================
- Hits 11257 8005 -3252
- Misses 9687 13459 +3772
+ Partials 910 611 -299
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.04% <42.85%> (-2.86%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [251 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `13.68%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.51% 37.82% -13.69%
+ Complexity 3305 2446 -859
=============================================
Files 883 896 +13
Lines 21854 22075 +221
Branches 2081 2104 +23
=============================================
- Hits 11257 8350 -2907
- Misses 9687 13104 +3417
+ Partials 910 621 -289
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-1.52%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [228 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `12.81%`.
> The diff coverage is `35.10%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 42.18% 29.37% -12.82%
+ Complexity 2648 1918 -730
=============================================
Files 900 887 -13
Lines 22172 21691 -481
Branches 2123 2077 -46
=============================================
- Hits 9354 6371 -2983
- Misses 12148 14842 +2694
+ Partials 670 478 -192
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `42.60% <42.85%> (-2.40%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [174 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...dca9216](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 167 -716
Lines 21854 3984 -17870
Branches 2081 449 -1632
============================================
- Hits 11257 0 -11257
+ Misses 9687 3984 -5703
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [853 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...ba927b1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/bc64c6a12770031478d29e2f19004796584374c9?el=desc) will **decrease** coverage by `52.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 52.13% 0.00% -52.14%
============================================
Files 901 161 -740
Lines 22195 3898 -18297
Branches 2124 445 -1679
============================================
- Hits 11572 0 -11572
+ Misses 9695 3898 -5797
+ Partials 928 0 -928
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [866 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [bc64c6a...b5adde1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `1.67%`.
> The diff coverage is `35.10%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 40.51% -1.68%
+ Complexity 2648 2541 -107
============================================
Files 900 904 +4
Lines 22172 22248 +76
Branches 2123 2127 +4
============================================
- Hits 9354 9014 -340
- Misses 12148 12574 +426
+ Partials 670 660 -10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (+0.29%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [49 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...dca9216](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499145995
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -41,10 +43,19 @@ Such as in **percentile**, `value1` is threshold of P50, and `-, -, value3, valu
backend deployment env time.
- **Count**. In the period window, if the number of **value**s over threshold(by OP), reaches count, alarm
should send.
+- **Only as condition**. Specify if the rule can send notification or just as an condition of composite rule.
- **Silence period**. After alarm is triggered in Time-N, then keep silence in the **TN -> TN + period**.
By default, it is as same as **Period**, which means in a period, same alarm(same ID in same
metrics name) will be trigger once.
+### Composite rules
+**NOTE**. Composite rules only work for alarm rules targeting the same entity level, such as alarm rules of the service level.
+For example, `service_percent_rule && service_resp_time_percentile_rule`. You shouldn't compose alarm rules of different entities,
Review comment:
Never mind, please ignore this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 164 -736
Lines 22172 3914 -18258
Branches 2123 445 -1678
============================================
- Hits 9354 0 -9354
+ Misses 12148 3914 -8234
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [730 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `18.86%`.
> The diff coverage is `36.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 42.18% 23.32% -18.87%
+ Complexity 2648 1630 -1018
=============================================
Files 900 898 -2
Lines 22172 21839 -333
Branches 2123 2067 -56
=============================================
- Hits 9354 5094 -4260
- Misses 12148 16388 +4240
+ Partials 670 357 -313
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `36.32% <42.85%> (-8.68%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [261 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4f3264c](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `8.81%`.
> The diff coverage is `35.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 50.99% +8.81%
- Complexity 2648 3328 +680
============================================
Files 900 904 +4
Lines 22172 22310 +138
Branches 2123 2133 +10
============================================
+ Hits 9354 11378 +2024
+ Misses 12148 10009 -2139
- Partials 670 923 +253
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (+0.29%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [167 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...3b4d467](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499151122
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/expression/Expression.java
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.expression;
+
+import lombok.extern.slf4j.Slf4j;
+import org.mvel2.MVEL;
+import org.mvel2.ParserContext;
+
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Expression support eval java basic expressions, just like groovy script
+ * The internal detail is it first compile the expression to a pareTree then execute the parseTree with data
+ * It caches the compiled expression for sake of performance
+ */
+@Slf4j
+public class Expression {
+ private Map<String, Object> expressionCache;
+ private ExpressionContext context;
+
+ public Expression(ExpressionContext context) {
+ this.context = context;
+ this.expressionCache = new ConcurrentHashMap<>();
+ }
+
+ /**
+ * Eval the given expression using empty data context
+ */
+ public Object eval(String expression) {
+ return eval(expression, null);
+ }
+
+ /**
+ * Eval the given expression with data context
+ */
+ public Object eval(String expression, Map<String, Object> vars) {
+ try {
+ Object obj = compile(expression, context);
+ return MVEL.executeExpression(obj, vars);
+ } catch (Throwable e) {
+ log.error("eval expression {} error", expression, e);
+ return null;
+ }
+ }
+
+ /**
+ * Compile the given expression to a parseTree
+ */
+ public Object compile(String expression, ExpressionContext pctx) {
+ Object o = expressionCache.get(expression);
+ if (o == null) {
+ o = MVEL.compileExpression(expression, pctx.getContext());
+ expressionCache.put(expression, o);
+ }
+ return o;
Review comment:
I have a little doubt about this. What concurrency case makes us need `atomic`? @kezhenxu94
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `36.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 42.17% -0.02%
- Complexity 2648 2862 +214
============================================
Files 900 900
Lines 22172 22047 -125
Branches 2123 2113 -10
============================================
- Hits 9354 9299 -55
+ Misses 12148 11958 -190
- Partials 670 790 +120
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-0.16%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [288 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4f3264c](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `19.12%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.51% 32.38% -19.13%
+ Complexity 3305 2065 -1240
=============================================
Files 883 884 +1
Lines 21854 21618 -236
Branches 2081 2059 -22
=============================================
- Hits 11257 7000 -4257
- Misses 9687 14072 +4385
+ Partials 910 546 -364
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `38.56% <42.85%> (-7.35%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [325 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 183 -717
Lines 22172 4277 -17895
Branches 2123 487 -1636
============================================
- Hits 9354 0 -9354
+ Misses 12148 4277 -7871
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [713 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...dca9216](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `7.32%`.
> The diff coverage is `35.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 34.85% -7.33%
+ Complexity 2648 2310 -338
============================================
Files 900 904 +4
Lines 22172 22207 +35
Branches 2123 2126 +3
============================================
- Hits 9354 7741 -1613
- Misses 12148 13885 +1737
+ Partials 670 581 -89
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/CompositeRuleEvaluate.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.94% <42.85%> (-1.06%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [115 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r498822461
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluator.java
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableListMultimap;
+import com.google.common.collect.Multimaps;
+import lombok.AllArgsConstructor;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * Evaluator composite rule using expression eval
+ *
+ * @since 8.2.0
+ */
+@AllArgsConstructor
+public class CompositeRuleEvaluator {
+
+ private Expression expression;
+
+ /**
+ * Evaluator composite rule
+ *
+ * @param compositeAlarmRules compositeRules
+ * @param alarmMessages triggered alarm messages
+ * @return
+ */
+ public List<AlarmMessage> evaluator(List<CompositeAlarmRule> compositeAlarmRules, List<AlarmMessage> alarmMessages) {
+ final List<AlarmMessage> compositeRuleMessages = new ArrayList<>();
+ ImmutableListMultimap<String, AlarmMessage> messageMap = Multimaps.index(alarmMessages, alarmMessage -> Joiner.on("_").useForNull("").join(alarmMessage.getId0(), alarmMessage.getId1()));
+ for (CompositeAlarmRule compositeAlarmRule : compositeAlarmRules) {
+ String expr = compositeAlarmRule.getExpression();
+ Set<String> dependencyRules = expression.analysisInputs(expr);
+ Map<String, Object> dataContext = new HashMap<>();
+ messageMap.asMap().forEach((key, alarmMessageList) -> {
+ Set<String> allRuleNames = new HashSet<>(dependencyRules);
+ alarmMessageList.forEach(alarmMessage -> {
+ if (allRuleNames.remove(alarmMessage.getRuleName())) {
Review comment:
I have refactored this logic. please check again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/bc64c6a12770031478d29e2f19004796584374c9?el=desc) will **decrease** coverage by `52.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 52.13% 0.00% -52.14%
============================================
Files 901 161 -740
Lines 22195 3898 -18297
Branches 2124 445 -1679
============================================
- Hits 11572 0 -11572
+ Misses 9695 3898 -5797
+ Partials 928 0 -928
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [866 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [bc64c6a...b5adde1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `51.87%`.
> The diff coverage is `36.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
+ Coverage 0.00% 51.87% +51.87%
- Complexity 0 3360 +3360
=============================================
Files 176 904 +728
Lines 4124 22300 +18176
Branches 475 2133 +1658
=============================================
+ Hits 0 11569 +11569
- Misses 4124 9801 +5677
- Partials 0 930 +930
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (?)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (ø)` | `10.00 <2.00> (?)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (ø)` | `11.00 <1.00> (?)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (ø)` | `9.00 <7.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (ø)` | `7.00 <1.00> (?)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (?)` | |
| ... and [874 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4f3264c](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `11.10%`.
> The diff coverage is `35.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 42.18% 31.07% -11.11%
+ Complexity 2648 2036 -612
=============================================
Files 900 887 -13
Lines 22172 21757 -415
Branches 2123 2083 -40
=============================================
- Hits 9354 6762 -2592
- Misses 12148 14499 +2351
+ Partials 670 496 -174
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `42.60% <42.85%> (-2.40%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [142 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ebeb288](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/bc64c6a12770031478d29e2f19004796584374c9?el=desc) will **decrease** coverage by `4.27%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 52.13% 47.85% -4.28%
+ Complexity 3361 3100 -261
============================================
Files 901 876 -25
Lines 22195 21534 -661
Branches 2124 2048 -76
============================================
- Hits 11572 10306 -1266
- Misses 9695 10371 +676
+ Partials 928 857 -71
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-2.43%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [105 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [bc64c6a...b5adde1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `2.78%`.
> The diff coverage is `36.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 44.97% +2.78%
- Complexity 2648 3006 +358
============================================
Files 900 902 +2
Lines 22172 22140 -32
Branches 2123 2119 -4
============================================
+ Hits 9354 9957 +603
+ Misses 12148 11348 -800
- Partials 670 835 +165
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-0.16%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [250 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4f3264c](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 173 -710
Lines 21854 4070 -17784
Branches 2081 465 -1616
============================================
- Hits 11257 0 -11257
+ Misses 9687 4070 -5617
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [855 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `3.01%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 48.49% -3.02%
+ Complexity 3305 3155 -150
============================================
Files 883 904 +21
Lines 21854 22226 +372
Branches 2081 2112 +31
============================================
- Hits 11257 10779 -478
- Misses 9687 10549 +862
+ Partials 910 898 -12
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (-0.62%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [99 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499108317
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluate.java
##########
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableListMultimap;
+import com.google.common.collect.Multimaps;
+import lombok.AllArgsConstructor;
+import org.apache.skywalking.oap.server.core.Const;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * Evaluate composite rule using expression eval
+ *
+ * @since 8.2.0
+ */
+@AllArgsConstructor
+public class CompositeRuleEvaluate {
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `21.69%`.
> The diff coverage is `36.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.51% 29.81% -21.70%
+ Complexity 3305 1967 -1338
=============================================
Files 883 887 +4
Lines 21854 21724 -130
Branches 2081 2078 -3
=============================================
- Hits 11257 6477 -4780
- Misses 9687 14757 +5070
+ Partials 910 490 -420
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `71.87% <28.57%> (-13.84%)` | `9.00 <2.00> (-1.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `38.56% <42.85%> (-7.35%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [333 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...ba927b1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `6.59%`.
> The diff coverage is `35.10%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 35.58% -6.60%
+ Complexity 2648 2317 -331
============================================
Files 900 904 +4
Lines 22172 22209 +37
Branches 2123 2126 +3
============================================
- Hits 9354 7904 -1450
- Misses 12148 13718 +1570
+ Partials 670 587 -83
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-0.61%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [109 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...dca9216](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `12.08%`.
> The diff coverage is `35.10%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 42.18% 30.10% -12.09%
+ Complexity 2648 1961 -687
=============================================
Files 900 887 -13
Lines 22172 21691 -481
Branches 2123 2077 -46
=============================================
- Hits 9354 6530 -2824
- Misses 12148 14675 +2527
+ Partials 670 486 -184
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.94% <42.85%> (-1.06%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [164 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...dca9216](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 174 -726
Lines 22172 4132 -18040
Branches 2123 466 -1657
============================================
- Hits 9354 0 -9354
+ Misses 12148 4132 -8016
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [720 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `15.44%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.51% 36.06% -15.45%
+ Complexity 3305 2312 -993
=============================================
Files 883 900 +17
Lines 21854 22033 +179
Branches 2081 2098 +17
=============================================
- Hits 11257 7946 -3311
- Misses 9687 13480 +3793
+ Partials 910 607 -303
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `42.60% <42.85%> (-3.31%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [275 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 168 -715
Lines 21854 4008 -17846
Branches 2081 463 -1618
============================================
- Hits 11257 0 -11257
+ Misses 9687 4008 -5679
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [851 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r498318711
##########
File path: oap-server/pom.xml
##########
@@ -531,6 +532,11 @@
<artifactId>groovy</artifactId>
<version>${groovy.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.mvel</groupId>
+ <artifactId>mvel2</artifactId>
+ <version>${mvel.version}</version>
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `3.46%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 48.04% -3.47%
+ Complexity 3305 3137 -168
============================================
Files 883 902 +19
Lines 21854 22161 +307
Branches 2081 2106 +25
============================================
- Hits 11257 10647 -610
- Misses 9687 10638 +951
+ Partials 910 876 -34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-1.07%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [100 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499106311
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluate.java
##########
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableListMultimap;
+import com.google.common.collect.Multimaps;
+import lombok.AllArgsConstructor;
+import org.apache.skywalking.oap.server.core.Const;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * Evaluate composite rule using expression eval
+ *
+ * @since 8.2.0
+ */
+@AllArgsConstructor
+public class CompositeRuleEvaluate {
Review comment:
```suggestion
public class CompositeRuleEvaluator {
```
The class name should be `Evaluator`, method name should be `evaluate`. :)
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -93,8 +108,15 @@ rules:
count: 3
silence-period: 5
message: The request number of entity {name} non-200 status is more than expected.
+ only-as-condition: false
+composite-rules:
+ comp_rule:
+ # Must satisfied percent rule and resp time rule
+ expression: service_percent_rule && service_resp_time_percentile_rule
+ message: Service percent less than 80% and response time p50 > 1000
Review comment:
```suggestion
message: Service {name} successful rate is less than 80% and P50 of response time is over 1000ms
```
Is `{name}`available?
##########
File path: oap-server/server-alarm-plugin/src/test/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluateTest.java
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.ExpressionContext;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+
+public class CompositeRuleEvaluateTest {
+
+ private CompositeRuleEvaluate ruleEvaluate;
+
+ @Before
+ public void init() {
+ Expression expression = new Expression(new ExpressionContext());
+ ruleEvaluate = new CompositeRuleEvaluate(expression);
+ }
+
+ @Test
+ public void testEvaluateMessageWithAndOp() {
+ List<CompositeAlarmRule> compositeAlarmRules = new ArrayList<>();
+ CompositeAlarmRule compositeAlarmRule = new CompositeAlarmRule("dummy", "a_rule && b_rule", "composite rule triggered!");
+ compositeAlarmRules.add(compositeAlarmRule);
+ List<AlarmMessage> alarmMessages = getAlarmMessages();
+ List<AlarmMessage> compositeMsgs = ruleEvaluate.evaluate(compositeAlarmRules, alarmMessages);
+ assertThat(compositeMsgs.size(), is(1));
+ assertThat(compositeMsgs.get(0).getAlarmMessage(), is("composite rule triggered!"));
+ assertThat(compositeMsgs.get(0).getRuleName(), is("dummy"));
+ assertThat(compositeMsgs.get(0).getId0(), is("id0"));
+ assertThat(compositeMsgs.get(0).getId1(), is("id1"));
+ assertThat(compositeMsgs.get(0).isOnlyAsCondition(), is(false));
+ }
+
+ @Test
+ public void testEvaluateMessageWithNotExistsRule() {
+ List<CompositeAlarmRule> compositeAlarmRules = new ArrayList<>();
+ CompositeAlarmRule compositeAlarmRule = new CompositeAlarmRule("dummy", "a_rule && not_exist_rule", "composite rule triggered!");
+ compositeAlarmRules.add(compositeAlarmRule);
+ List<AlarmMessage> alarmMessages = getAlarmMessages();
+ List<AlarmMessage> compositeMsgs = ruleEvaluate.evaluate(compositeAlarmRules, alarmMessages);
Review comment:
Just for confirmation, at here, nothing will show up as log or exception, right? As `not_exist_rule` doesn't exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 161 -739
Lines 22172 3877 -18295
Branches 2123 438 -1685
============================================
- Hits 9354 0 -9354
+ Misses 12148 3877 -8271
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [733 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...3b4d467](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 182 -718
Lines 22172 4265 -17907
Branches 2123 487 -1636
============================================
- Hits 9354 0 -9354
+ Misses 12148 4265 -7883
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [713 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ebeb288](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `5.65%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 45.85% -5.66%
+ Complexity 3305 3032 -273
============================================
Files 883 903 +20
Lines 21854 22151 +297
Branches 2081 2110 +29
============================================
- Hits 11257 10157 -1100
- Misses 9687 11131 +1444
+ Partials 910 863 -47
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.04% <42.85%> (-2.86%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [126 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 177 -723
Lines 22172 4141 -18031
Branches 2123 469 -1654
============================================
- Hits 9354 0 -9354
+ Misses 12148 4141 -8007
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [717 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ec375e2](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499108139
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluate.java
##########
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableListMultimap;
+import com.google.common.collect.Multimaps;
+import lombok.AllArgsConstructor;
+import org.apache.skywalking.oap.server.core.Const;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * Evaluate composite rule using expression eval
+ *
+ * @since 8.2.0
+ */
+@AllArgsConstructor
+public class CompositeRuleEvaluate {
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `12.96%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.51% 38.54% -12.97%
+ Complexity 3305 2483 -822
=============================================
Files 883 896 +13
Lines 21854 22078 +224
Branches 2081 2104 +23
=============================================
- Hits 11257 8510 -2747
- Misses 9687 12946 +3259
+ Partials 910 622 -288
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-1.52%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [211 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `5.73%`.
> The diff coverage is `35.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 36.45% -5.74%
+ Complexity 2648 2352 -296
============================================
Files 900 899 -1
Lines 22172 22191 +19
Branches 2123 2112 -11
============================================
- Hits 9354 8090 -1264
- Misses 12148 13494 +1346
+ Partials 670 607 -63
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/CompositeRuleEvaluate.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-0.16%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [91 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 183 -717
Lines 22172 4277 -17895
Branches 2123 487 -1636
============================================
- Hits 9354 0 -9354
+ Misses 12148 4277 -7871
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [713 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...caa13c6](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499139832
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java
##########
@@ -49,93 +50,136 @@ public Rules readRules() {
Rules rules = new Rules();
if (Objects.nonNull(yamlData)) {
- Map rulesData = (Map) yamlData.get("rules");
- if (rulesData != null) {
- rules.setRules(new ArrayList<>());
- rulesData.forEach((k, v) -> {
- if (((String) k).endsWith("_rule")) {
- AlarmRule alarmRule = new AlarmRule();
- alarmRule.setAlarmRuleName((String) k);
- Map settings = (Map) v;
- Object metricsName = settings.get("metrics-name");
- if (metricsName == null) {
- throw new IllegalArgumentException("metrics-name can't be null");
- }
-
- alarmRule.setMetricsName((String) metricsName);
- alarmRule.setIncludeNames((ArrayList) settings.getOrDefault("include-names", new ArrayList(0)));
- alarmRule.setExcludeNames((ArrayList) settings.getOrDefault("exclude-names", new ArrayList(0)));
- alarmRule.setIncludeNamesRegex((String) settings.getOrDefault("include-names-regex", ""));
- alarmRule.setExcludeNamesRegex((String) settings.getOrDefault("exclude-names-regex", ""));
- alarmRule.setIncludeLabels(
- (ArrayList) settings.getOrDefault("include-labels", new ArrayList(0)));
- alarmRule.setExcludeLabels(
- (ArrayList) settings.getOrDefault("exclude-labels", new ArrayList(0)));
- alarmRule.setIncludeLabelsRegex((String) settings.getOrDefault("include-labels-regex", ""));
- alarmRule.setExcludeLabelsRegex((String) settings.getOrDefault("exclude-labels-regex", ""));
- alarmRule.setThreshold(settings.get("threshold").toString());
- alarmRule.setOp((String) settings.get("op"));
- alarmRule.setPeriod((Integer) settings.getOrDefault("period", 1));
- alarmRule.setCount((Integer) settings.getOrDefault("count", 1));
- // How many times of checks, the alarm keeps silence after alarm triggered, default as same as period.
- alarmRule.setSilencePeriod((Integer) settings.getOrDefault("silence-period", alarmRule.getPeriod()));
- alarmRule.setMessage(
- (String) settings.getOrDefault("message", "Alarm caused by Rule " + alarmRule
- .getAlarmRuleName()));
+ readRulesConfig(rules);
+ readWebHookConfig(rules);
+ readGrpcConfig(rules);
+ readSlackConfig(rules);
+ readWechatConfig(rules);
+ readCompositeRuleConfig(rules);
Review comment:
done
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluator.java
##########
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableListMultimap;
+import com.google.common.collect.Multimaps;
+import org.apache.skywalking.oap.server.core.Const;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.MetaInAlarm;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Evaluate composite rule using expression eval
+ *
+ * @since 8.2.0
+ */
+public class CompositeRuleEvaluator {
+
+ private Expression expression;
+ private Map<String, AlarmMessageFormatter> messageFormatterCache;
+
+ public CompositeRuleEvaluator(Expression expression) {
+ this.expression = expression;
+ this.messageFormatterCache = new ConcurrentHashMap<>();
+ }
+
+ /**
+ * Evaluate composite rule
+ *
+ * @param compositeAlarmRules compositeRules
+ * @param alarmMessages triggered alarm messages
+ * @return
+ */
+ public List<AlarmMessage> evaluate(List<CompositeAlarmRule> compositeAlarmRules, List<AlarmMessage> alarmMessages) {
+ final List<AlarmMessage> compositeRuleMessages = new ArrayList<>();
+ ImmutableListMultimap<String, AlarmMessage> messageMap = Multimaps.index(alarmMessages, alarmMessage ->
+ Joiner.on(Const.ID_CONNECTOR).useForNull(Const.EMPTY_STRING).join(alarmMessage.getId0(), alarmMessage.getId1()));
+ for (CompositeAlarmRule compositeAlarmRule : compositeAlarmRules) {
+ String expr = compositeAlarmRule.getExpression();
+ Set<String> dependencyRules = expression.analysisInputs(expr);
+ Map<String, Object> dataContext = new HashMap<>();
+ messageMap.asMap().forEach((key, alarmMessageList) -> {
+ dependencyRules.forEach(ruleName -> dataContext.put(ruleName, false));
+ alarmMessageList.forEach(alarmMessage -> {
+ if (dependencyRules.contains(alarmMessage.getRuleName())) {
+ dataContext.put(alarmMessage.getRuleName(), true);
+ }
+ });
+ Object matched = expression.eval(expr, dataContext);
+ if (matched instanceof Boolean && (Boolean) matched) {
+ AlarmMessage headMsg = alarmMessageList.iterator().next();
+ AlarmMessage message = new AlarmMessage();
+ message.setOnlyAsCondition(false);
+ message.setScopeId(headMsg.getScopeId());
+ message.setScope(headMsg.getScope());
+ message.setName(headMsg.getName());
+ message.setId0(headMsg.getId0());
+ message.setId1(headMsg.getId1());
+ message.setStartTime(System.currentTimeMillis());
+ message.setRuleName(compositeAlarmRule.getAlarmRuleName());
+ String alarmMessage = formatMessage(message, compositeAlarmRule.getMessage());
+ message.setAlarmMessage(alarmMessage);
+ compositeRuleMessages.add(message);
+ }
+ });
+ }
+ return compositeRuleMessages;
+ }
+
+ private String formatMessage(AlarmMessage alarmMessage, String message) {
+ return messageFormatterCache.computeIfAbsent(message, AlarmMessageFormatter::new).format(new MetaInAlarm() {
+ @Override
+ public String getScope() {
+ return null;
+ }
+
+ @Override
+ public int getScopeId() {
+ return alarmMessage.getScopeId();
+ }
+
+ @Override
+ public String getName() {
+ return alarmMessage.getName();
+ }
+
+ @Override
+ public String getMetricsName() {
+ return null;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `2.94%`.
> The diff coverage is `35.10%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 39.23% -2.95%
+ Complexity 2648 2498 -150
============================================
Files 900 904 +4
Lines 22172 22248 +76
Branches 2123 2127 +4
============================================
- Hits 9354 8730 -624
- Misses 12148 12888 +740
+ Partials 670 630 -40
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (+0.29%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [59 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...dca9216](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/bc64c6a12770031478d29e2f19004796584374c9?el=desc) will **increase** coverage by `0.39%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 52.13% 52.53% +0.39%
- Complexity 3361 3365 +4
============================================
Files 901 893 -8
Lines 22195 22063 -132
Branches 2124 2096 -28
============================================
+ Hits 11572 11591 +19
+ Misses 9695 9542 -153
- Partials 928 930 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `47.53% <42.85%> (+0.26%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [29 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [bc64c6a...b5adde1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `1.92%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 49.58% -1.93%
+ Complexity 3305 3192 -113
============================================
Files 883 902 +19
Lines 21854 22171 +317
Branches 2081 2107 +26
============================================
- Hits 11257 10993 -264
- Misses 9687 10278 +591
+ Partials 910 900 -10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (-0.62%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [87 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/772f1d2e82aa97e47d0e04f81dc822f35e3e0d02?el=desc) will **increase** coverage by `0.73%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 51.80% 52.53% +0.73%
- Complexity 3363 3365 +2
============================================
Files 1606 893 -713
Lines 34102 22063 -12039
Branches 3710 2096 -1614
============================================
- Hits 17666 11591 -6075
+ Misses 15581 9542 -6039
- Partials 855 930 +75
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-66.67%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `47.53% <42.85%> (-9.87%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-19.39%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (-28.44%)` | `7.00 <1.00> (+1.00)` | :arrow_down: |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1108 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [772f1d2...4553cb1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `5.73%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 45.77% -5.74%
+ Complexity 3305 3030 -275
============================================
Files 883 903 +20
Lines 21854 22151 +297
Branches 2081 2110 +29
============================================
- Hits 11257 10140 -1117
- Misses 9687 11148 +1461
+ Partials 910 863 -47
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.04% <42.85%> (-2.86%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [127 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 169 -731
Lines 22172 4029 -18143
Branches 2123 465 -1658
============================================
- Hits 9354 0 -9354
+ Misses 12148 4029 -8119
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [725 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `9.21%`.
> The diff coverage is `35.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 32.97% -9.22%
+ Complexity 2648 2140 -508
============================================
Files 900 887 -13
Lines 22172 21747 -425
Branches 2123 2079 -44
============================================
- Hits 9354 7171 -2183
- Misses 12148 14046 +1898
+ Partials 670 530 -140
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-0.61%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [135 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...caa13c6](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 173 -727
Lines 22172 4093 -18079
Branches 2123 465 -1658
============================================
- Hits 9354 0 -9354
+ Misses 12148 4093 -8055
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [721 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `4.43%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 47.07% -4.44%
+ Complexity 3305 3100 -205
============================================
Files 883 902 +19
Lines 21854 22161 +307
Branches 2081 2106 +25
============================================
- Hits 11257 10433 -824
- Misses 9687 10854 +1167
+ Partials 910 874 -36
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.84% <42.85%> (-1.07%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [111 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `6.50%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 45.00% -6.51%
+ Complexity 3305 2992 -313
============================================
Files 883 902 +19
Lines 21854 22116 +262
Branches 2081 2105 +24
============================================
- Hits 11257 9953 -1304
- Misses 9687 11316 +1629
+ Partials 910 847 -63
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `42.60% <42.85%> (-3.31%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [138 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 182 -718
Lines 22172 4273 -17899
Branches 2123 487 -1636
============================================
- Hits 9354 0 -9354
+ Misses 12148 4273 -7875
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [712 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...dca9216](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `7.38%`.
> The diff coverage is `35.10%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 49.57% +7.38%
- Complexity 2648 3221 +573
============================================
Files 900 904 +4
Lines 22172 22248 +76
Branches 2123 2127 +4
============================================
+ Hits 9354 11029 +1675
+ Misses 12148 10318 -1830
- Partials 670 901 +231
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `47.08% <42.85%> (+2.08%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [191 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...dca9216](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499151361
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/expression/Expression.java
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.expression;
+
+import lombok.extern.slf4j.Slf4j;
+import org.mvel2.MVEL;
+import org.mvel2.ParserContext;
+
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Expression support eval java basic expressions, just like groovy script
+ * The internal detail is it first compile the expression to a pareTree then execute the parseTree with data
+ * It caches the compiled expression for sake of performance
+ */
+@Slf4j
+public class Expression {
+ private Map<String, Object> expressionCache;
+ private ExpressionContext context;
+
+ public Expression(ExpressionContext context) {
+ this.context = context;
+ this.expressionCache = new ConcurrentHashMap<>();
+ }
+
+ /**
+ * Eval the given expression using empty data context
+ */
+ public Object eval(String expression) {
+ return eval(expression, null);
+ }
+
+ /**
+ * Eval the given expression with data context
+ */
+ public Object eval(String expression, Map<String, Object> vars) {
+ try {
+ Object obj = compile(expression, context);
+ return MVEL.executeExpression(obj, vars);
+ } catch (Throwable e) {
+ log.error("eval expression {} error", expression, e);
+ return null;
+ }
+ }
+
+ /**
+ * Compile the given expression to a parseTree
+ */
+ public Object compile(String expression, ExpressionContext pctx) {
+ Object o = expressionCache.get(expression);
+ if (o == null) {
+ o = MVEL.compileExpression(expression, pctx.getContext());
+ expressionCache.put(expression, o);
+ }
+ return o;
Review comment:
@wu-sheng I didn't check the real case, but since @xbkaishui he is using `ConcurrentHashMap`, if there is no such case, a simple `HashMap` is enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 160 -740
Lines 22172 3858 -18314
Branches 2123 445 -1678
============================================
- Hits 9354 0 -9354
+ Misses 12148 3858 -8290
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [735 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ec375e2](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 182 -718
Lines 22172 4273 -17899
Branches 2123 487 -1636
============================================
- Hits 9354 0 -9354
+ Misses 12148 4273 -7875
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [712 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...3b4d467](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **increase** coverage by `0.36%`.
> The diff coverage is `36.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 51.51% 51.87% +0.36%
- Complexity 3305 3360 +55
============================================
Files 883 904 +21
Lines 21854 22300 +446
Branches 2081 2133 +52
============================================
+ Hits 11257 11569 +312
- Misses 9687 9801 +114
- Partials 910 930 +20
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (-0.62%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [55 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...ba927b1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/772f1d2e82aa97e47d0e04f81dc822f35e3e0d02?el=desc) will **decrease** coverage by `22.17%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.80% 29.62% -22.18%
+ Complexity 3363 1907 -1456
=============================================
Files 1606 868 -738
Lines 34102 21349 -12753
Branches 3710 2047 -1663
=============================================
- Hits 17666 6325 -11341
+ Misses 15581 14546 -1035
+ Partials 855 478 -377
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-66.67%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `71.87% <28.57%> (-13.84%)` | `9.00 <2.00> (-1.00)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `39.91% <42.85%> (-17.49%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-19.39%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (-28.44%)` | `7.00 <1.00> (+1.00)` | :arrow_down: |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1239 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [772f1d2...4553cb1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `7.92%`.
> The diff coverage is `36.06%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 34.26% -7.93%
+ Complexity 2648 2274 -374
============================================
Files 900 904 +4
Lines 22172 22225 +53
Branches 2123 2125 +2
============================================
- Hits 9354 7615 -1739
- Misses 12148 14040 +1892
+ Partials 670 570 -100
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `31.25% <31.25%> (ø)` | `2.00 <2.00> (?)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-0.61%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [124 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ec375e2](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r498587634
##########
File path: oap-server/server-alarm-plugin/src/test/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluatorTest.java
##########
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.ExpressionContext;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+
+public class CompositeRuleEvaluatorTest {
+
+ private CompositeRuleEvaluator ruleEvaluator;
+
+ @Before
+ public void init() {
+ Expression expression = new Expression(new ExpressionContext());
+ ruleEvaluator = new CompositeRuleEvaluator(expression);
+ }
+
+ @Test
+ public void testEvaluatorMessageWithAndOp() {
+ List<CompositeAlarmRule> compositeAlarmRules = new ArrayList<>();
+ CompositeAlarmRule compositeAlarmRule = new CompositeAlarmRule("dummy", "a_rule && b_rule", "composite rule triggered!");
+ compositeAlarmRules.add(compositeAlarmRule);
+ List<AlarmMessage> alarmMessages = getAlarmMessages();
+ List<AlarmMessage> compositeMsgs = ruleEvaluator.evaluator(compositeAlarmRules, alarmMessages);
+ assertThat(compositeMsgs.size(), is(1));
+ assertThat(compositeMsgs.get(0).getAlarmMessage(), is("composite rule triggered!"));
+ assertThat(compositeMsgs.get(0).getRuleName(), is("dummy"));
+ }
+
+ @Test
+ public void testEvaluatorMessageWithNotExistsRule() {
+ List<CompositeAlarmRule> compositeAlarmRules = new ArrayList<>();
+ CompositeAlarmRule compositeAlarmRule = new CompositeAlarmRule("dummy", "a_rule && not_exist_rule", "composite rule triggered!");
+ compositeAlarmRules.add(compositeAlarmRule);
+ List<AlarmMessage> alarmMessages = getAlarmMessages();
+ List<AlarmMessage> compositeMsgs = ruleEvaluator.evaluator(compositeAlarmRules, alarmMessages);
+ assertThat(compositeMsgs.size(), is(0));
+ }
+
+ @Test
+ public void testEvaluatorMessageWithException() {
+ List<CompositeAlarmRule> compositeAlarmRules = new ArrayList<>();
+ CompositeAlarmRule compositeAlarmRule = new CompositeAlarmRule("dummy", "a_rule + b_rule", "composite rule triggered!");
+ compositeAlarmRules.add(compositeAlarmRule);
+ List<AlarmMessage> alarmMessages = getAlarmMessages();
+ List<AlarmMessage> compositeMsgs = ruleEvaluator.evaluator(compositeAlarmRules, alarmMessages);
+ assertThat(compositeMsgs.size(), is(0));
+ }
+
+ private List<AlarmMessage> getAlarmMessages() {
+ List<AlarmMessage> alarmMessages = new ArrayList<>();
+ AlarmMessage alarmMessage = new AlarmMessage();
+ alarmMessage.setRuleName("a_rule");
+ alarmMessage.setOnlyAsCondition(true);
+ alarmMessage.setId0("11");
+ alarmMessage.setName("");
+ alarmMessage.setScope("");
+ alarmMessage.setScopeId(1);
+ alarmMessages.add(alarmMessage);
+ alarmMessage = new AlarmMessage();
+ alarmMessage.setRuleName("b_rule");
+ alarmMessage.setOnlyAsCondition(true);
+ alarmMessage.setId0("11");
+ alarmMessage.setName("");
+ alarmMessage.setScope("");
+ alarmMessage.setScopeId(1);
+ alarmMessages.add(alarmMessage);
+ return alarmMessages;
+ }
+
+ @Test
+ public void testEvaluatorMessageWithOrOp() {
+ List<CompositeAlarmRule> compositeAlarmRules = new ArrayList<>();
+ CompositeAlarmRule compositeAlarmRule = new CompositeAlarmRule("dummy", "a_rule || b_rule", "composite rule triggered!");
+ compositeAlarmRules.add(compositeAlarmRule);
+ List<AlarmMessage> alarmMessages = getAlarmMessages();
+ alarmMessages.remove(0);
+ List<AlarmMessage> compositeMsgs = ruleEvaluator.evaluator(compositeAlarmRules, alarmMessages);
Review comment:
Does the AlarmMessage include the id0/id1/name? Please verify those.
##########
File path: oap-server/server-alarm-plugin/src/test/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluatorTest.java
##########
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.ExpressionContext;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+
+public class CompositeRuleEvaluatorTest {
+
+ private CompositeRuleEvaluator ruleEvaluator;
+
+ @Before
+ public void init() {
+ Expression expression = new Expression(new ExpressionContext());
+ ruleEvaluator = new CompositeRuleEvaluator(expression);
+ }
+
+ @Test
+ public void testEvaluatorMessageWithAndOp() {
+ List<CompositeAlarmRule> compositeAlarmRules = new ArrayList<>();
+ CompositeAlarmRule compositeAlarmRule = new CompositeAlarmRule("dummy", "a_rule && b_rule", "composite rule triggered!");
+ compositeAlarmRules.add(compositeAlarmRule);
+ List<AlarmMessage> alarmMessages = getAlarmMessages();
+ List<AlarmMessage> compositeMsgs = ruleEvaluator.evaluator(compositeAlarmRules, alarmMessages);
+ assertThat(compositeMsgs.size(), is(1));
+ assertThat(compositeMsgs.get(0).getAlarmMessage(), is("composite rule triggered!"));
+ assertThat(compositeMsgs.get(0).getRuleName(), is("dummy"));
+ }
+
+ @Test
+ public void testEvaluatorMessageWithNotExistsRule() {
+ List<CompositeAlarmRule> compositeAlarmRules = new ArrayList<>();
+ CompositeAlarmRule compositeAlarmRule = new CompositeAlarmRule("dummy", "a_rule && not_exist_rule", "composite rule triggered!");
+ compositeAlarmRules.add(compositeAlarmRule);
+ List<AlarmMessage> alarmMessages = getAlarmMessages();
+ List<AlarmMessage> compositeMsgs = ruleEvaluator.evaluator(compositeAlarmRules, alarmMessages);
+ assertThat(compositeMsgs.size(), is(0));
+ }
+
+ @Test
+ public void testEvaluatorMessageWithException() {
+ List<CompositeAlarmRule> compositeAlarmRules = new ArrayList<>();
+ CompositeAlarmRule compositeAlarmRule = new CompositeAlarmRule("dummy", "a_rule + b_rule", "composite rule triggered!");
+ compositeAlarmRules.add(compositeAlarmRule);
+ List<AlarmMessage> alarmMessages = getAlarmMessages();
+ List<AlarmMessage> compositeMsgs = ruleEvaluator.evaluator(compositeAlarmRules, alarmMessages);
+ assertThat(compositeMsgs.size(), is(0));
Review comment:
Do we have the chance to log or raise the exception when exceptions happen?
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluator.java
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableListMultimap;
+import com.google.common.collect.Multimaps;
+import lombok.AllArgsConstructor;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * Evaluator composite rule using expression eval
+ *
+ * @since 8.2.0
+ */
+@AllArgsConstructor
+public class CompositeRuleEvaluator {
+
+ private Expression expression;
+
+ /**
+ * Evaluator composite rule
+ *
+ * @param compositeAlarmRules compositeRules
+ * @param alarmMessages triggered alarm messages
+ * @return
+ */
+ public List<AlarmMessage> evaluator(List<CompositeAlarmRule> compositeAlarmRules, List<AlarmMessage> alarmMessages) {
+ final List<AlarmMessage> compositeRuleMessages = new ArrayList<>();
+ ImmutableListMultimap<String, AlarmMessage> messageMap = Multimaps.index(alarmMessages, alarmMessage -> Joiner.on("_").useForNull("").join(alarmMessage.getId0(), alarmMessage.getId1()));
+ for (CompositeAlarmRule compositeAlarmRule : compositeAlarmRules) {
+ String expr = compositeAlarmRule.getExpression();
+ Set<String> dependencyRules = expression.analysisInputs(expr);
+ Map<String, Object> dataContext = new HashMap<>();
+ messageMap.asMap().forEach((key, alarmMessageList) -> {
+ Set<String> allRuleNames = new HashSet<>(dependencyRules);
+ alarmMessageList.forEach(alarmMessage -> {
+ if (allRuleNames.remove(alarmMessage.getRuleName())) {
Review comment:
What does this remove mean?
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluator.java
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableListMultimap;
+import com.google.common.collect.Multimaps;
+import lombok.AllArgsConstructor;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * Evaluator composite rule using expression eval
+ *
+ * @since 8.2.0
+ */
+@AllArgsConstructor
+public class CompositeRuleEvaluator {
+
+ private Expression expression;
+
+ /**
+ * Evaluator composite rule
+ *
+ * @param compositeAlarmRules compositeRules
+ * @param alarmMessages triggered alarm messages
+ * @return
+ */
+ public List<AlarmMessage> evaluator(List<CompositeAlarmRule> compositeAlarmRules, List<AlarmMessage> alarmMessages) {
+ final List<AlarmMessage> compositeRuleMessages = new ArrayList<>();
+ ImmutableListMultimap<String, AlarmMessage> messageMap = Multimaps.index(alarmMessages, alarmMessage -> Joiner.on("_").useForNull("").join(alarmMessage.getId0(), alarmMessage.getId1()));
Review comment:
`Const#ID_CONNECTOR` is `_`.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluator.java
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableListMultimap;
+import com.google.common.collect.Multimaps;
+import lombok.AllArgsConstructor;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * Evaluator composite rule using expression eval
+ *
+ * @since 8.2.0
+ */
+@AllArgsConstructor
+public class CompositeRuleEvaluator {
+
+ private Expression expression;
+
+ /**
+ * Evaluator composite rule
+ *
+ * @param compositeAlarmRules compositeRules
+ * @param alarmMessages triggered alarm messages
+ * @return
+ */
+ public List<AlarmMessage> evaluator(List<CompositeAlarmRule> compositeAlarmRules, List<AlarmMessage> alarmMessages) {
+ final List<AlarmMessage> compositeRuleMessages = new ArrayList<>();
+ ImmutableListMultimap<String, AlarmMessage> messageMap = Multimaps.index(alarmMessages, alarmMessage -> Joiner.on("_").useForNull("").join(alarmMessage.getId0(), alarmMessage.getId1()));
+ for (CompositeAlarmRule compositeAlarmRule : compositeAlarmRules) {
+ String expr = compositeAlarmRule.getExpression();
+ Set<String> dependencyRules = expression.analysisInputs(expr);
+ Map<String, Object> dataContext = new HashMap<>();
+ messageMap.asMap().forEach((key, alarmMessageList) -> {
+ Set<String> allRuleNames = new HashSet<>(dependencyRules);
+ alarmMessageList.forEach(alarmMessage -> {
+ if (allRuleNames.remove(alarmMessage.getRuleName())) {
+ dataContext.put(alarmMessage.getRuleName(), true);
+ }
+ });
+ allRuleNames.forEach(ruleName -> {
+ dataContext.put(ruleName, false);
+ });
+ Object matched = expression.eval(expr, dataContext);
+ if (matched instanceof Boolean && (Boolean) matched) {
+ AlarmMessage headMsg = alarmMessageList.iterator().next();
+ AlarmMessage message = new AlarmMessage();
+ message.setOnlyAsCondition(false);
+ message.setScopeId(headMsg.getScopeId());
+ message.setScope(headMsg.getScope());
+ message.setName(headMsg.getName());
+ message.setId0(headMsg.getId0());
+ message.setId1(headMsg.getId1());
Review comment:
As these supported, I think name and id0/id1 are available in the message. Could you update the doc?
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/CompositeRuleEvaluator.java
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableListMultimap;
+import com.google.common.collect.Multimaps;
+import lombok.AllArgsConstructor;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.expression.Expression;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * Evaluator composite rule using expression eval
+ *
+ * @since 8.2.0
+ */
+@AllArgsConstructor
+public class CompositeRuleEvaluator {
+
+ private Expression expression;
+
+ /**
+ * Evaluator composite rule
+ *
+ * @param compositeAlarmRules compositeRules
+ * @param alarmMessages triggered alarm messages
+ * @return
+ */
+ public List<AlarmMessage> evaluator(List<CompositeAlarmRule> compositeAlarmRules, List<AlarmMessage> alarmMessages) {
Review comment:
The coverage reports many lines are not covered, please recheck, as this method is super important for this feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/772f1d2e82aa97e47d0e04f81dc822f35e3e0d02?el=desc) will **increase** coverage by `0.98%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 51.80% 52.78% +0.98%
- Complexity 3363 3369 +6
============================================
Files 1606 886 -720
Lines 34102 21972 -12130
Branches 3710 2105 -1605
============================================
- Hits 17666 11599 -6067
+ Misses 15581 9443 -6138
- Partials 855 930 +75
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-66.67%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.73% <42.85%> (-11.66%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-19.39%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (-28.44%)` | `7.00 <1.00> (+1.00)` | :arrow_down: |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1109 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [772f1d2...4553cb1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `11.10%`.
> The diff coverage is `35.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 42.18% 31.08% -11.11%
+ Complexity 2648 2035 -613
=============================================
Files 900 887 -13
Lines 22172 21751 -421
Branches 2123 2070 -53
=============================================
- Hits 9354 6761 -2593
- Misses 12148 14494 +2346
+ Partials 670 496 -174
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `42.60% <42.85%> (-2.40%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [145 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ebeb288](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `28.19%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.51% 23.31% -28.20%
+ Complexity 3305 1629 -1676
=============================================
Files 883 895 +12
Lines 21854 21817 -37
Branches 2081 2067 -14
=============================================
- Hits 11257 5087 -6170
- Misses 9687 16372 +6685
+ Partials 910 358 -552
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `34.52% <42.85%> (-11.38%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [392 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 180 -720
Lines 22172 4267 -17905
Branches 2123 487 -1636
============================================
- Hits 9354 0 -9354
+ Misses 12148 4267 -7881
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [714 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...3b4d467](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `10.05%`.
> The diff coverage is `36.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.51% 41.45% -10.06%
+ Complexity 3305 2609 -696
=============================================
Files 883 904 +21
Lines 21854 22300 +446
Branches 2081 2133 +52
=============================================
- Hits 11257 9245 -2012
- Misses 9687 12383 +2696
+ Partials 910 672 -238
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (-0.62%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [206 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...ba927b1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `12.32%`.
> The diff coverage is `35.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 42.18% 29.86% -12.33%
+ Complexity 2648 1947 -701
=============================================
Files 900 880 -20
Lines 22172 21636 -536
Branches 2123 2063 -60
=============================================
- Hits 9354 6462 -2892
- Misses 12148 14691 +2543
+ Partials 670 483 -187
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/CompositeRuleEvaluate.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `39.91% <42.85%> (-5.09%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [175 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499141711
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -41,10 +43,19 @@ Such as in **percentile**, `value1` is threshold of P50, and `-, -, value3, valu
backend deployment env time.
- **Count**. In the period window, if the number of **value**s over threshold(by OP), reaches count, alarm
should send.
+- **Only as condition**. Specify if the rule can send notification or just as an condition of composite rule.
- **Silence period**. After alarm is triggered in Time-N, then keep silence in the **TN -> TN + period**.
By default, it is as same as **Period**, which means in a period, same alarm(same ID in same
metrics name) will be trigger once.
+### Composite rules
+**NOTE**. Composite rules only work for alarm rules targeting the same entity level, such as alarm rules of the service level.
+For example, `service_percent_rule && service_resp_time_percentile_rule`. You shouldn't compose alarm rules of different entities,
Review comment:
> Yes, I knew that, is it better to support different entities?
I am wondering what is the case of that. I was making the words accurate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 167 -733
Lines 22172 4016 -18156
Branches 2123 457 -1666
============================================
- Hits 9354 0 -9354
+ Misses 12148 4016 -8132
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [727 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 161 -739
Lines 22172 3857 -18315
Branches 2123 442 -1681
============================================
- Hits 9354 0 -9354
+ Misses 12148 3857 -8291
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [733 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...caa13c6](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `9.31%`.
> The diff coverage is `35.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 32.86% -9.32%
+ Complexity 2648 2131 -517
============================================
Files 900 887 -13
Lines 22172 21747 -425
Branches 2123 2079 -44
============================================
- Hits 9354 7148 -2206
- Misses 12148 14069 +1921
+ Partials 670 530 -140
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-0.61%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [140 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...caa13c6](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `8.06%`.
> The diff coverage is `35.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 34.12% -8.07%
+ Complexity 2648 2277 -371
============================================
Files 900 904 +4
Lines 22172 22207 +35
Branches 2123 2126 +3
============================================
- Hits 9354 7578 -1776
- Misses 12148 14054 +1906
+ Partials 670 575 -95
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/CompositeRuleEvaluate.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.94% <42.85%> (-1.06%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [124 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 178 -722
Lines 22172 4135 -18037
Branches 2123 475 -1648
============================================
- Hits 9354 0 -9354
+ Misses 12148 4135 -8013
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [716 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4f3264c](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `5.32%`.
> The diff coverage is `35.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 47.50% +5.32%
- Complexity 2648 3118 +470
============================================
Files 900 887 -13
Lines 22172 21781 -391
Branches 2123 2085 -38
============================================
+ Hits 9354 10348 +994
+ Misses 12148 10573 -1575
- Partials 670 860 +190
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-0.61%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [216 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...3b4d467](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `8.36%`.
> The diff coverage is `35.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 33.81% -8.37%
+ Complexity 2648 2210 -438
============================================
Files 900 897 -3
Lines 22172 22180 +8
Branches 2123 2112 -11
============================================
- Hits 9354 7501 -1853
- Misses 12148 14122 +1974
+ Partials 670 557 -113
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/CompositeRuleEvaluate.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.94% <42.85%> (-1.06%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [117 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499108109
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -93,8 +108,15 @@ rules:
count: 3
silence-period: 5
message: The request number of entity {name} non-200 status is more than expected.
+ only-as-condition: false
+composite-rules:
+ comp_rule:
+ # Must satisfied percent rule and resp time rule
+ expression: service_percent_rule && service_resp_time_percentile_rule
+ message: Service percent less than 80% and response time p50 > 1000
Review comment:
Currently, it will not support message format, will add it later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **increase** coverage by `0.88%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 51.51% 52.39% +0.88%
- Complexity 3305 3368 +63
============================================
Files 883 896 +13
Lines 21854 22128 +274
Branches 2081 2106 +25
============================================
+ Hits 11257 11595 +338
+ Misses 9687 9604 -83
- Partials 910 929 +19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (-0.62%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [31 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499151361
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/expression/Expression.java
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.expression;
+
+import lombok.extern.slf4j.Slf4j;
+import org.mvel2.MVEL;
+import org.mvel2.ParserContext;
+
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Expression support eval java basic expressions, just like groovy script
+ * The internal detail is it first compile the expression to a pareTree then execute the parseTree with data
+ * It caches the compiled expression for sake of performance
+ */
+@Slf4j
+public class Expression {
+ private Map<String, Object> expressionCache;
+ private ExpressionContext context;
+
+ public Expression(ExpressionContext context) {
+ this.context = context;
+ this.expressionCache = new ConcurrentHashMap<>();
+ }
+
+ /**
+ * Eval the given expression using empty data context
+ */
+ public Object eval(String expression) {
+ return eval(expression, null);
+ }
+
+ /**
+ * Eval the given expression with data context
+ */
+ public Object eval(String expression, Map<String, Object> vars) {
+ try {
+ Object obj = compile(expression, context);
+ return MVEL.executeExpression(obj, vars);
+ } catch (Throwable e) {
+ log.error("eval expression {} error", expression, e);
+ return null;
+ }
+ }
+
+ /**
+ * Compile the given expression to a parseTree
+ */
+ public Object compile(String expression, ExpressionContext pctx) {
+ Object o = expressionCache.get(expression);
+ if (o == null) {
+ o = MVEL.compileExpression(expression, pctx.getContext());
+ expressionCache.put(expression, o);
+ }
+ return o;
Review comment:
@wu-sheng I didn't check the real case, but since @xbkaishui he is using `ConcurrentHashMap` (so I assume that there is concurrency), if there is no such case, a simple `HashMap` is enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `6.49%`.
> The diff coverage is `35.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 35.69% -6.50%
+ Complexity 2648 2305 -343
============================================
Files 900 887 -13
Lines 22172 21753 -419
Branches 2123 2080 -43
============================================
- Hits 9354 7765 -1589
- Misses 12148 13411 +1263
+ Partials 670 577 -93
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-0.61%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [113 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...caa13c6](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/772f1d2e82aa97e47d0e04f81dc822f35e3e0d02?el=desc) will **increase** coverage by `0.89%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 51.80% 52.69% +0.89%
+ Complexity 3363 3361 -2
============================================
Files 1606 886 -720
Lines 34102 21972 -12130
Branches 3710 2105 -1605
============================================
- Hits 17666 11578 -6088
+ Misses 15581 9464 -6117
- Partials 855 930 +75
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-66.67%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.73% <42.85%> (-11.66%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-19.39%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (-28.44%)` | `7.00 <1.00> (+1.00)` | :arrow_down: |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1108 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [772f1d2...4553cb1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `9.41%`.
> The diff coverage is `35.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 32.76% -9.42%
+ Complexity 2648 2138 -510
============================================
Files 900 887 -13
Lines 22172 21722 -450
Branches 2123 2079 -44
============================================
- Hits 9354 7118 -2236
- Misses 12148 14062 +1914
+ Partials 670 542 -128
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/CompositeRuleEvaluate.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.94% <42.85%> (-1.06%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [147 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499137005
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/expression/Expression.java
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.expression;
+
+import lombok.extern.slf4j.Slf4j;
+import org.mvel2.MVEL;
+import org.mvel2.ParserContext;
+
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+@Slf4j
+public class Expression {
+ private Map<String, Object> expressionCache;
+ private ExpressionContext context;
+
+ public Expression(ExpressionContext context) {
+ this.context = context;
+ this.expressionCache = new ConcurrentHashMap<>();
+ }
+
+ public Object eval(String expression) {
+ return eval(expression, null);
+ }
+
+ public Object eval(String expression, Map<String, Object> vars) {
+ Object obj = compile(expression, context);
+ try {
+ return MVEL.executeExpression(obj, vars);
+ } catch (Throwable e) {
+ log.error("eval expression {} error", expression, e);
+ return null;
+ }
+ }
+
+ public Object compile(String expression, ExpressionContext pctx) {
+ Object o = expressionCache.get(expression);
+ if (o == null) {
+ o = MVEL.compileExpression(expression, pctx.getContext());
Review comment:
Yes, If the expression is invalid, it will throws an runtime exception named CompileException, for example a && * b
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 178 -722
Lines 22172 4135 -18037
Branches 2123 475 -1648
============================================
- Hits 9354 0 -9354
+ Misses 12148 4135 -8013
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [716 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `1.21%`.
> The diff coverage is `36.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 50.29% -1.22%
+ Complexity 3305 3276 -29
============================================
Files 883 904 +21
Lines 21854 22300 +446
Branches 2081 2133 +52
============================================
- Hits 11257 11216 -41
- Misses 9687 10175 +488
+ Partials 910 909 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (-0.62%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [85 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...ba927b1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 183 -717
Lines 22172 4277 -17895
Branches 2123 487 -1636
============================================
- Hits 9354 0 -9354
+ Misses 12148 4277 -7871
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [713 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ec375e2](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 166 -734
Lines 22172 4015 -18157
Branches 2123 463 -1660
============================================
- Hits 9354 0 -9354
+ Misses 12148 4015 -8133
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [728 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4f3264c](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 174 -726
Lines 22172 4118 -18054
Branches 2123 475 -1648
============================================
- Hits 9354 0 -9354
+ Misses 12148 4118 -8030
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [720 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **increase** coverage by `7.65%`.
> The diff coverage is `36.06%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
+ Coverage 42.18% 49.83% +7.65%
- Complexity 2648 3263 +615
============================================
Files 900 904 +4
Lines 22172 22278 +106
Branches 2123 2127 +4
============================================
+ Hits 9354 11103 +1749
+ Misses 12148 10271 -1877
- Partials 670 904 +234
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <9.52%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `31.25% <31.25%> (ø)` | `2.00 <2.00> (?)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.29% <42.85%> (+0.29%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.91%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [184 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ec375e2](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 178 -722
Lines 22172 4256 -17916
Branches 2123 487 -1636
============================================
- Hits 9354 0 -9354
+ Misses 12148 4256 -7892
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [716 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...3b4d467](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499136603
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -41,10 +43,19 @@ Such as in **percentile**, `value1` is threshold of P50, and `-, -, value3, valu
backend deployment env time.
- **Count**. In the period window, if the number of **value**s over threshold(by OP), reaches count, alarm
should send.
+- **Only as condition**. Specify if the rule can send notification or just as an condition of composite rule.
- **Silence period**. After alarm is triggered in Time-N, then keep silence in the **TN -> TN + period**.
By default, it is as same as **Period**, which means in a period, same alarm(same ID in same
metrics name) will be trigger once.
+### Composite rules
+**NOTE**. Composite rules only work for alarm rules targeting the same entity level, such as alarm rules of the service level.
+For example, `service_percent_rule && service_resp_time_percentile_rule`. You shouldn't compose alarm rules of different entities,
Review comment:
Yes, I knew that, is it better to support different entities?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 173 -727
Lines 22172 4108 -18064
Branches 2123 475 -1648
============================================
- Hits 9354 0 -9354
+ Misses 12148 4108 -8040
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [721 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ebeb288](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 181 -719
Lines 22172 4249 -17923
Branches 2123 483 -1640
============================================
- Hits 9354 0 -9354
+ Misses 12148 4249 -7899
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [714 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...caa13c6](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `5.95%`.
> The diff coverage is `35.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 36.23% -5.96%
+ Complexity 2648 2377 -271
============================================
Files 900 904 +4
Lines 22172 22238 +66
Branches 2123 2131 +8
============================================
- Hits 9354 8058 -1296
- Misses 12148 13593 +1445
+ Partials 670 587 -83
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/CompositeRuleEvaluate.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.94% <42.85%> (-1.06%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [94 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499101667
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java
##########
@@ -49,93 +50,136 @@ public Rules readRules() {
Rules rules = new Rules();
if (Objects.nonNull(yamlData)) {
- Map rulesData = (Map) yamlData.get("rules");
- if (rulesData != null) {
- rules.setRules(new ArrayList<>());
- rulesData.forEach((k, v) -> {
- if (((String) k).endsWith("_rule")) {
- AlarmRule alarmRule = new AlarmRule();
- alarmRule.setAlarmRuleName((String) k);
- Map settings = (Map) v;
- Object metricsName = settings.get("metrics-name");
- if (metricsName == null) {
- throw new IllegalArgumentException("metrics-name can't be null");
- }
-
- alarmRule.setMetricsName((String) metricsName);
- alarmRule.setIncludeNames((ArrayList) settings.getOrDefault("include-names", new ArrayList(0)));
- alarmRule.setExcludeNames((ArrayList) settings.getOrDefault("exclude-names", new ArrayList(0)));
- alarmRule.setIncludeNamesRegex((String) settings.getOrDefault("include-names-regex", ""));
- alarmRule.setExcludeNamesRegex((String) settings.getOrDefault("exclude-names-regex", ""));
- alarmRule.setIncludeLabels(
- (ArrayList) settings.getOrDefault("include-labels", new ArrayList(0)));
- alarmRule.setExcludeLabels(
- (ArrayList) settings.getOrDefault("exclude-labels", new ArrayList(0)));
- alarmRule.setIncludeLabelsRegex((String) settings.getOrDefault("include-labels-regex", ""));
- alarmRule.setExcludeLabelsRegex((String) settings.getOrDefault("exclude-labels-regex", ""));
- alarmRule.setThreshold(settings.get("threshold").toString());
- alarmRule.setOp((String) settings.get("op"));
- alarmRule.setPeriod((Integer) settings.getOrDefault("period", 1));
- alarmRule.setCount((Integer) settings.getOrDefault("count", 1));
- // How many times of checks, the alarm keeps silence after alarm triggered, default as same as period.
- alarmRule.setSilencePeriod((Integer) settings.getOrDefault("silence-period", alarmRule.getPeriod()));
- alarmRule.setMessage(
- (String) settings.getOrDefault("message", "Alarm caused by Rule " + alarmRule
- .getAlarmRuleName()));
+ readRulesConfig(rules);
+ readCompositeRuleConfig(rules);
+ readWebHookConfig(rules);
+ readGrpcConfig(rules);
+ readSlackConfig(rules);
+ readWechatConfig(rules);
+ }
+ return rules;
+ }
- rules.getRules().add(alarmRule);
- }
- });
- }
- List webhooks = (List) yamlData.get("webhooks");
- if (webhooks != null) {
- rules.setWebhooks(new ArrayList<>());
- webhooks.forEach(url -> {
- rules.getWebhooks().add((String) url);
- });
+ private void readCompositeRuleConfig(Rules rules) {
+ Map compositeRulesData = (Map) yamlData.get("composite-rules");
+ if (compositeRulesData == null) {
+ return;
+ }
+ compositeRulesData.forEach((k, v) -> {
+ String ruleName = (String) k;
+ if (ruleName.endsWith("_rule")) {
+ Map settings = (Map) v;
+ CompositeAlarmRule compositeAlarmRule = new CompositeAlarmRule();
+ compositeAlarmRule.setAlarmRuleName(ruleName);
+ String expression = (String) settings.get("expression");
+ if (expression == null) {
+ throw new IllegalArgumentException("expression can't be null");
Review comment:
I didn't mean anything should be changed, I was just rechecking the status. It is good enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `51.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 51.51% 0.00% -51.52%
============================================
Files 883 169 -714
Lines 21854 4012 -17842
Branches 2081 463 -1618
============================================
- Hits 11257 0 -11257
+ Misses 9687 4012 -5675
+ Partials 910 0 -910
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [851 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `10.75%`.
> The diff coverage is `35.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 42.18% 31.43% -10.76%
+ Complexity 2648 2039 -609
=============================================
Files 900 887 -13
Lines 22172 21698 -474
Branches 2123 2078 -45
=============================================
- Hits 9354 6820 -2534
- Misses 12148 14356 +2208
+ Partials 670 522 -148
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/CompositeRuleEvaluate.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `25.00% <25.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `43.94% <42.85%> (-1.06%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `63.15% <66.66%> (+0.30%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [167 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...4e8366b](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 180 -720
Lines 22172 4262 -17910
Branches 2123 487 -1636
============================================
- Hits 9354 0 -9354
+ Misses 12148 4262 -7886
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [714 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ec375e2](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r499148818
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/expression/Expression.java
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.expression;
+
+import lombok.extern.slf4j.Slf4j;
+import org.mvel2.MVEL;
+import org.mvel2.ParserContext;
+
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Expression support eval java basic expressions, just like groovy script
+ * The internal detail is it first compile the expression to a pareTree then execute the parseTree with data
+ * It caches the compiled expression for sake of performance
+ */
+@Slf4j
+public class Expression {
+ private Map<String, Object> expressionCache;
+ private ExpressionContext context;
+
+ public Expression(ExpressionContext context) {
+ this.context = context;
+ this.expressionCache = new ConcurrentHashMap<>();
+ }
+
+ /**
+ * Eval the given expression using empty data context
+ */
+ public Object eval(String expression) {
+ return eval(expression, null);
+ }
+
+ /**
+ * Eval the given expression with data context
+ */
+ public Object eval(String expression, Map<String, Object> vars) {
+ try {
+ Object obj = compile(expression, context);
+ return MVEL.executeExpression(obj, vars);
+ } catch (Throwable e) {
+ log.error("eval expression {} error", expression, e);
+ return null;
+ }
+ }
+
+ /**
+ * Compile the given expression to a parseTree
+ */
+ public Object compile(String expression, ExpressionContext pctx) {
+ Object o = expressionCache.get(expression);
+ if (o == null) {
+ o = MVEL.compileExpression(expression, pctx.getContext());
+ expressionCache.put(expression, o);
+ }
+ return o;
Review comment:
Composite operation is not atomic, replace with `ConcurrentHashMap#computeIfAbsent`
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/expression/Expression.java
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.expression;
+
+import lombok.extern.slf4j.Slf4j;
+import org.mvel2.MVEL;
+import org.mvel2.ParserContext;
+
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Expression support eval java basic expressions, just like groovy script
+ * The internal detail is it first compile the expression to a pareTree then execute the parseTree with data
Review comment:
```suggestion
* The internal detail is it first compile the expression to a parseTree then execute the parseTree with data
```
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/expression/Expression.java
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.expression;
+
+import lombok.extern.slf4j.Slf4j;
+import org.mvel2.MVEL;
+import org.mvel2.ParserContext;
+
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Expression support eval java basic expressions, just like groovy script
+ * The internal detail is it first compile the expression to a pareTree then execute the parseTree with data
+ * It caches the compiled expression for sake of performance
+ */
+@Slf4j
+public class Expression {
+ private Map<String, Object> expressionCache;
+ private ExpressionContext context;
Review comment:
Can be `final`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701937783
Hi @wu-sheng , seems maven has some issue. can you help to check it
`
Error: Failed to execute goal on project apm-sharding-sphere-4.x-rc3-plugin: Could not resolve dependencies for project org.apache.skywalking:apm-sharding-sphere-4.x-rc3-plugin:jar:8.2.0-SNAPSHOT: Failed to collect dependencies at org.apache.shardingsphere:sharding-jdbc-core:jar:4.0.0-RC3 -> org.apache.shardingsphere:sharding-core-entry:jar:4.0.0-RC3 -> org.apache.shardingsphere:sharding-core-parse-mysql:jar:4.0.0-RC3: Failed to read artifact descriptor for org.apache.shardingsphere:sharding-core-parse-mysql:jar:4.0.0-RC3: Could not transfer artifact org.apache.shardingsphere:sharding-core-parse-mysql:pom:4.0.0-RC3 from/to central (https://repo.maven.apache.org/maven2): Connection reset -> [Help 1]
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **increase** coverage by `21.47%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
+ Coverage 31.31% 52.78% +21.47%
- Complexity 2007 3369 +1362
=============================================
Files 865 886 +21
Lines 21277 21972 +695
Branches 2026 2105 +79
=============================================
+ Hits 6662 11599 +4937
+ Misses 14128 9443 -4685
- Partials 487 930 +443
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.73% <42.85%> (+3.01%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [294 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...759b0af](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#discussion_r498357414
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -93,17 +105,24 @@ rules:
count: 3
silence-period: 5
message: The request number of entity {name} non-200 status is more than expected.
+ only-as-condition: false
+composite-rules:
+ comp_rule:
+ # Must satisfied percent rule and resp time rule
+ expression: service_percent_rule && service_resp_time_percentile_rule
+ message: Service percent less than 80% and response time p50 > 1000
```
+
### Default alarm rules
We provided a default `alarm-setting.yml` in our distribution only for convenience, which including following rules
1. Service average response time over 1s in last 3 minutes.
-1. Service success rate lower than 80% in last 2 minutes.
-1. Percentile of service response time is over 1s in last 3 minutes
-1. Service Instance average response time over 1s in last 2 minutes, and the instance name matches the regex.
-1. Endpoint average response time over 1s in last 2 minutes.
-1. Database access average response time over 1s in last 2 minutes.
-1. Endpoint relation average response time over 1s in last 2 minutes.
+2. Service success rate lower than 80% in last 2 minutes.
+3. Percentile of service response time is over 1s in last 3 minutes
+4. Service Instance average response time over 1s in last 2 minutes, and the instance name matches the regex.
+5. Endpoint average response time over 1s in last 2 minutes.
+6. Database access average response time over 1s in last 2 minutes.
+7. Endpoint relation average response time over 1s in last 2 minutes.
Review comment:
Already changed. I used other tool to render md file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/736dc3d3ec4fa7b04dfb0450b0b3567402d8ee6c?el=desc) will **decrease** coverage by `18.85%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.51% 32.65% -18.86%
+ Complexity 3305 2124 -1181
=============================================
Files 883 902 +19
Lines 21854 22107 +253
Branches 2081 2105 +24
=============================================
- Hits 11257 7219 -4038
- Misses 9687 14322 +4635
+ Partials 910 566 -344
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `42.60% <42.85%> (-3.31%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-1.21%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (+2.99%)` | `7.00 <1.00> (+1.00)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [306 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [736dc3d...c620ad9](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/47d5a7680ba4e09dee408468b3886525dc46d9c6?el=desc) will **decrease** coverage by `42.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
============================================
- Coverage 42.18% 0.00% -42.19%
============================================
Files 900 182 -718
Lines 22172 4273 -17899
Branches 2123 487 -1636
============================================
- Hits 9354 0 -9354
+ Misses 12148 4273 -7875
+ Partials 670 0 -670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [712 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [47d5a76...ec375e2](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5615: Support group concept in the alarm core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5615:
URL: https://github.com/apache/skywalking/pull/5615#issuecomment-701904252
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=h1) Report
> Merging [#5615](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/772f1d2e82aa97e47d0e04f81dc822f35e3e0d02?el=desc) will **decrease** coverage by `11.72%`.
> The diff coverage is `35.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5615 +/- ##
=============================================
- Coverage 51.80% 40.07% -11.73%
+ Complexity 3363 2484 -879
=============================================
Files 1606 868 -738
Lines 34102 21443 -12659
Branches 3710 2058 -1652
=============================================
- Hits 17666 8593 -9073
+ Misses 15581 12214 -3367
+ Partials 855 636 -219
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (-66.67%)` | `0.00 <0.00> (-2.00)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `22.22% <22.22%> (ø)` | `1.00 <1.00> (?)` | |
| [...e/alarm/provider/expression/ExpressionContext.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb25Db250ZXh0LmphdmE=) | `27.27% <27.27%> (ø)` | `1.00 <1.00> (?)` | |
| [...king/oap/server/core/alarm/provider/AlarmCore.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybUNvcmUuamF2YQ==) | `75.00% <28.57%> (-10.72%)` | `10.00 <2.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.39% <42.85%> (-13.01%)` | `11.00 <1.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `48.14% <47.42%> (-19.39%)` | `9.00 <7.00> (+6.00)` | :arrow_down: |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `65.85% <83.33%> (-28.44%)` | `7.00 <1.00> (+1.00)` | :arrow_down: |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [1185 more](https://codecov.io/gh/apache/skywalking/pull/5615/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=footer). Last update [772f1d2...4553cb1](https://codecov.io/gh/apache/skywalking/pull/5615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org