You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "BELUGA BEHR (JIRA)" <ji...@apache.org> on 2018/04/13 16:43:00 UTC
[jira] [Comment Edited] (HADOOP-15362) Review of Configuration.java
[ https://issues.apache.org/jira/browse/HADOOP-15362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437553#comment-16437553 ]
BELUGA BEHR edited comment on HADOOP-15362 at 4/13/18 4:42 PM:
---------------------------------------------------------------
[~ajayydv], the generated Checkstyles are "LineLength" warnings and we're talking just a couple of characters past an arguably outdated number of 80. To shorten the lines harms readability just for line-length cap. Please consider this patch for inclusions as it fixes many check style issue than it adds.
was (Author: belugabehr):
[~ajayydv], the generated Checkstyles are "LineLength" warnings and we're talking just a couple of characters past a dated number of 80. To shorten the lines harms readability just for line-length cap. Please consider this patch for inclusions as it fixes many check style issue than it adds.
> Review of Configuration.java
> ----------------------------
>
> Key: HADOOP-15362
> URL: https://issues.apache.org/jira/browse/HADOOP-15362
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Affects Versions: 3.0.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HADOOP-15362.1.patch, HADOOP-15362.2.patch, HADOOP-15362.3.patch, HADOOP-15362.4.patch, HADOOP-15362.5.patch
>
>
> * Various improvements
> * Fix a lot of checks style errors
> When I ran a recent debug log against a MR job, I was spammed from the following messages. I ask that we move them to 'trace' as there is already a debug level logging preceding them.
> {code:java}
> LOG.debug("Handling deprecation for all properties in config");
> foreach item {
> - LOG.debug("Handling deprecation for " + (String)item);
> + LOG.trace("Handling deprecation for {}", item);
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org