You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/10/06 01:04:41 UTC

[GitHub] ccollins476ad opened a new pull request #211: host: Unconditionally disable adv on controller

ccollins476ad opened a new pull request #211: host: Unconditionally disable adv on controller
URL: https://github.com/apache/mynewt-nimble/pull/211
 
 
   This PR contains two changes to address a bug that has been observed occasionally.  The bug is: sometimes the controller thinks advertising is active while the host thinks it is not.  This bug causes all subsequent advertise attempts to fail.
   
   #### Change 1- host: Unconditionally disable adv on controller
   
   Prior to this commit, the host would only honor a request to stop advertising if its state indicated that advertising is active.  If advertising were not active, `ble_gap_adv_stop()` would abort early with the `BLE_HS_EALREADY` error code.
   
   Now, the host always attempts to disable advertising when requested.  It does not inspect its own state at all.
   
   #### Change 2- host: Add debug setting for verifying ll state
   
   This commit adds a new syscfg setting: `BLE_HS_DEBUG_CONTROLLER`.  When this setting is enabled, the host performs some extra assertions of the expected controller state.  This setting assumes the host has direct access to the controller's internal state, so it should only be used in combined host controller setups.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services