You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/09/08 01:59:43 UTC
[GitHub] [superset] stephenLYZ opened a new pull request, #21366: fix(explore): disable resize bar when the results area is collapsed
stephenLYZ opened a new pull request, #21366:
URL: https://github.com/apache/superset/pull/21366
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
If the data section (results/samples) is collapsed, user can still drag the icon/object between chart and data section header to resize the chart. This behavior is confusing as in this case the data section remains collapsed and empty.
So we remove drag indicator/feature if the data section is collapsed.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
https://user-images.githubusercontent.com/11830681/189016760-60e1de08-8d63-408a-9c8f-2903137a7366.mov
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21366: fix(explore): disable resize bar when the results area is collapsed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21366:
URL: https://github.com/apache/superset/pull/21366#issuecomment-1243573024
@geido Ephemeral environment spinning up at http://35.87.126.10:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a diff in pull request #21366: fix(explore): disable resize bar when the results area is collapsed
Posted by GitBox <gi...@apache.org>.
geido commented on code in PR #21366:
URL: https://github.com/apache/superset/pull/21366#discussion_r965836141
##########
superset-frontend/src/explore/components/ExploreChartPanel.test.jsx:
##########
@@ -145,4 +146,15 @@ describe('ChartContainer', () => {
render(<ChartContainer {...props} />, { useRedux: true });
expect(screen.queryByText('Cached')).not.toBeInTheDocument();
});
+
+ it('hide gutter when collapse panel', async () => {
Review Comment:
```suggestion
it('hides gutter when collapsing data panel', async () => {
```
##########
superset-frontend/src/explore/components/ExploreChartPanel.test.jsx:
##########
@@ -145,4 +146,15 @@ describe('ChartContainer', () => {
render(<ChartContainer {...props} />, { useRedux: true });
expect(screen.queryByText('Cached')).not.toBeInTheDocument();
});
+
+ it('hide gutter when collapse panel', async () => {
+ const props = createProps();
+ setItem(LocalStorageKeys.is_datapanel_open, true);
+ const { container } = render(<ChartContainer {...props} />, {
+ useRedux: true,
+ });
+ userEvent.click(screen.getByLabelText('Collapse data panel'));
+ const gutter = container.querySelector('.gutter');
Review Comment:
Can you please also verify in the test that this was visible before closing the data panel?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #21366: fix(explore): disable resize bar when the results area is collapsed
Posted by GitBox <gi...@apache.org>.
rusackas merged PR #21366:
URL: https://github.com/apache/superset/pull/21366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21366: fix(explore): disable resize bar when the results area is collapsed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21366:
URL: https://github.com/apache/superset/pull/21366#issuecomment-1243841953
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21366: fix(explore): disable resize bar when the results area is collapsed
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21366:
URL: https://github.com/apache/superset/pull/21366#issuecomment-1240159047
# [Codecov](https://codecov.io/gh/apache/superset/pull/21366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21366](https://codecov.io/gh/apache/superset/pull/21366?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (12f8023) into [master](https://codecov.io/gh/apache/superset/commit/1cc214853864760de5bfec409fe5934635711d70?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1cc2148) will **increase** coverage by `0.13%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #21366 +/- ##
==========================================
+ Coverage 66.47% 66.60% +0.13%
==========================================
Files 1789 1791 +2
Lines 68381 68504 +123
Branches 7276 7310 +34
==========================================
+ Hits 45455 45626 +171
+ Misses 21051 20996 -55
- Partials 1875 1882 +7
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.80% <100.00%> (+0.30%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/21366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `71.62% <100.00%> (+4.01%)` | :arrow_up: |
| [...cy-preset-chart-nvd3/src/TimePivot/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/21366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL1RpbWVQaXZvdC9jb250cm9sUGFuZWwudHM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...t-controls/src/sections/echartsTimeSeriesQuery.tsx](https://codecov.io/gh/apache/superset/pull/21366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NlY3Rpb25zL2VjaGFydHNUaW1lU2VyaWVzUXVlcnkudHN4) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...s/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx](https://codecov.io/gh/apache/superset/pull/21366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXQvTGVmdFBhbmVsL2luZGV4LnRzeA==) | `83.92% <0.00%> (-16.08%)` | :arrow_down: |
| [...perset-ui-chart-controls/src/sections/sections.tsx](https://codecov.io/gh/apache/superset/pull/21366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NlY3Rpb25zL3NlY3Rpb25zLnRzeA==) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [...et-ui-chart-controls/src/shared-controls/index.tsx](https://codecov.io/gh/apache/superset/pull/21366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9pbmRleC50c3g=) | `48.43% <0.00%> (-2.83%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/21366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `70.96% <0.00%> (-1.45%)` | :arrow_down: |
| [...d/src/explore/components/PropertiesModal/index.tsx](https://codecov.io/gh/apache/superset/pull/21366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwvaW5kZXgudHN4) | `62.90% <0.00%> (-1.04%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/21366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `56.60% <0.00%> (-0.54%)` | :arrow_down: |
| [...src/dashboard/components/PropertiesModal/index.tsx](https://codecov.io/gh/apache/superset/pull/21366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC50c3g=) | `61.81% <0.00%> (-0.38%)` | :arrow_down: |
| ... and [32 more](https://codecov.io/gh/apache/superset/pull/21366/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #21366: fix(explore): disable resize bar when the results area is collapsed
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on PR #21366:
URL: https://github.com/apache/superset/pull/21366#issuecomment-1243683943
@geido @kasiazjc Thanks for these suggestions. It makes sense. And my idea is that when we click the collapse button, we don't really collapse the panel, but rather move the panel to the bottom, we can still drag and drop the panel, but at this point dragging upwards doesn't result in a blank space, but rather the content panel, and the collapse button also reverts to its original state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #21366: fix(explore): disable resize bar when the results area is collapsed
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #21366:
URL: https://github.com/apache/superset/pull/21366#issuecomment-1243840455
I feel like the suggestions being floated around might involve more edge cases and frustration than the original thing this PR fixes. Can we just merge this and ticket any additional layers of fanciness as an additional task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #21366: fix(explore): disable resize bar when the results area is collapsed
Posted by GitBox <gi...@apache.org>.
geido commented on PR #21366:
URL: https://github.com/apache/superset/pull/21366#issuecomment-1243570159
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kasiazjc commented on pull request #21366: fix(explore): disable resize bar when the results area is collapsed
Posted by GitBox <gi...@apache.org>.
kasiazjc commented on PR #21366:
URL: https://github.com/apache/superset/pull/21366#issuecomment-1243671431
> @stephenLYZ this LGTM. I am wondering if we should close the data panel automatically when it reaches the bottom, as it is in fact the same as closing it. CC @kasiazjc
>
> Superset.mp4
good call @geido, I think it makes sense! You cannot see anything, so there is no point in it being expanded.
There is one edge case, where someone may be playing with the drag and drop and out of the blue the section will collapse itself and they will have to manually expand which can be annoying. But I'd still say that we should go with your suggestion, Diego and we'll hear feedback that it doesn't make sense, then we'll revert it.
cc: @stephenLYZ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org