You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/03/29 11:13:26 UTC
[GitHub] [nifi] jlpedrosa opened a new pull request #4945: NIFI-8374 Refactor readOnly to accessMode in ApiModelProperty usages
jlpedrosa opened a new pull request #4945:
URL: https://github.com/apache/nifi/pull/4945
#### Description of PR
readOnly has been deprecated, and should be relaplced by accessMode, readOnly = true is accessMode.READ_ONLY
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #4945: NIFI-8374 Refactor readOnly to accessMode in ApiModelProperty usages
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4945:
URL: https://github.com/apache/nifi/pull/4945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on pull request #4945: NIFI-8374 Refactor readOnly to accessMode in ApiModelProperty usages
Posted by GitBox <gi...@apache.org>.
MikeThomsen commented on pull request #4945:
URL: https://github.com/apache/nifi/pull/4945#issuecomment-812651886
FYI, looks like you copied and pasted your commit message for another commit into this one. I'm going to rewrite your commit message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jlpedrosa commented on pull request #4945: NIFI-8374 Refactor readOnly to accessMode in ApiModelProperty usages
Posted by GitBox <gi...@apache.org>.
jlpedrosa commented on pull request #4945:
URL: https://github.com/apache/nifi/pull/4945#issuecomment-812670953
thanks @MikeThomsen for the review and fixing the message, I think it may have been an issue when I re-wrote history, I was doing multiple PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org