[GitHub] betodealmeida opened a new pull request #5140: Improve time shift

[GitBox <gi...@apache.org>]

betodealmeida opened a new pull request #5140: Improve time shift
URL: https://github.com/apache/incubator-superset/pull/5140
 
 
   PR https://github.com/apache/incubator-superset/pull/5067 introduced the ability to add multiple time shifts. Unfortunately, it broke the color matching between a time series and its time shift, since before the time shift was identified by `---`, and now we actually label them `1 hour offset`, `2 days offset`, etc.
   
   This PR fixes that bug, adding a constant in `utils/common.js` to identify time shifts (so future updates only need to be done in one place). It also improves the multiple time shifts by adding different line patterns for each time shift, eg, dotted, dashed, dot-dashed. I added 10 new styles for the lines, which will be rotated for all the time shifts. The pattern is consistent across time shifts, ie, all `1 hour offset` series will have the same pattern.
   
   <img width="1680" alt="screen shot 2018-06-05 at 10 51 41 am" src="https://user-images.githubusercontent.com/1534870/40993578-d43359e8-68ae-11e8-96d3-908d3076491c.png">
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org