[GitHub] [iceberg] flyrain commented on a change in pull request #3640: Core: Support case sensitivity in MergingSnapshotProducer

[GitBox <gi...@apache.org>]

flyrain commented on a change in pull request #3640:
URL: https://github.com/apache/iceberg/pull/3640#discussion_r760711665



##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -125,6 +127,16 @@ public ThisT set(String property, String value) {
     return self();
   }
 
+  protected void caseSensitiveBinding(boolean newCaseSensitive) {

Review comment:
       Maybe we could be consistent with the name. I saw three names(caseSensitive, isCaseSensitive, newCaseSensitive) used for the parameters. Kind of prefer one simple name for all of them, like `caseSensitive`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org