You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/01/26 03:48:13 UTC
[GitHub] [beam] ibzib commented on a change in pull request #13651: [BEAM-10961] Enabled strict dependencies on model module
ibzib commented on a change in pull request #13651:
URL: https://github.com/apache/beam/pull/13651#discussion_r564199795
##########
File path: model/fn-execution/build.gradle
##########
@@ -17,17 +17,16 @@
*/
plugins { id 'org.apache.beam.module' }
-applyPortabilityNature(
+/*applyPortabilityNature(
automaticModuleName: 'org.apache.beam.model.fn.execution',
shadowJarValidationExcludes: ["org/apache/beam/model/fnexecution/v1/**"]
+)*/
+
+applyJavaNature(
+ enableStrictDependencies: true,
Review comment:
`applyJavaNature` is used for Java projects. However, `model/*` does not contain any Java source code; it only generates Java source code using [protocol buffers](https://developers.google.com/protocol-buffers). So we don't need to enable strict dependency checking on these projects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org