You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@metamodel.apache.org by jakubneubauer <gi...@git.apache.org> on 2017/11/14 16:09:34 UTC

[GitHub] metamodel pull request #167: METAMODEL-1169 Preserve milliseconds when rewri...

GitHub user jakubneubauer opened a pull request:

    https://github.com/apache/metamodel/pull/167

    METAMODEL-1169 Preserve milliseconds when rewriting query with Date operand (master)

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jakubneubauer/metamodel METAMODEL-1169-milliseconds-in-sql-server-query-fix-in-master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metamodel/pull/167.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #167
    
----

----


---

[GitHub] metamodel issue #167: METAMODEL-1169 Preserve milliseconds when rewriting qu...

Posted by jakubneubauer <gi...@git.apache.org>.

Github user jakubneubauer commented on the issue:

    https://github.com/apache/metamodel/pull/167
  
    tests were fixed.


---

[GitHub] metamodel issue #167: METAMODEL-1169 Preserve milliseconds when rewriting qu...

Posted by jakubneubauer <gi...@git.apache.org>.

Github user jakubneubauer commented on the issue:

    https://github.com/apache/metamodel/pull/167
  
    To the integration tests:
    I found these int. tests related to date/time handling:
    
    - SQLServerJtdsDriverTest.testWorkingWithDates and it is working.
    - SQLServerJtdsDriverTest.ignoreTestTimestampValueInsertSelect is now commented out with description that this test was failing and actually somehow wrong
    
    So it looks like it doesn't require any change.


---

[GitHub] metamodel pull request #167: METAMODEL-1169 Preserve milliseconds when rewri...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/metamodel/pull/167


---

[GitHub] metamodel issue #167: METAMODEL-1169 Preserve milliseconds when rewriting qu...

Posted by LosD <gi...@git.apache.org>.

Github user LosD commented on the issue:

    https://github.com/apache/metamodel/pull/167
  
    Merged


---

[GitHub] metamodel issue #167: METAMODEL-1169 Preserve milliseconds when rewriting qu...

Posted by LosD <gi...@git.apache.org>.

Github user LosD commented on the issue:

    https://github.com/apache/metamodel/pull/167
  
    Code LGTM, but this seem like a change that requires an update to the integration tests. However, they might be quite broken, so it might not make much of a difference, but at least we should take a look. 


---