You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/06 14:39:49 UTC
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#458: stm32h7: support SDRAM via FMC peripherial
patacongo commented on a change in pull request #458: stm32h7: support SDRAM via FMC peripherial
URL: https://github.com/apache/incubator-nuttx/pull/458#discussion_r388939275
##########
File path: arch/arm/src/stm32h7/stm32_fmc.c
##########
@@ -39,40 +39,387 @@
#include <nuttx/config.h>
+#if defined(CONFIG_STM32H7_FMC)
+
#include "stm32.h"
-#if defined(CONFIG_STM32H7_FMC)
+#include <debug.h>
+
+//#include "stm32_fmc.h"
+//#include "hardware/stm32_pinmap.h"
+//#include "stm32_gpio.h"
+//#include "stm32_rcc.h"
Review comment:
Use of commented out code and any use of C++ comments is forbidden by the coding standard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services