You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2016/08/02 00:49:30 UTC
[2/2] kylin git commit: KYLIN-1732 minor code format
KYLIN-1732 minor code format
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/a769c286
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/a769c286
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/a769c286
Branch: refs/heads/master
Commit: a769c286f0c00069ff7c54f04e9bb959f85d8df2
Parents: e63de67
Author: Yang Li <li...@apache.org>
Authored: Tue Aug 2 08:49:16 2016 +0800
Committer: Yang Li <li...@apache.org>
Committed: Tue Aug 2 08:49:16 2016 +0800
----------------------------------------------------------------------
.../test/java/org/apache/kylin/query/ITKylinQueryTest.java | 1 +
.../java/org/apache/kylin/query/relnode/OLAPWindowRel.java | 8 ++++----
2 files changed, 5 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/a769c286/kylin-it/src/test/java/org/apache/kylin/query/ITKylinQueryTest.java
----------------------------------------------------------------------
diff --git a/kylin-it/src/test/java/org/apache/kylin/query/ITKylinQueryTest.java b/kylin-it/src/test/java/org/apache/kylin/query/ITKylinQueryTest.java
index cfa1c9c..a6e7956 100644
--- a/kylin-it/src/test/java/org/apache/kylin/query/ITKylinQueryTest.java
+++ b/kylin-it/src/test/java/org/apache/kylin/query/ITKylinQueryTest.java
@@ -276,6 +276,7 @@ public class ITKylinQueryTest extends KylinTestBase {
@Test
public void testWindowQuery() throws Exception {
+ // cannot compare coz H2 does not support window function yet..
this.batchExecuteQuery(getQueryFolderPrefix() + "src/test/resources/query/sql_window");
}
http://git-wip-us.apache.org/repos/asf/kylin/blob/a769c286/query/src/main/java/org/apache/kylin/query/relnode/OLAPWindowRel.java
----------------------------------------------------------------------
diff --git a/query/src/main/java/org/apache/kylin/query/relnode/OLAPWindowRel.java b/query/src/main/java/org/apache/kylin/query/relnode/OLAPWindowRel.java
index 8688944..1ee0348 100644
--- a/query/src/main/java/org/apache/kylin/query/relnode/OLAPWindowRel.java
+++ b/query/src/main/java/org/apache/kylin/query/relnode/OLAPWindowRel.java
@@ -65,9 +65,9 @@ public class OLAPWindowRel extends Window implements OLAPRel {
@Override
public RelWriter explainTerms(RelWriter pw) {
- return super.explainTerms(pw)
- .itemIf("constants", constants, !constants.isEmpty())
- .itemIf("groups", groups, !groups.isEmpty());
+ return super.explainTerms(pw) //
+ .itemIf("constants", constants, !constants.isEmpty()) //
+ .itemIf("groups", groups, !groups.isEmpty());
}
@Override
@@ -130,7 +130,7 @@ public class OLAPWindowRel extends Window implements OLAPRel {
@Override
public boolean hasSubQuery() {
for (RelNode child : getInputs()) {
- if (((OLAPRel)child).hasSubQuery()) {
+ if (((OLAPRel) child).hasSubQuery()) {
return true;
}
}