[GitHub] [trafficcontrol] alexluckerman commented on a change in pull request #3725: Make entire row clickable in TP assignment popups

[GitBox <gi...@apache.org>]

alexluckerman commented on a change in pull request #3725: Make entire row clickable in TP assignment popups
URL: https://github.com/apache/trafficcontrol/pull/3725#discussion_r304101596
 
 

 ##########
 File path: traffic_portal/app/src/common/modules/table/cacheGroupParameters/table.cacheGroupParamsUnassigned.tpl.html
 ##########
 @@ -34,8 +34,8 @@ <h3 class="modal-title">Link Parameters to {{::cg.name}}</h3>
         </tr>
         </thead>
         <tbody>
-        <tr ng-repeat="p in ::unassignedParams">
-            <td><input type="checkbox" ng-click="updateParams($event, p.id)"></td>
+        <tr ng-repeat="p in ::unassignedParams" ng-click="updateParams($event, p.id)"">
+            <td><input type="checkbox" ng-click="$event.preventDefault()"></td>
 
 Review comment:
   explicitOriginalTarget appears to be Mozilla-specific

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services