[jira] Commented: (HADOOP-4256) Remove Completed and Failed Job tables from jobqueue_details.jsp

["Hemanth Yamijala (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635959#action_12635959 ] 

Hemanth Yamijala commented on HADOOP-4256:
------------------------------------------

- The copy from the {{jobs}} Collection to the {{jobsVec}} seems unnecessary. I realize this is because {{JSPUtil.generateJobTable}} takes a {{Vector<JobInProgress>}} as argument. Since JSPUtil is a package private class, I would recommend we change the interface of the {{generateJobTable}} to take a {{Collection<JobInProgress>}}. AFAIK, the way we are using the method does not need this to be a Vector. Note that this change will still work without having to change any clients.

- I think we can remove the heading 'Job List', because we already have another heading saying "Job Summary for Queue:". The text "Sorted by order maintained in the TaskScheduler" could appear directly under the "Job Summary..." heading, and could read "(In the order maintained by the scheduler)"

> Remove Completed and Failed Job tables from jobqueue_details.jsp
> ----------------------------------------------------------------
>
>                 Key: HADOOP-4256
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4256
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Sreekanth Ramakrishnan
>            Assignee: Sreekanth Ramakrishnan
>            Priority: Blocker
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-4256-1.patch, HADOOP-4256-2.patch, HADOOP-4256-3.patch
>
>
> Remove completed and failed Job tables from _jobqueue_details.jsp_.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.