[jira] [Commented] (TAJO-543) InsertNode and CreateTableNode should play their roles

["Hyunsik Choi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878258#comment-13878258 ] 

Hyunsik Choi commented on TAJO-543:
-----------------------------------

Created a review request against branch master in reviewboard 
https://reviews.apache.org/r/17174/


> InsertNode and CreateTableNode should play their roles
> ------------------------------------------------------
>
>                 Key: TAJO-543
>                 URL: https://issues.apache.org/jira/browse/TAJO-543
>             Project: Tajo
>          Issue Type: Improvement
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-543.patch
>
>
> Currently, CreateTableNode and InsertNode are just intermediate representations. They are rewritten to StoreTableNode. But, StoreTableNode does not contain some necessary fields, such as output table, target table, target columns, overwrite flag and create table flag. So far, these fields are kept in QueryContext.
> This implementation causes unnecessary and complex rewrite of DistributedQueryHookManager. As a result, it is hard to maintain and manage CREATE/INSERT plans.
> The main objective of this issue is to improve LogicalPlanner to use CreateTableNode and InsertNode throughout the planning phase and eliminate complex rewrite in DistributedQueryHookManager.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)