You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/25 20:05:55 UTC
[GitHub] [arrow] nealrichardson commented on a change in pull request #11539: ARROW-14253: [R] Update lz4 test failing locally due to different error message
nealrichardson commented on a change in pull request #11539:
URL: https://github.com/apache/arrow/pull/11539#discussion_r735921308
##########
File path: r/tests/testthat/test-feather.R
##########
@@ -233,11 +233,8 @@ ft_file <- test_path("golden-files/data-arrow_2.0.0_lz4.feather")
test_that("Error messages are shown when the compression algorithm lz4 is not found", {
msg <- paste0(
- "NotImplemented: Support for codec 'lz4' not built\nIn order to read this file, ",
- "you will need to reinstall arrow with additional features enabled.\nSet one of ",
- "these environment variables before installing:\n\n * LIBARROW_MINIMAL=false ",
- "(for all optional features, including 'lz4')\n * ARROW_WITH_LZ4=ON (for just 'lz4')",
- "\n\nSee https://arrow.apache.org/docs/r/articles/install.html for details"
+ "In order to read this file, you will need to reinstall ",
Review comment:
I think the other possible fix is to leave in the full message but replace the first line with this, so the `.*` regex captures any extra C++ traceback:
```
"NotImplemented: Support for codec 'lz4' not built.*In order to read this file, ",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org