You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2024/06/11 07:05:24 UTC
[PR] feat: Add storage features for iceberg [iceberg-rust]
Xuanwo opened a new pull request, #400:
URL: https://github.com/apache/iceberg-rust/pull/400
Close https://github.com/apache/iceberg-rust/issues/385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add storage features for iceberg [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on code in PR #400:
URL: https://github.com/apache/iceberg-rust/pull/400#discussion_r1637923809
##########
crates/iceberg/Cargo.toml:
##########
@@ -28,6 +28,10 @@ repository = { workspace = true }
license = { workspace = true }
keywords = ["iceberg"]
+[features]
+storage-fs = ["opendal/services-fs"]
Review Comment:
So by default we don't include any storage backend? This seems inconvenient to me. How about this:
1. We add a default feature to include most common storage backend such as fs and s3.
2. Also add a `storage-all` feature to include all storage features.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add storage features for iceberg [iceberg-rust]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #400:
URL: https://github.com/apache/iceberg-rust/pull/400#issuecomment-2165725815
cc @liurenjie1024, please review again, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add storage features for iceberg [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on code in PR #400:
URL: https://github.com/apache/iceberg-rust/pull/400#discussion_r1638266798
##########
crates/catalog/glue/Cargo.toml:
##########
@@ -33,7 +33,7 @@ anyhow = { workspace = true }
async-trait = { workspace = true }
aws-config = { workspace = true }
aws-sdk-glue = { workspace = true }
-iceberg = { workspace = true }
+iceberg = { workspace = true, features = ["storage-s3"] }
Review Comment:
Do we need this change after introducing default features?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add storage features for iceberg [iceberg-rust]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #400:
URL: https://github.com/apache/iceberg-rust/pull/400#discussion_r1638234228
##########
crates/iceberg/Cargo.toml:
##########
@@ -28,6 +28,10 @@ repository = { workspace = true }
license = { workspace = true }
keywords = ["iceberg"]
+[features]
+storage-fs = ["opendal/services-fs"]
Review Comment:
I don't have strong preferences about this. I'll make the changes you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add storage features for iceberg [iceberg-rust]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #400:
URL: https://github.com/apache/iceberg-rust/pull/400#discussion_r1634312506
##########
Cargo.toml:
##########
@@ -65,7 +65,7 @@ log = "^0.4"
mockito = "^1"
murmur3 = "0.5.2"
once_cell = "1"
-opendal = "0.46"
+opendal = "0.47"
Review Comment:
I update opendal in this PR to avoid an oneline change...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add storage features for iceberg [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on code in PR #400:
URL: https://github.com/apache/iceberg-rust/pull/400#discussion_r1638044746
##########
crates/iceberg/Cargo.toml:
##########
@@ -28,6 +28,10 @@ repository = { workspace = true }
license = { workspace = true }
keywords = ["iceberg"]
+[features]
+storage-fs = ["opendal/services-fs"]
Review Comment:
cc @Xuanwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add storage features for iceberg [iceberg-rust]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #400:
URL: https://github.com/apache/iceberg-rust/pull/400#discussion_r1638278859
##########
crates/catalog/glue/Cargo.toml:
##########
@@ -33,7 +33,7 @@ anyhow = { workspace = true }
async-trait = { workspace = true }
aws-config = { workspace = true }
aws-sdk-glue = { workspace = true }
-iceberg = { workspace = true }
+iceberg = { workspace = true, features = ["storage-s3"] }
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add storage features for iceberg [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 merged PR #400:
URL: https://github.com/apache/iceberg-rust/pull/400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org