You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Emond Papegaaij (Jira)" <ji...@apache.org> on 2020/05/05 18:05:00 UTC

[jira] [Resolved] (WICKET-6778) Clearing MarkupContainer.REMOVALS_KEY is expensive

     [ https://issues.apache.org/jira/browse/WICKET-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emond Papegaaij resolved WICKET-6778.
-------------------------------------
    Fix Version/s: 9.0.0-M6
         Assignee: Emond Papegaaij
       Resolution: Fixed

> Clearing MarkupContainer.REMOVALS_KEY is expensive
> --------------------------------------------------
>
>                 Key: WICKET-6778
>                 URL: https://issues.apache.org/jira/browse/WICKET-6778
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 9.0.0-M5
>            Reporter: Emond Papegaaij
>            Assignee: Emond Papegaaij
>            Priority: Major
>             Fix For: 9.0.0-M6
>
>
> The {{REMOVALS_KEY}} metadata on {{MarkupContainer}} is cleared on every request. This is an expensive operation and often unnecessary. By putting this operation behind a request flag, it can often be avoided.
> An alternative approach is to check if the key is set (via {{getMetaData(REMOVALS_KEY)}}) and only clear it when it's set. This is faster than current master, but slower than using a flag.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)