You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Giampaolo Tomassoni (JIRA)" <de...@myfaces.apache.org> on 2007/01/17 19:50:29 UTC

[jira] Created: (MYFACES-1523) An HTTP GET with parameters is mistakenly handled like a postback request

An HTTP GET with parameters is mistakenly handled like a postback request
-------------------------------------------------------------------------

                 Key: MYFACES-1523
                 URL: https://issues.apache.org/jira/browse/MYFACES-1523
             Project: MyFaces Core
          Issue Type: Improvement
          Components: General
    Affects Versions: 1.1.4, 1.1.4.1-SNAPSHOT, 1.1.5-SNAPSHOT
            Reporter: Giampaolo Tomassoni
             Fix For: 1.1.5-SNAPSHOT
         Attachments: myfaces-core-no-postback-on-non-submit-patch.diff

This problem, which is also addressed by jsf-1.2 specs, actually afflicts all the pre-1.2.0 myfaces-core versions.

In these versions, when an HTTP request is issued to myfaces, the package evincts it is a postback request in case at least one POST/GET parameter is issued.

This can't be always the case, since there is the possibilty that some parameters are somehow used outside of the myfaces framework, expecially in the GET case.

I propose a solution which basicly assumes that an HTTP request is a postback iff it finds a parameter having a name ending in the _SUBMIT suffix, which is the one adopted by org.apache.myfaces.shared_impl.renderkit.html.HtmlFormRendererBase to mark a form submit.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (MYFACES-1523) An HTTP GET with parameters is mistakenly handled like a postback request

Posted by "Giampaolo Tomassoni (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504631 ] 

Giampaolo Tomassoni commented on MYFACES-1523:
----------------------------------------------

Is there any plan in committing this patch?

Is there any reason to not commit it?

> An HTTP GET with parameters is mistakenly handled like a postback request
> -------------------------------------------------------------------------
>
>                 Key: MYFACES-1523
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1523
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 1.1.4, 1.1.4.1-SNAPSHOT, 1.1.5-SNAPSHOT
>            Reporter: Giampaolo Tomassoni
>             Fix For:  1.1.6-SNAPSHOT
>
>         Attachments: myfaces-core-no-postback-on-non-submit-patch.diff
>
>
> This problem, which is also addressed by jsf-1.2 specs, actually afflicts all the pre-1.2.0 myfaces-core versions.
> In these versions, when an HTTP request is issued to myfaces, the package evincts it is a postback request in case at least one POST/GET parameter is issued.
> This can't be always the case, since there is the possibilty that some parameters are somehow used outside of the myfaces framework, expecially in the GET case.
> I propose a solution which basicly assumes that an HTTP request is a postback iff it finds a parameter having a name ending in the _SUBMIT suffix, which is the one adopted by org.apache.myfaces.shared_impl.renderkit.html.HtmlFormRendererBase to mark a form submit.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.