You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tamaya.apache.org by po...@apache.org on 2016/11/28 21:41:41 UTC

[2/2] incubator-tamaya git commit: TAMAYA-205: Prevent local build failure

TAMAYA-205: Prevent local build failure

* Add missing findbugs config for 01-minimal example.


Project: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/ac0c0838
Tree: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/ac0c0838
Diff: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/ac0c0838

Branch: refs/heads/master
Commit: ac0c083805caf9e2bbaca5ddc1c23b884c90cbfc
Parents: 3be9891
Author: Phil Ottlinger <po...@apache.org>
Authored: Mon Nov 28 22:40:51 2016 +0100
Committer: Phil Ottlinger <po...@apache.org>
Committed: Mon Nov 28 22:40:51 2016 +0100

----------------------------------------------------------------------
 .../01-minimal/findbugs/findbugs-exclude.xml    | 136 +++++++++++++++++++
 1 file changed, 136 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/ac0c0838/examples/01-minimal/findbugs/findbugs-exclude.xml
----------------------------------------------------------------------
diff --git a/examples/01-minimal/findbugs/findbugs-exclude.xml b/examples/01-minimal/findbugs/findbugs-exclude.xml
new file mode 100644
index 0000000..50255d9
--- /dev/null
+++ b/examples/01-minimal/findbugs/findbugs-exclude.xml
@@ -0,0 +1,136 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<FindBugsFilter>
+    <Match>
+        <!-- Also catches simple anonamous classes... -->
+        <Bug pattern="SIC_INNER_SHOULD_BE_STATIC_ANON" />
+    </Match>
+
+    <Match>
+        <!-- Note: @todo Write a bug report
+          The current version of FindBugs (version 3.0.0) is not able to detect
+          the usage of this method via a method reference.
+          Oliver B. Fischer, 17.01.2015
+        -->
+        <Bug pattern="UPM_UNCALLED_PRIVATE_METHOD" />
+    </Match>
+
+    <Match>
+        <!-- Note: @todo Write a bug report
+          The current version of FindBugs (version 3.0.0) is not able to detect
+          correctly caught exceptions.
+          Oliver B. Fischer, 09.02.2015
+        -->
+        <Bug pattern="REC_CATCH_EXCEPTION"/>
+    </Match>
+
+    <Match>
+        <!-- Note: We will not fail because of an unread field. -->
+        <Bug pattern="URF_UNREAD_FIELD" />
+    </Match>
+
+    <Match>
+        <!-- Note: We will not fail because of an unused field -->
+        <Bug pattern="UUF_UNUSED_FIELD" />
+    </Match>
+
+    <Match>
+        <Class name='org.apache.tamaya.integration.cdi.TamayaCDIIntegration'/>
+        <Method name="initBeanManager"/>
+    </Match>
+
+    <Match>
+        <!-- Note:
+             Intended. See the inline comment on this issue in the source file
+             in revision ae66299e25b41167008021ffe95cad236f6e2bd3
+             Oliver B. Fischer, 17.01.2015
+          -->
+        <Class name='org.apache.tamaya.resource.internal.ClasspathCollector'/>
+        <Method name="doFindPathMatchingJarResources"
+                returns="java.util.Collection"/>
+        <Bug pattern="OS_OPEN_STREAM"/>
+
+    </Match>
+
+    <!-- False positive returnin null for Boolean is required by the implemented interface. -->
+    <Match>
+        <Class name="org.apache.tamaya.core.internal.converters.BooleanConverter"/>
+    </Match>
+
+    <!-- False positive: example class used for config demo. -->
+    <Match>
+        <Class name="org.apache.tamaya.examples.injection.Example"/>
+    </Match>
+
+    <!--
+     * findBugs does not detect usage via method references
+     * should be removed after see TODO ProgrammaticConfigurationContext:131
+    -->
+
+    <!-- Issues to review -->
+
+    <Match>
+        <Package name="org.apache.tamaya.core.internal"/>
+    </Match>
+
+    <!--<Match>-->
+        <!--<Class name="org.apache.tamaya.resolver.internal.ResourceResolver" />-->
+    <!--</Match>-->
+    <!--<Match>-->
+        <!--<Class name="org.apache.tamaya.resolver.internal.FileResolver" />-->
+    <!--</Match>-->
+    <!--<Match>-->
+        <!--<Class name="org.apache.tamaya.resolver.internal.DefaultExpressionEvaluator" />-->
+    <!--</Match>-->
+    <!--<Match>-->
+        <!--<Class name="org.apache.tamaya.inject.internal.ConfiguredSetterMethod" />-->
+    <!--</Match>-->
+    <Match>
+        <Class name="org.apache.tamaya.inject.internal.ConfigChangeCallbackMethod" />
+    </Match>
+
+    <Match>
+        <Class name="org.apache.tamaya.events.internal.DefaultConfigChangeObserver" />
+        <Method name="checkConfigurationUpdate" />
+    </Match>
+
+    <Match>
+        <Class name="org.apache.tamaya.inject.internal.DefaultDynamicValue"/>
+    </Match>
+    <Match>
+        <Class name="org.apache.tamaya.integration.cdi.DefaultDynamicValue"/>
+    </Match>
+    <Match>
+        <!-- Imported from APache Felix. -->
+        <Class name="org.apache.tamaya.integration.osgi.felix.FilePersistenceManager"/>
+    </Match>
+    <Match>
+        <!-- Imported from APache Felix. -->
+        <Class name="org.apache.tamaya.integration.osgi.felix.ConfigurationHandler"/>
+    </Match>
+    <Match>
+        <Class name="org.apache.tamaya.integration.osgi.injection.Activator"/>
+    </Match>
+    <Match>
+        <Class name="org.apache.tamaya.resource.internal.FileCollector"/>
+        <Method name="traverseAndSelectFromChildren"/>
+    </Match>
+
+</FindBugsFilter>