You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2010/12/18 12:32:02 UTC
[jira] Commented: (LUCENE-2819) LuceneTestCase's check for uncaught
exceptions in threads causes collateral damage?
[ https://issues.apache.org/jira/browse/LUCENE-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972776#action_12972776 ]
Robert Muir commented on LUCENE-2819:
-------------------------------------
I think this is the problem: lets say the main thread spawns 3 other threads (A,B,C).
when A throws exception, our uncaught exception handler calls the test to fail.
There is nothing wrong with this... the problem in your example is i think B and C are still running and then fail later (even if its just a few ms)
So these get 'misattributed' to the next test method... we can't do anything about that either without doing insane amounts of buffering.
So we need to improve the thread handling in general for the tests.
> LuceneTestCase's check for uncaught exceptions in threads causes collateral damage?
> -----------------------------------------------------------------------------------
>
> Key: LUCENE-2819
> URL: https://issues.apache.org/jira/browse/LUCENE-2819
> Project: Lucene - Java
> Issue Type: Bug
> Components: Tests
> Reporter: Michael McCandless
> Fix For: 3.1, 4.0
>
>
> Eg see these failures:
> https://hudson.apache.org/hudson/job/Lucene-3.x/214/
> Multiple test methods failed in TestIndexWriterOnDiskFull, but, I think only 1 test had a real failure but somehow our "thread hit exc" tracking incorrectly blames the other 3 cases?
> I'm not sure about this but it seems like something like that is going on...
> So, one problem is that LuceneTestCase.tearDown fails on any thread excs, but if CMS had also hit a failure, then fails to clear CMS's thread failures. I think we should just remove CMS's thread failure tracking? (It's static so it can definitely bleed across tests). Ie, just rely on LuceneTestCase's tracking.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org