[GitHub] [iotdb] jamber001 edited a comment on pull request #4007: [IOTDB-1718] correct the position of "chmod + cmake"

[GitBox <gi...@apache.org>]

jamber001 edited a comment on pull request #4007:
URL: https://github.com/apache/iotdb/pull/4007#issuecomment-926373461


   > > @HTHou Can this PR be merged ?
   > 
   > Sorry, I don't get the reason why this change can solve the problem you mentioned. Can you plz explain more?
   
   I  try to give 1 summary for this part.  :-)
   In orginal IoTDB maven design, client-cpp's compiling procedure is as below:
   1) download cmake-3.17.3-Linux-x86_64.tar.gz and untar it.  (in maven phase <**generate-sources**>)
   2) download thrif 0.14.1 src code tar and untar it  (in maven phase <**generate-sources**>)
   3) use cmake to process thrift 0.14.1 src codes. (in maven phase <**generate-sources**>)
   4)  chmod +x cmake     (in maven phase <**process-sources**>)
   5) compile thrift 0.14.1  src code.  (in maven phase <**compile**>)  
   6)  more thrift generating work.   
   
   so, in above procedure, the step-4's postion should be 1 bug. 
   I guess that step-4 's orginal goal is to avoid new-downloaded cmake file has no executable permission, and step-4 should be run before step-3.
   But in origin codes, the step-4 was put in wrongly maven phase **process-sources**,  which casues it is run after step-3.
   
   **Note:** Of course, if the new-downloaded cmake file is originally executable, the step-4 is useless.
   
   My codes change is that:
   1) change the step-4's maven phase to **generate-sources**
   2) adjust step-4's position in pom.xml.
   so let "chmod +x cmake"  happen just after step-2. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org