You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Dragonliu2018 (via GitHub)" <gi...@apache.org> on 2024/06/13 14:12:23 UTC
[PR] [Featrue](default value) add pi as default value [doris]
Dragonliu2018 opened a new pull request, #36280:
URL: https://github.com/apache/doris/pull/36280
## Proposed changes
Issue Number: refers https://github.com/apache/doris/issues/34228
<!--Describe your changes.-->
add pi as default value, such as:
```sql
CREATE TABLE IF NOT EXISTS t1
(
k TINYINT,
v double not null DEFAULT PI
)
UNIQUE KEY(k)
DISTRIBUTED BY HASH(k)
PROPERTIES("replication_num" = "1");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36280:
URL: https://github.com/apache/doris/pull/36280#issuecomment-2167454862
<details>
<summary>ClickBench: <b>Total hot run time: 30.77 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e5685149681e7f6f250598a764c04f224b9b8914, data reload: false
query1 0.04 0.03 0.03
query2 0.08 0.04 0.04
query3 0.23 0.06 0.04
query4 1.68 0.07 0.07
query5 0.49 0.50 0.47
query6 1.13 0.71 0.72
query7 0.02 0.01 0.01
query8 0.05 0.05 0.05
query9 0.53 0.49 0.50
query10 0.54 0.55 0.54
query11 0.15 0.11 0.11
query12 0.15 0.12 0.12
query13 0.60 0.59 0.60
query14 0.79 0.79 0.78
query15 0.85 0.82 0.82
query16 0.37 0.37 0.36
query17 0.99 1.03 1.01
query18 0.22 0.23 0.27
query19 1.91 1.78 1.73
query20 0.01 0.02 0.01
query21 15.41 0.66 0.65
query22 4.44 7.34 2.22
query23 18.30 1.41 1.25
query24 2.13 0.22 0.20
query25 0.16 0.09 0.08
query26 0.25 0.18 0.17
query27 0.08 0.08 0.08
query28 13.24 1.01 1.00
query29 12.65 3.30 3.25
query30 0.26 0.06 0.06
query31 2.85 0.39 0.38
query32 3.29 0.47 0.47
query33 2.85 2.92 2.87
query34 17.34 4.39 4.38
query35 4.47 4.44 4.46
query36 0.64 0.47 0.47
query37 0.18 0.15 0.15
query38 0.15 0.15 0.14
query39 0.05 0.03 0.03
query40 0.17 0.15 0.14
query41 0.09 0.05 0.05
query42 0.06 0.04 0.04
query43 0.04 0.04 0.04
Total cold run time: 109.93 s
Total hot run time: 30.77 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36280:
URL: https://github.com/apache/doris/pull/36280#issuecomment-2165910931
<details>
<summary>ClickBench: <b>Total hot run time: 30.98 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit aff6d3104e868e3fd4fffcc19ef90d307a6b425e, data reload: false
query1 0.04 0.03 0.03
query2 0.08 0.04 0.04
query3 0.23 0.04 0.04
query4 1.68 0.07 0.08
query5 0.50 0.49 0.49
query6 1.14 0.72 0.72
query7 0.02 0.01 0.02
query8 0.05 0.04 0.05
query9 0.54 0.49 0.49
query10 0.56 0.54 0.53
query11 0.16 0.11 0.12
query12 0.15 0.12 0.12
query13 0.60 0.59 0.59
query14 0.77 0.79 0.79
query15 0.84 0.81 0.81
query16 0.36 0.36 0.37
query17 0.97 0.95 0.95
query18 0.24 0.25 0.23
query19 1.78 1.72 1.78
query20 0.02 0.01 0.01
query21 15.41 0.65 0.64
query22 3.95 6.50 2.41
query23 18.29 1.38 1.21
query24 2.09 0.22 0.21
query25 0.16 0.09 0.08
query26 0.27 0.17 0.17
query27 0.08 0.07 0.09
query28 13.29 1.02 1.01
query29 12.61 3.27 3.27
query30 0.25 0.06 0.06
query31 2.87 0.38 0.38
query32 3.28 0.47 0.47
query33 2.89 2.87 2.94
query34 17.02 4.40 4.44
query35 4.43 4.51 4.51
query36 0.66 0.48 0.47
query37 0.19 0.15 0.15
query38 0.15 0.15 0.14
query39 0.04 0.03 0.04
query40 0.18 0.14 0.14
query41 0.09 0.06 0.05
query42 0.05 0.05 0.05
query43 0.05 0.04 0.04
Total cold run time: 109.03 s
Total hot run time: 30.98 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36280:
URL: https://github.com/apache/doris/pull/36280#issuecomment-2165894275
<details>
<summary>TPC-DS: <b>Total hot run time: 173587 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit aff6d3104e868e3fd4fffcc19ef90d307a6b425e, data reload: false
query1 937 383 376 376
query2 6460 2560 2368 2368
query3 6646 206 214 206
query4 20841 17332 17414 17332
query5 3589 483 469 469
query6 241 165 178 165
query7 4585 299 300 299
query8 327 292 304 292
query9 8631 2458 2455 2455
query10 603 299 284 284
query11 10494 9930 10024 9930
query12 115 85 85 85
query13 1629 361 356 356
query14 8816 6861 7681 6861
query15 232 187 188 187
query16 7749 266 260 260
query17 1922 540 512 512
query18 1943 272 273 272
query19 196 151 153 151
query20 88 82 82 82
query21 201 128 122 122
query22 4584 4193 4047 4047
query23 33752 33632 33757 33632
query24 10650 2897 2968 2897
query25 599 401 369 369
query26 713 157 158 157
query27 2287 319 321 319
query28 6009 2142 2143 2142
query29 901 635 614 614
query30 263 154 164 154
query31 1023 801 736 736
query32 95 54 53 53
query33 663 298 293 293
query34 888 498 490 490
query35 762 625 638 625
query36 1128 963 995 963
query37 139 78 77 77
query38 3004 2810 2854 2810
query39 912 831 819 819
query40 212 130 138 130
query41 56 59 54 54
query42 111 103 100 100
query43 580 554 539 539
query44 1105 712 719 712
query45 196 171 163 163
query46 1065 736 731 731
query47 1882 1771 1776 1771
query48 376 296 299 296
query49 834 411 415 411
query50 775 399 403 399
query51 6741 6670 6581 6581
query52 114 89 107 89
query53 357 285 294 285
query54 861 449 438 438
query55 76 73 74 73
query56 279 260 264 260
query57 1163 1060 1056 1056
query58 279 246 255 246
query59 3479 3366 3292 3292
query60 294 274 280 274
query61 95 95 91 91
query62 616 433 462 433
query63 310 283 285 283
query64 8481 2277 1835 1835
query65 3189 3082 3096 3082
query66 742 325 330 325
query67 15226 15233 14788 14788
query68 4586 547 563 547
query69 603 397 377 377
query70 1178 1160 1041 1041
query71 422 282 280 280
query72 8254 5798 5432 5432
query73 760 324 328 324
query74 5864 5496 5508 5496
query75 3506 2666 2613 2613
query76 2472 946 884 884
query77 658 302 293 293
query78 10137 9864 9623 9623
query79 2447 508 508 508
query80 1020 470 470 470
query81 546 214 220 214
query82 657 106 102 102
query83 321 215 162 162
query84 267 85 90 85
query85 1707 285 277 277
query86 466 305 309 305
query87 3261 3080 3096 3080
query88 4100 2459 2431 2431
query89 470 380 384 380
query90 1783 190 192 190
query91 132 102 103 102
query92 64 52 49 49
query93 2320 504 507 504
query94 1154 190 192 190
query95 407 314 321 314
query96 603 269 271 269
query97 3213 3057 3024 3024
query98 229 201 193 193
query99 1266 842 830 830
Total cold run time: 268984 ms
Total hot run time: 173587 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "Dragonliu2018 (via GitHub)" <gi...@apache.org>.
Dragonliu2018 commented on PR #36280:
URL: https://github.com/apache/doris/pull/36280#issuecomment-2165796506
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #36280:
URL: https://github.com/apache/doris/pull/36280#issuecomment-2167378119
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36280:
URL: https://github.com/apache/doris/pull/36280#issuecomment-2165864636
<details>
<summary>TPC-H: <b>Total hot run time: 40346 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit aff6d3104e868e3fd4fffcc19ef90d307a6b425e, data reload: false
------ Round 1 ----------------------------------
q1 17615 4292 4279 4279
q2 2023 195 193 193
q3 10462 1113 1096 1096
q4 10193 725 793 725
q5 7464 2664 2647 2647
q6 228 134 136 134
q7 955 599 588 588
q8 9218 2044 2085 2044
q9 9008 6490 6464 6464
q10 8987 3712 3703 3703
q11 446 229 240 229
q12 479 228 226 226
q13 17762 2977 3002 2977
q14 268 212 223 212
q15 521 487 485 485
q16 527 391 377 377
q17 955 719 691 691
q18 7934 7349 7342 7342
q19 4362 1532 1453 1453
q20 655 304 319 304
q21 4976 3842 3914 3842
q22 407 335 345 335
Total cold run time: 115445 ms
Total hot run time: 40346 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4388 4230 4394 4230
q2 362 277 257 257
q3 2968 2804 2859 2804
q4 1978 1720 1689 1689
q5 5627 5506 5522 5506
q6 221 132 134 132
q7 2180 1814 1867 1814
q8 3239 3416 3369 3369
q9 8743 8658 8747 8658
q10 4109 3941 3680 3680
q11 581 471 482 471
q12 780 610 643 610
q13 17249 3169 3152 3152
q14 305 276 267 267
q15 527 493 490 490
q16 486 433 430 430
q17 1787 1520 1504 1504
q18 7995 7896 7872 7872
q19 1822 1580 1590 1580
q20 3041 1920 1863 1863
q21 5047 4928 4831 4831
q22 826 530 576 530
Total cold run time: 74261 ms
Total hot run time: 55739 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "Dragonliu2018 (via GitHub)" <gi...@apache.org>.
Dragonliu2018 commented on code in PR #36280:
URL: https://github.com/apache/doris/pull/36280#discussion_r1639100590
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/DefaultValue.java:
##########
@@ -40,6 +41,8 @@ public class DefaultValue {
public static DefaultValue BITMAP_EMPTY_DEFAULT_VALUE = new DefaultValue(ZERO);
// default "value", "[]" means empty array
public static DefaultValue ARRAY_EMPTY_DEFAULT_VALUE = new DefaultValue("[]");
+ // default "value", "3.14159265358979323846" means pi
+ public static DefaultValue PI_DEFAULT_VALUE = new DefaultValue("3.14159265358979323846", PI);
Review Comment:
Get, i'll add a code comment here.
`M_PI` is enough, because the precision of type double is 15~16 digits. but it is not adequate for computation using long double. in this case, use `M_PIl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "Dragonliu2018 (via GitHub)" <gi...@apache.org>.
Dragonliu2018 commented on code in PR #36280:
URL: https://github.com/apache/doris/pull/36280#discussion_r1638478877
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/DefaultValue.java:
##########
@@ -40,6 +41,8 @@ public class DefaultValue {
public static DefaultValue BITMAP_EMPTY_DEFAULT_VALUE = new DefaultValue(ZERO);
// default "value", "[]" means empty array
public static DefaultValue ARRAY_EMPTY_DEFAULT_VALUE = new DefaultValue("[]");
+ // default "value", "3.14159265358979323846" means pi
+ public static DefaultValue PI_DEFAULT_VALUE = new DefaultValue("3.14159265358979323846", PI);
Review Comment:
use `M_PIl` in <math.h> maybe better?
```c
# define M_PIl 3.141592653589793238462643383279502884L /* pi */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36280:
URL: https://github.com/apache/doris/pull/36280#issuecomment-2165796108
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #36280:
URL: https://github.com/apache/doris/pull/36280#discussion_r1638455456
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/DefaultValue.java:
##########
@@ -40,6 +41,8 @@ public class DefaultValue {
public static DefaultValue BITMAP_EMPTY_DEFAULT_VALUE = new DefaultValue(ZERO);
// default "value", "[]" means empty array
public static DefaultValue ARRAY_EMPTY_DEFAULT_VALUE = new DefaultValue("[]");
+ // default "value", "3.14159265358979323846" means pi
+ public static DefaultValue PI_DEFAULT_VALUE = new DefaultValue("3.14159265358979323846", PI);
Review Comment:
could you explain why this scale is proper. do we need more precision?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36280:
URL: https://github.com/apache/doris/pull/36280#issuecomment-2168048757
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36280:
URL: https://github.com/apache/doris/pull/36280#issuecomment-2167426905
<details>
<summary>TPC-H: <b>Total hot run time: 39968 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e5685149681e7f6f250598a764c04f224b9b8914, data reload: false
------ Round 1 ----------------------------------
q1 18052 4667 4417 4417
q2 3034 196 191 191
q3 11225 1119 1114 1114
q4 10437 761 889 761
q5 7810 2726 2661 2661
q6 226 141 136 136
q7 972 623 622 622
q8 9624 2065 2086 2065
q9 8680 6489 6469 6469
q10 8842 3704 3694 3694
q11 441 228 237 228
q12 403 229 229 229
q13 17758 2985 2950 2950
q14 278 217 215 215
q15 523 486 487 486
q16 521 380 377 377
q17 971 685 660 660
q18 7990 7550 7341 7341
q19 6418 1536 1526 1526
q20 671 316 329 316
q21 4869 3197 3176 3176
q22 384 335 334 334
Total cold run time: 120129 ms
Total hot run time: 39968 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4384 4256 4241 4241
q2 374 260 264 260
q3 2968 2761 2719 2719
q4 1839 1630 1661 1630
q5 5226 5310 5242 5242
q6 213 127 128 127
q7 2121 1697 1698 1697
q8 3147 3325 3288 3288
q9 8343 8353 8312 8312
q10 3874 3690 3653 3653
q11 588 481 483 481
q12 758 585 606 585
q13 16666 2966 2948 2948
q14 288 272 263 263
q15 521 466 490 466
q16 471 409 427 409
q17 1781 1479 1478 1478
q18 7609 7629 7275 7275
q19 1737 1570 1530 1530
q20 2012 1769 1780 1769
q21 4777 4607 4656 4607
q22 590 536 533 533
Total cold run time: 70287 ms
Total hot run time: 53513 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36280:
URL: https://github.com/apache/doris/pull/36280#issuecomment-2167445159
<details>
<summary>TPC-DS: <b>Total hot run time: 173280 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e5685149681e7f6f250598a764c04f224b9b8914, data reload: false
query1 945 375 371 371
query2 6473 2396 2283 2283
query3 6655 204 207 204
query4 19876 17360 17274 17274
query5 4195 473 468 468
query6 253 160 156 156
query7 4583 293 287 287
query8 324 296 287 287
query9 8558 2420 2390 2390
query10 600 297 300 297
query11 10596 10043 10055 10043
query12 139 87 84 84
query13 1643 388 357 357
query14 9844 7602 7590 7590
query15 256 194 203 194
query16 7821 256 262 256
query17 1903 526 551 526
query18 1949 287 268 268
query19 199 165 161 161
query20 93 84 79 79
query21 214 129 129 129
query22 4304 4035 4064 4035
query23 33581 32784 32872 32784
query24 11139 2928 2847 2847
query25 633 359 362 359
query26 1651 151 157 151
query27 2997 310 309 309
query28 7581 2056 2051 2051
query29 1006 608 590 590
query30 272 149 155 149
query31 945 754 747 747
query32 87 58 57 57
query33 759 308 303 303
query34 886 465 453 453
query35 739 613 609 609
query36 1082 921 953 921
query37 165 73 70 70
query38 2927 2736 2777 2736
query39 849 794 793 793
query40 274 123 128 123
query41 53 55 50 50
query42 119 99 103 99
query43 591 557 520 520
query44 1224 728 736 728
query45 198 163 165 163
query46 1076 740 681 681
query47 1851 1793 1786 1786
query48 377 297 286 286
query49 1170 412 415 412
query50 775 378 386 378
query51 6845 6722 6697 6697
query52 105 93 100 93
query53 365 299 296 296
query54 993 453 447 447
query55 75 72 75 72
query56 279 258 254 254
query57 1147 1039 1048 1039
query58 255 240 264 240
query59 3453 3190 3217 3190
query60 295 278 274 274
query61 90 90 92 90
query62 648 458 447 447
query63 314 284 296 284
query64 9973 2208 1773 1773
query65 3145 3128 3088 3088
query66 1373 340 329 329
query67 15687 14898 15054 14898
query68 5140 536 529 529
query69 591 433 413 413
query70 1167 1145 1086 1086
query71 439 276 276 276
query72 7845 5894 5471 5471
query73 775 324 331 324
query74 5929 5549 5514 5514
query75 3579 2647 2674 2647
query76 3199 907 935 907
query77 634 315 306 306
query78 10355 9832 9729 9729
query79 2043 528 533 528
query80 722 462 463 462
query81 565 223 217 217
query82 1384 110 104 104
query83 192 190 173 173
query84 239 87 83 83
query85 1454 295 275 275
query86 479 330 294 294
query87 3266 3088 3073 3073
query88 3750 2348 2347 2347
query89 470 378 394 378
query90 1803 205 200 200
query91 142 111 109 109
query92 64 51 52 51
query93 2193 516 500 500
query94 1243 200 202 200
query95 408 333 329 329
query96 589 266 266 266
query97 3229 3091 3016 3016
query98 218 207 203 203
query99 1211 876 865 865
Total cold run time: 276789 ms
Total hot run time: 173280 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "Dragonliu2018 (via GitHub)" <gi...@apache.org>.
Dragonliu2018 commented on code in PR #36280:
URL: https://github.com/apache/doris/pull/36280#discussion_r1639100590
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/DefaultValue.java:
##########
@@ -40,6 +41,8 @@ public class DefaultValue {
public static DefaultValue BITMAP_EMPTY_DEFAULT_VALUE = new DefaultValue(ZERO);
// default "value", "[]" means empty array
public static DefaultValue ARRAY_EMPTY_DEFAULT_VALUE = new DefaultValue("[]");
+ // default "value", "3.14159265358979323846" means pi
+ public static DefaultValue PI_DEFAULT_VALUE = new DefaultValue("3.14159265358979323846", PI);
Review Comment:
Get.
`M_PI` is enough, because the precision of type double is 15~16 digits. but it is not adequate for computation using long double. in this case, use `M_PIl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #36280:
URL: https://github.com/apache/doris/pull/36280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "Dragonliu2018 (via GitHub)" <gi...@apache.org>.
Dragonliu2018 commented on code in PR #36280:
URL: https://github.com/apache/doris/pull/36280#discussion_r1638473134
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/DefaultValue.java:
##########
@@ -40,6 +41,8 @@ public class DefaultValue {
public static DefaultValue BITMAP_EMPTY_DEFAULT_VALUE = new DefaultValue(ZERO);
// default "value", "[]" means empty array
public static DefaultValue ARRAY_EMPTY_DEFAULT_VALUE = new DefaultValue("[]");
+ // default "value", "3.14159265358979323846" means pi
+ public static DefaultValue PI_DEFAULT_VALUE = new DefaultValue("3.14159265358979323846", PI);
Review Comment:
refer to <math.h>:
```c++
# define M_PI 3.14159265358979323846 /* pi */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36280:
URL: https://github.com/apache/doris/pull/36280#issuecomment-2167378975
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Featrue](default value) add pi as default value [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #36280:
URL: https://github.com/apache/doris/pull/36280#discussion_r1638498281
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/DefaultValue.java:
##########
@@ -40,6 +41,8 @@ public class DefaultValue {
public static DefaultValue BITMAP_EMPTY_DEFAULT_VALUE = new DefaultValue(ZERO);
// default "value", "[]" means empty array
public static DefaultValue ARRAY_EMPTY_DEFAULT_VALUE = new DefaultValue("[]");
+ // default "value", "3.14159265358979323846" means pi
+ public static DefaultValue PI_DEFAULT_VALUE = new DefaultValue("3.14159265358979323846", PI);
Review Comment:
I think in legal range, more precision is better as default value. you could try the max precision which double could represent exactly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org