You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/03/21 15:45:19 UTC
[GitHub] [avro] thiru-mg opened a new pull request #1149: Avro 3089 fix cpp warnings
thiru-mg opened a new pull request #1149:
URL: https://github.com/apache/avro/pull/1149
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] thiru-mg merged pull request #1149: Avro 3089 fix cpp warnings
Posted by GitBox <gi...@apache.org>.
thiru-mg merged pull request #1149:
URL: https://github.com/apache/avro/pull/1149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] emkornfield commented on pull request #1149: Avro 3089 fix cpp warnings
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #1149:
URL: https://github.com/apache/avro/pull/1149#issuecomment-803621051
Is it possible to add the appropriate checks to CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] emkornfield commented on a change in pull request #1149: Avro 3089 fix cpp warnings
Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #1149:
URL: https://github.com/apache/avro/pull/1149#discussion_r598307351
##########
File path: lang/c++/test/DataFileTests.cc
##########
@@ -934,7 +934,7 @@ void testReadRecordEfficientlyUsingLastSync(avro::Codec codec) {
const uint8_t* pData = nullptr;
size_t length = 0;
- bool hasRead = seekableInputStream->next(&pData, &length);
+ seekableInputStream->next(&pData, &length);
Review comment:
it is probably better to add an assertion about hasRead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] emkornfield commented on a change in pull request #1149: Avro 3089 fix cpp warnings
Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #1149:
URL: https://github.com/apache/avro/pull/1149#discussion_r598307486
##########
File path: lang/c++/test/DataFileTests.cc
##########
@@ -896,9 +896,9 @@ void testReadRecordEfficientlyUsingLastSync(avro::Codec codec) {
const char* filename = "test_readRecordUsingLastSync.df";
- int numberOfRecords = 100;
- int recordToRead = 37; // pick specific record to read efficiently
- int syncPointWithRecord = 0;
+ size_t numberOfRecords = 100;
+ size_t recordToRead = 37; // pick specific record to read efficiently
+ size_t syncPointWithRecord = 0;
int finalSync = 0;
Review comment:
change these variables for consistency also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] emkornfield commented on pull request #1149: Avro 3089 fix cpp warnings
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #1149:
URL: https://github.com/apache/avro/pull/1149#issuecomment-803621792
A couple of comments, looks OK to me though. If possible (maybe as separate JIRA) adding additional checks into CI seems like a more maintanaible approach in the long term.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org