You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ableegoldman (via GitHub)" <gi...@apache.org> on 2024/12/29 11:49:30 UTC
[PR] KAFKA-18026: KIP-1112, configure all StoreBuilder & StoreFactory layers [kafka]
ableegoldman opened a new pull request, #18345:
URL: https://github.com/apache/kafka/pull/18345
Because of how we have to wrap StoreFactory and StoreBuilder layers on top of each other for various parts of the topology building process, we need to make sure both of these are capable of configuration and will check for & delegate to an underlying layer if it exists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18026: KIP-1112, configure all StoreBuilder & StoreFactory layers [kafka]
Posted by "guozhangwang (via GitHub)" <gi...@apache.org>.
guozhangwang commented on code in PR #18345:
URL: https://github.com/apache/kafka/pull/18345#discussion_r1900245732
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreBuilderWrapper.java:
##########
@@ -34,6 +35,7 @@
*/
public class StoreBuilderWrapper implements StoreFactory {
+
Review Comment:
nit? typo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18026: KIP-1112, configure all StoreBuilder & StoreFactory layers [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman commented on code in PR #18345:
URL: https://github.com/apache/kafka/pull/18345#discussion_r1900247881
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreBuilderWrapper.java:
##########
@@ -34,6 +35,7 @@
*/
public class StoreBuilderWrapper implements StoreFactory {
+
Review Comment:
yeah, typo. I'll remove this in one of my followup PRs so I can go ahead and merge this guy now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18026: KIP-1112, configure all StoreBuilder & StoreFactory layers [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman commented on PR #18345:
URL: https://github.com/apache/kafka/pull/18345#issuecomment-2566682652
Merged to trunk and cherrypicked to 4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18026: KIP-1112, configure all StoreBuilder & StoreFactory layers [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman merged PR #18345:
URL: https://github.com/apache/kafka/pull/18345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org