You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Brian McDevitt (Code Review)" <ge...@cloudera.org> on 2018/08/30 21:25:51 UTC
[kudu-CR] Improve runtime of slow java client security test.
Brian McDevitt has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11365
Change subject: Improve runtime of slow java client security test.
......................................................................
Improve runtime of slow java client security test.
KUDU-2489 - Shortened the kerberos renew lifetime parameter and the
Thread.sleep parameters. These changes cut the test runtime by ~50 seconds.
Change-Id: I19fa5185430a6c91fbe050dbc458b7b91e2d5bea
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/11365/1
--
To view, visit http://gerrit.cloudera.org:8080/11365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19fa5185430a6c91fbe050dbc458b7b91e2d5bea
Gerrit-Change-Number: 11365
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
[kudu-CR] KUDU-2489: Improve runtime of slow java test.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11365 )
Change subject: KUDU-2489: Improve runtime of slow java test.
......................................................................
KUDU-2489: Improve runtime of slow java test.
Shortened the kerberos renew lifetime parameter and the
Thread.sleep parameters. These changes cut the test runtime by ~30 seconds.
Change-Id: I19fa5185430a6c91fbe050dbc458b7b91e2d5bea
Reviewed-on: http://gerrit.cloudera.org:8080/11365
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I19fa5185430a6c91fbe050dbc458b7b91e2d5bea
Gerrit-Change-Number: 11365
Gerrit-PatchSet: 3
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2489: Improve runtime of slow java test.
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11365
to look at the new patch set (#2).
Change subject: KUDU-2489: Improve runtime of slow java test.
......................................................................
KUDU-2489: Improve runtime of slow java test.
Shortened the kerberos renew lifetime parameter and the
Thread.sleep parameters. These changes cut the test runtime by ~30 seconds.
Change-Id: I19fa5185430a6c91fbe050dbc458b7b91e2d5bea
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/11365/2
--
To view, visit http://gerrit.cloudera.org:8080/11365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I19fa5185430a6c91fbe050dbc458b7b91e2d5bea
Gerrit-Change-Number: 11365
Gerrit-PatchSet: 2
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Improve runtime of slow java client security test.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11365 )
Change subject: Improve runtime of slow java client security test.
......................................................................
Patch Set 1:
(1 comment)
This change would be great to have as the test runs about 2x as long as any other test.
It looks like the change is fairly flaky with this change. It fails on dist-test about 40% of the time with the error below:
1) testRenewAndReacquireKeberosCredentials(org.apache.kudu.client.TestSecurity)
org.apache.kudu.client.NonRecoverableException: server requires authentication, but client Kerberos credentials (TGT) have expired. Authentication tokens were not used because no token is available
at org.apache.kudu.client.KuduException.transformException(KuduException.java:110)
at org.apache.kudu.client.KuduClient.joinAndHandleException(KuduClient.java:365)
at org.apache.kudu.client.KuduClient.listTabletServers(KuduClient.java:188)
at org.apache.kudu.client.TestSecurity.checkClientCanReconnect(TestSecurity.java:137)
at org.apache.kudu.client.TestSecurity.testRenewAndReacquireKeberosCredentials(TestSecurity.java:330)
http://gerrit.cloudera.org:8080/#/c/11365/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11365/1//COMMIT_MSG@7
PS1, Line 7: Improve runtime of slow java client security test.
Nit: Put "KUDU-2489:" at the beginning of the subject.
--
To view, visit http://gerrit.cloudera.org:8080/11365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19fa5185430a6c91fbe050dbc458b7b91e2d5bea
Gerrit-Change-Number: 11365
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 31 Aug 2018 03:24:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] Improve runtime of slow java client security test.
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11365 )
Change subject: Improve runtime of slow java client security test.
......................................................................
Patch Set 1:
> Patch Set 1:
>
> (1 comment)
>
> This change would be great to have as the test runs about 2x as long as any other test.
>
> It looks like the change is fairly flaky with this change. It fails on dist-test about 40% of the time with the error below:
Yea, maybe moving this to be an integration test would be better rather than potentially introducing flakiness? Agreed that long running tests suck, but unfortunately it's not so easy to mock out the advancement of time across clients, servers, and krb5 libraries without some pretty substantial effort.
--
To view, visit http://gerrit.cloudera.org:8080/11365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19fa5185430a6c91fbe050dbc458b7b91e2d5bea
Gerrit-Change-Number: 11365
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 31 Aug 2018 03:36:37 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2489: Improve runtime of slow java test.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11365 )
Change subject: KUDU-2489: Improve runtime of slow java test.
......................................................................
Patch Set 2: Code-Review+2
This change passed 110/110 tests. lgtm.
--
To view, visit http://gerrit.cloudera.org:8080/11365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19fa5185430a6c91fbe050dbc458b7b91e2d5bea
Gerrit-Change-Number: 11365
Gerrit-PatchSet: 2
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 05 Sep 2018 01:29:04 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2489: Improve runtime of slow java test.
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/11365 )
Change subject: KUDU-2489: Improve runtime of slow java test.
......................................................................
Patch Set 2:
> > Patch Set 1:
> >
> > (1 comment)
> >
> > This change would be great to have as the test runs about 2x as
> long as any other test.
> >
> > It looks like the change is fairly flaky with this change. It
> fails on dist-test about 40% of the time with the error below:
>
> Yea, maybe moving this to be an integration test would be better
> rather than potentially introducing flakiness? Agreed that long
> running tests suck, but unfortunately it's not so easy to mock out
> the advancement of time across clients, servers, and krb5 libraries
> without some pretty substantial effort.
I adjusted the lifetime parameter once more as an experiment to see if the test is no longer flaky. The test passed 10/10 time on my laptop.
I'm happy to continue with this patch or move this test to the integration suite.
--
To view, visit http://gerrit.cloudera.org:8080/11365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19fa5185430a6c91fbe050dbc458b7b91e2d5bea
Gerrit-Change-Number: 11365
Gerrit-PatchSet: 2
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 31 Aug 2018 13:41:26 +0000
Gerrit-HasComments: No