You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/02/01 18:08:31 UTC

[GitHub] [zookeeper] ctubbsii commented on a change in pull request #1802: ZOOKEEPER-4455: Move to https://reload4j.qos.ch/ (remove log4j1)

ctubbsii commented on a change in pull request #1802:
URL: https://github.com/apache/zookeeper/pull/1802#discussion_r796861081



##########
File path: zookeeper-server/pom.xml
##########
@@ -77,6 +77,7 @@
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-log4j12</artifactId>
+      <scope>test</scope>

Review comment:
       slf4j-log4j12-1.7.35 maven coordinates automatically redirect to slf4j-reload4j-1.7.35
   
   So, you could just use the slf4j-reload4j binding directly, if you update the slf4j version to the latest, 1.7.35 (which I would recommend). If you do this, I see this would be done in the root POM, plus the server, plus 3 of the contrib POMs.
   
   See https://search.maven.org/artifact/org.slf4j/slf4j-log4j12/1.7.35/pom




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org