You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by an...@apache.org on 2006/09/28 16:23:27 UTC

svn commit: r450863 - in /ant/core/trunk: CONTRIBUTORS WHATSNEW contributors.xml src/main/org/apache/tools/ant/types/resources/URLResource.java

Author: antoine
Date: Thu Sep 28 07:23:26 2006
New Revision: 450863

URL: http://svn.apache.org/viewvc?view=rev&rev=450863
Log:
running junitreport several times, issues with closing URLResource, bugzilla report 40595


Modified:
    ant/core/trunk/CONTRIBUTORS
    ant/core/trunk/WHATSNEW
    ant/core/trunk/contributors.xml
    ant/core/trunk/src/main/org/apache/tools/ant/types/resources/URLResource.java

Modified: ant/core/trunk/CONTRIBUTORS
URL: http://svn.apache.org/viewvc/ant/core/trunk/CONTRIBUTORS?view=diff&rev=450863&r1=450862&r2=450863
==============================================================================
Binary files - no diff available.

Modified: ant/core/trunk/WHATSNEW
URL: http://svn.apache.org/viewvc/ant/core/trunk/WHATSNEW?view=diff&rev=450863&r1=450862&r2=450863
==============================================================================
--- ant/core/trunk/WHATSNEW (original)
+++ ant/core/trunk/WHATSNEW Thu Sep 28 07:23:26 2006
@@ -22,6 +22,8 @@
 
 * URLResource did not close jar files, and also did not disconnect HTTPConnection (s).
 
+* error calling junitreport. Bugzilla 40595. 
+
 * <junittask/> created junitvmwatcher*.properties files but did not close and delete them.  
 
 * <xmlproperty> did not create properties for empty leaf elements.

Modified: ant/core/trunk/contributors.xml
URL: http://svn.apache.org/viewvc/ant/core/trunk/contributors.xml?view=diff&rev=450863&r1=450862&r2=450863
==============================================================================
--- ant/core/trunk/contributors.xml (original)
+++ ant/core/trunk/contributors.xml Thu Sep 28 07:23:26 2006
@@ -398,6 +398,10 @@
     <first>Jan</first>
     <last>Mat&#232;rne</last>
   </name>
+    <name>
+      <first>Jan</first>
+      <last>Cumps</last>
+    </name>
   <name>
     <first>Jan</first>
     <last>Mynarik</last>

Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resources/URLResource.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/types/resources/URLResource.java?view=diff&rev=450863&r1=450862&r2=450863
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/types/resources/URLResource.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/types/resources/URLResource.java Thu Sep 28 07:23:26 2006
@@ -361,7 +361,6 @@
      * @throws Throwable on error.
      */
     protected void finalize() throws Throwable {
-        close();
         conn = null;
         super.finalize();
     }



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: svn commit: r450863 - in /ant/core/trunk: CONTRIBUTORS WHATSNEW contributors.xml src/main/org/apache/tools/ant/types/resources/URLResource.java

Posted by Antoine Levy-Lambert <an...@gmx.de>.
Hello Peter,

thanks for your suggestion, I have just committed the change.

Regards,

Antoine
-------- Original-Nachricht --------
Datum: Thu, 28 Sep 2006 15:41:39 +0100
Von: "Peter Reilly" <pe...@gmail.com>
An: "Ant Developers List" <de...@ant.apache.org>
Betreff: Re: svn commit: r450863 - in /ant/core/trunk: CONTRIBUTORS WHATSNEW contributors.xml src/main/org/apache/tools/ant/types/resources/URLResource.java

> URL:
> >
> http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/types/resources/URLResource.java?view=diff&rev=450863&r1=450862&r2=450863
> >
> >
> ==============================================================================
> > ---
> >
> ant/core/trunk/src/main/org/apache/tools/ant/types/resources/URLResource.java
> > (original)
> > +++
> >
> ant/core/trunk/src/main/org/apache/tools/ant/types/resources/URLResource.java
> > Thu Sep 28 07:23:26 2006
> > @@ -361,7 +361,6 @@
> >       * @throws Throwable on error.
> >       */
> >      protected void finalize() throws Throwable {
> > -        close();
> >          conn = null;
> >          super.finalize();
> >      }
> 
> 
> My advice would be to remove the finalize method completely.
> Having a finalize method is not good practice - it interacts badly
> with GC.
> the current version of this method in effect does nothing except trying to
> "help" gc.
> see:
> 
> http://devresource.hp.com/drc/resources/jmemmodel/index.jsp
> 
> 

> >

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: svn commit: r450863 - in /ant/core/trunk: CONTRIBUTORS WHATSNEW contributors.xml src/main/org/apache/tools/ant/types/resources/URLResource.java

Posted by Peter Reilly <pe...@gmail.com>.
URL:
> http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/types/resources/URLResource.java?view=diff&rev=450863&r1=450862&r2=450863
>
> ==============================================================================
> ---
> ant/core/trunk/src/main/org/apache/tools/ant/types/resources/URLResource.java
> (original)
> +++
> ant/core/trunk/src/main/org/apache/tools/ant/types/resources/URLResource.java
> Thu Sep 28 07:23:26 2006
> @@ -361,7 +361,6 @@
>       * @throws Throwable on error.
>       */
>      protected void finalize() throws Throwable {
> -        close();
>          conn = null;
>          super.finalize();
>      }


My advice would be to remove the finalize method completely.
Having a finalize method is not good practice - it interacts badly
with GC.
the current version of this method in effect does nothing except trying to
"help" gc.
see:

http://devresource.hp.com/drc/resources/jmemmodel/index.jsp



---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>